4a3ba199155a58cd282ee0383925525141593413: Bug 1343955 - part 3: Implement similar C++ utility of _computeKeyCodeFromChar() in EventUtils.js and make it accssible with nsITextInputProcessor for EventUtils.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 03 Oct 2018 09:24:15 +0000 - rev 495139
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1343955 - part 3: Implement similar C++ utility of _computeKeyCodeFromChar() in EventUtils.js and make it accssible with nsITextInputProcessor for EventUtils.js r=smaug This implement a helper API to guess keyCode value of a printable key with assuming active keyboard layout is US-English. The reason why this stops computing key value from key value is, most users of such API probably want to emulate input from US-English keyboard layout if they don't specify the detail. Therefore, the new API simply maps each ASCII character to a DOM keyCode which is usually mapped in US-English keyboard layout. Differential Revision: https://phabricator.services.mozilla.com/D5515
fea8e039767a88ebfb73b1f0d43d1f87ee7394e1: Bug 1343955 - part 2: Implement _guessCodeFromKeyName() in EventUtils.js with C++ and make it accessible with nsITextInputProcessor for EventUtils.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 03 Oct 2018 09:21:47 +0000 - rev 495138
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1343955 - part 2: Implement _guessCodeFromKeyName() in EventUtils.js with C++ and make it accessible with nsITextInputProcessor for EventUtils.js r=smaug We need to port synthesizeKey() of EventUtils.js to FuzzingFunctions. So, its helper function, _guessCodeFromKeyName() in EventUtils.js needs to be accessible from FuzzingFunctions. Therefore, we need to reimplement it with C++ and make it accessible via nsITextInputProcessor for EventUtils.js for making easier to maintain. This patch moves _guessCodeFromKeyName() into TextInputProcessor and WidgetKeyboardEvent. Non-printable key part of _guessCodeFromKeyName() is moved to WidgetKeyboardEvent::ComputeCodeNameIndexFromKeyNameIndex() because of not depending on active keyboard layout. On the other hand, printable key part needs to assume that active keyboard layout is en-US keyboard layout. Therefore, it's moved to TextInputProcessor::GuessCodeValueOfPrintableKeyInUSEnglishKeyboardLayout() because any Core code shouldn't refer it as utility method for keeping that we're i18n-aware. Differential Revision: https://phabricator.services.mozilla.com/D5514
1a1ef374eba66c3af2c252711e607d095e2c2c23: Bug 1343955 - part 1: Add automated tests for synthesizeKey() of EventUtils.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 02 Oct 2018 14:31:56 +0000 - rev 495137
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1343955 - part 1: Add automated tests for synthesizeKey() of EventUtils.js r=smaug For preventing regressions of the following patches, test_sanityEventUtils.html should have more tests of syntheiszeKey(). Differential Revision: https://phabricator.services.mozilla.com/D5513
f54d088190672270c1487359a13a9ec9a9940e79: Bug 1343955 - part 0: Fix bug of browser_panel_keyboard_navigation.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 02 Oct 2018 14:21:11 +0000 - rev 495136
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1343955 - part 0: Fix bug of browser_panel_keyboard_navigation.js r=smaug browser_panel_keyboard_navigation.js sets "Tab" to first argument of EventUtils.synthesizeKey(). However, this causes inputting "T", "a", "b" with a key press. The test intended to emulate pressing the "Tab" key. So, it should be "KEY_Tab". Note that this will cause permanent orange with the following patches since synthesizeKey() will detect this kind of mistake. Differential Revision: https://phabricator.services.mozilla.com/D7412
5b0ef00bdd7c5c98aa8eea2ffcd077fe23d10d8c: Bug 1469696 - Part 6: Update warning message, limit width r=flod,jaws
Mark Striemer <mstriemer@mozilla.com> - Tue, 02 Oct 2018 17:57:33 +0000 - rev 495135
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1469696 - Part 6: Update warning message, limit width r=flod,jaws Differential Revision: https://phabricator.services.mozilla.com/D7216
54abaf608a606310adfebfa816051aa55bf6475a: Bug 1469696 - Part 5: Test listing and installing AMO langpacks r=aswan,jaws
Mark Striemer <mstriemer@mozilla.com> - Tue, 02 Oct 2018 17:57:33 +0000 - rev 495134
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r=aswan,jaws Differential Revision: https://phabricator.services.mozilla.com/D6315
4973d5d699c5f6dc29d3c7f512431d3ae49b11f9: Bug 1469696 - Part 4: Separate installed and available langpacks r=flod,jaws
Mark Striemer <mstriemer@mozilla.com> - Tue, 02 Oct 2018 17:57:32 +0000 - rev 495133
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1469696 - Part 4: Separate installed and available langpacks r=flod,jaws Differential Revision: https://phabricator.services.mozilla.com/D6314
10b8ab80417dafbf54c53b7916b3493e015d2bc2: Bug 1469696 - Part 3: Allow searching for languages from dialog r=jaws
Mark Striemer <mstriemer@mozilla.com> - Tue, 02 Oct 2018 17:57:32 +0000 - rev 495132
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1469696 - Part 3: Allow searching for languages from dialog r=jaws Differential Revision: https://phabricator.services.mozilla.com/D6313
31c94d7845b709c7a6d8ff8cf8e35b9b918091fd: Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r=flod,aswan,zbraniecki,jaws
Mark Striemer <mstriemer@mozilla.com> - Wed, 03 Oct 2018 14:07:14 +0000 - rev 495131
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r=flod,aswan,zbraniecki,jaws Differential Revision: https://phabricator.services.mozilla.com/D6312
263bd17c558edae18391d2cda36d476a7cbd97f5: Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r=aswan,jaws
Mark Striemer <mstriemer@mozilla.com> - Tue, 02 Oct 2018 17:57:31 +0000 - rev 495130
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r=aswan,jaws Differential Revision: https://phabricator.services.mozilla.com/D6311
3a3be25d07750cf6d469971bd8b26fdaf80cc7ea: Bug 1496041 - Remove unused ImageValue constructor. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 03 Oct 2018 12:13:57 +0000 - rev 495129
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1496041 - Remove unused ImageValue constructor. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D7589
a243b88f852a73cc9ef3ca1ac9caa4665900da0e: Bug 1487321 - [Static-Analysis][Clang-Tidy] Add new checkers present in 7.0. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 02 Oct 2018 14:10:32 +0000 - rev 495128
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1487321 - [Static-Analysis][Clang-Tidy] Add new checkers present in 7.0. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D7045
93467731a34be3601ec78af984b3d7f4d0af45cd: Bug 1490954 - Review Connect page CSS. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Wed, 03 Oct 2018 13:53:46 +0000 - rev 495127
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1490954 - Review Connect page CSS. r=jdescottes,daisuke - Fixed some values so they match what it's being used in about:preferences (font sizes, margins, etc.) - Fixed page width in Connect page - Refactored some rules to be more generic and not tied up to this specific component - Now a default message appears instead of an empty <ul> when there are no network locations in the list - Adjusted icon & alignment in the Connect sections' headings Differential Revision: https://phabricator.services.mozilla.com/D7103
fde09c00acd82c394072742d1ac36dc829903415: Bug 1496026 - Add intl/ & gfx/ to the list of directories on which to run codespell r=ahal
Sylvestre Ledru <sledru@mozilla.com> - Wed, 03 Oct 2018 13:40:18 +0000 - rev 495126
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1496026 - Add intl/ & gfx/ to the list of directories on which to run codespell r=ahal Depends on D7584 Differential Revision: https://phabricator.services.mozilla.com/D7585
853e6a2f456157b664591ba47f30d8a3482b1bf8: Bug 1496026 - Fix some trivial typos r=ahal
Sylvestre Ledru <sledru@mozilla.com> - Wed, 03 Oct 2018 13:39:07 +0000 - rev 495125
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1496026 - Fix some trivial typos r=ahal Differential Revision: https://phabricator.services.mozilla.com/D7584
dcba2a476ccfb77f859b3614d2c77ed3cc06a225: Bug 1305743 - Make failure to find mozinfo.json a fatal error r=gbrown,ahal a=reland
Edwin Gao <egao@mozilla.com> - Wed, 26 Sep 2018 20:07:25 +0000 - rev 495124
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1305743 - Make failure to find mozinfo.json a fatal error r=gbrown,ahal a=reland - moved placement of the raise_exception computation to be after the initial objdir path computation. - original implementation was missing detection for cases where user may pass in a False flag to explicitly suppress errors. - added unit tests to check for scenarios where raise_exception flag is passed in as part of positional argument. - changed argument to include a **kwargs argument for caller to modify default exception behavior. - default behavior is to raise exceptions if mozinfo.json cannot be found. - disabled TreeMetadataEmitter from calling mozinfo.find_and_update_from_json and setting the self.info variable since it was not referenced anywhere else after the initial setup. Depends on D6859 Differential Revision: https://phabricator.services.mozilla.com/D6860
6c9edde85770866e02a630ddd03c6a66dd735b86: Backed out 3 changesets (bug 1409739) for causing Linux x64 ccov & fuzzing bustages. a=backout
Cosmin Sabou <csabou@mozilla.com> - Wed, 03 Oct 2018 20:29:42 +0300 - rev 495123
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Backed out 3 changesets (bug 1409739) for causing Linux x64 ccov & fuzzing bustages. a=backout Backed out changeset 387f946c7c48 (bug 1409739) Backed out changeset 617288a6b2d9 (bug 1409739) Backed out changeset fcdc1d5eaf1a (bug 1409739)
7a00217bd2fac77aaad3d3a98730594b362ede5f: Backed out changeset 6d25c44c39ea (bug 1305743) on request from jgraham for causing issues with mozinfo.json. a=backout
Cosmin Sabou <csabou@mozilla.com> - Wed, 03 Oct 2018 20:27:01 +0300 - rev 495122
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Backed out changeset 6d25c44c39ea (bug 1305743) on request from jgraham for causing issues with mozinfo.json. a=backout
3530790e23d18b6f8f73471e367a942f201dd452: Merge inbound to mozilla-central. a=merge
Ciure Andrei <aciure@mozilla.com> - Wed, 03 Oct 2018 19:44:02 +0300 - rev 495121
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Merge inbound to mozilla-central. a=merge
2a30a201d8cd303cece8e48e95bc586f757c1cdf: Bug 1494162 - Part 46: Lazy load openDocLink and assert in MeatballMenu. r=jdescottes
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 03 Oct 2018 09:38:00 -0400 - rev 495120
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494162 - Part 46: Lazy load openDocLink and assert in MeatballMenu. r=jdescottes
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip