49c2fbd9779e6272a994f50478872cb47fdda756: servo: Merge #20252 - Extract text emphasis style (from NeverHappened:extract_text_emphasis_style); r=upsuper
Dmitry <dk@elonsoft.ru> - Fri, 09 Mar 2018 19:20:10 -0500 - rev 460019
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
servo: Merge #20252 - Extract text emphasis style (from NeverHappened:extract_text_emphasis_style); r=upsuper <!-- Please describe your changes on the following line: --> Extracted the text-emphasis-style property out of the inherited_text.mako.rs. This is a part of #19015 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] `./mach cargo-geckolib check` does not report any errors - [X] These changes fix #19940 (github issue number if applicable). <!-- Either: --> - [X] These changes do not require tests because it's a refactoring <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: aa8fb3a2044c03301e23aa9ffbee1161b9bd092c
1dfc5eba64f1b2ddb308da27206bd39de8a7f1a6: Backed out 2 changesets (bug 1223726) for failing devtools/client/styleeditor/test/browser_styleeditor_fetch-from-netmonitor.js a=backout on a CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Sat, 10 Mar 2018 02:44:19 +0200 - rev 460018
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Backed out 2 changesets (bug 1223726) for failing devtools/client/styleeditor/test/browser_styleeditor_fetch-from-netmonitor.js a=backout on a CLOSED TREE Backed out changeset a95b0b28ca16 (bug 1223726) Backed out changeset 6adb35cc708e (bug 1223726)
5f5da5116bfa9b16e9b9cd35cd7e9237dfc2785a: servo: Merge #20262 - constellation: Make setting up the WebGL state fallible (from emilio:webgl-fallible); r=jdm
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Mar 2018 18:24:56 -0500 - rev 460017
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
servo: Merge #20262 - constellation: Make setting up the WebGL state fallible (from emilio:webgl-fallible); r=jdm This fixes a regression caused by the glutin update. We now are creating EGL contexts in Linux Wayland, instead of X context, so the GLContextFactory assumption of one GL back-end per platform is broken. This just works around it, for now, but in general I think not relying on available WebGL state is a good thing, and we do that already for WebVR anyway. Source-Repo: https://github.com/servo/servo Source-Revision: 95f9e14e67766b36a8b72e62925a34b1818be2c8
3bf5123d0218751b86fdff5654ab5bcdefabec6d: Bug 1443749 only reload sidebar when the url has changed r=kmag
Shane Caraveo <scaraveo@mozilla.com> - Fri, 09 Mar 2018 16:30:49 -0600 - rev 460016
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1443749 only reload sidebar when the url has changed r=kmag Regression from bug 1398713. Before that, we reloaded the entire webext-panel.xul if the sidebar changed. This verifies we don't reload unecessarily as well as discards the browser to force a runtime disconnect for the extension if it does change. MozReview-Commit-ID: LuYxmj9mSb7
14f77d01522bf9881b6659e6f8bbbf2677f81ee3: Bug 1444481 part 3: #include nsStringFwd.h rather than nsString.h in some layout/style headers. r=xidorn
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 09 Mar 2018 11:55:12 -0800 - rev 460015
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1444481 part 3: #include nsStringFwd.h rather than nsString.h in some layout/style headers. r=xidorn These files only use references to string types, e.g. "nsAString&", so they only need forward-declarations of these types -- not the full definition. Note that the last file here (nsStyleUtil.h) already has an #include for nsStringFwd.h, which is why that files change is just a pure removal (of the unnecessary nsString.h #include). MozReview-Commit-ID: 9sLSyeBS49M
54aa980d30f7a4d96e18dda8f298bbb32d95035d: Bug 1444481 part 2: Replace unneeded #includes in nsStyleConsts.h with more specific ones (and add missing headers to nsStyleCoord.h). r=xidorn
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 09 Mar 2018 11:53:22 -0800 - rev 460014
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1444481 part 2: Replace unneeded #includes in nsStyleConsts.h with more specific ones (and add missing headers to nsStyleCoord.h). r=xidorn nsStyleConsts.h doesn't use anything from gfxRect.h or nsFont.h, so this patch removes those #includes from it. However, it does need some other headers that it was pulling in indirectly via those #includes, which I'm now making it *directly* #include. Specifically, it needs: - inttypes.h for "uint8_t" - gfxFontConstants.h for NS_FONT_WEIGHT_BOLD and related constants. On its own, the above changes cause build errors in nsStyleCoord.h, because that other header has an #include for nsStyleConsts.h, which it was inadvertently depending on (very indirectly) to provide some definitions (via the aforementioned removed #includes). So we need to give nsStyleCoord.h some new #includes to directly provide what it needs & keep it compiling. Specifically: - mozilla/gfx/Types.h for the mozilla::Side type - nsISupportsImpl.h for the NS_INLINE_DECL_THREADSAFE_REFCOUNTING macro MozReview-Commit-ID: BDlaIIOQiPE
37e3ec770550abec14beb8eb9939da78d578a2bb: Bug 1444481 part 1: Add some needed #includes to ComputedTimingFunction.h and FrameMetrics.h. r=xidorn
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 09 Mar 2018 11:52:02 -0800 - rev 460013
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1444481 part 1: Add some needed #includes to ComputedTimingFunction.h and FrameMetrics.h. r=xidorn (This is a helper patch -- I'm splitting this into its own patch since it's changing files in other directories, and also so that the main patches here can be a bit more direct.) Without this change, the other patches in this series would cause compile failures in the headers that I'm fixing up here (because the other patches will be removing #includes from some headers that these files were inadvertently depending on). As of this patch, ComputedTimingFunction.h will now be including: - nsDebug.h to provide NS_ASSERTION - nsStringFwd.h to provide a forward-declaration for "nsAString&" - Assertions.h to provide MOZ_ASSERT - Maybe.h to provide Maybe<ComputedTimingFunction> (I think it's been leaning on nsTimingFunction.h's include of nsString.h to indirectly provide these.) FrameMetrics.h will now be including: - PLDHashTable.h to provide PLDHashNumber (I think it's been leaning on nsStyleCoord.h/nsStyleConsts.h to indirectly provide this.) MozReview-Commit-ID: AoFoEe9GisK
bedc6f6583bf50e57135d20af8b75c5138a655e8: Bug 1442312 - Wait for addon reload to finish in tests. r=jdescottes
J. Ryan Stinnett <jryans@gmail.com> - Thu, 08 Mar 2018 19:05:32 -0600 - rev 460012
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442312 - Wait for addon reload to finish in tests. r=jdescottes In about:debugging's browser_addon_reload.js test, we would request a reload without waiting for it to reply. This led to the RDP connection closing before the reply could be sent, triggering later errors. For better test correctness, we now emit an event on reply and the test waits to receive it before proceeding. MozReview-Commit-ID: Jfps7MJ6Pzo
3ca7ee7f010fbb8e85fbe5dc71edfe61fa15c8dd: Bug 1442312 - Move allowed rejections into specific tests they apply to. r=ochameau
J. Ryan Stinnett <jryans@gmail.com> - Thu, 08 Mar 2018 18:14:52 -0600 - rev 460011
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442312 - Move allowed rejections into specific tests they apply to. r=ochameau By moving only the rejections that actually still apply into each test and out of the shared head file, we are much more likely to notice new instances and catch them when writing and editing tests in the future. Bug 1018184 can be used to actually resolve these issues. MozReview-Commit-ID: Qb71PsuutB
fbc3768c446ad1b74439e6a16e08e353656b1c0c: Bug 1442312 - Finish DevTools server conversion to DOM Promises. r=ochameau
J. Ryan Stinnett <jryans@gmail.com> - Wed, 07 Mar 2018 16:52:51 -0600 - rev 460010
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442312 - Finish DevTools server conversion to DOM Promises. r=ochameau Remove the last sync promises from the server. This causes server replies to be sent later than before, potentially later enough that the connection has since been closed. We now throw errors in such cases. MozReview-Commit-ID: 2x213g7poH5
31d94cfa44e855ad81fb70779f6568ed902e930e: servo: Merge #20258 - Continue to improve style_derive (from servo:derive-all-the-things); r=emilio
Anthony Ramine <n.oxyde@gmail.com> - Fri, 09 Mar 2018 17:29:05 -0500 - rev 460009
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
servo: Merge #20258 - Continue to improve style_derive (from servo:derive-all-the-things); r=emilio Source-Repo: https://github.com/servo/servo Source-Revision: 909ebff1844c3fcf95ea3b479b61077ff5a552e2
9a200b344efec72f896bf4ebda15a53b357da00a: Bug 1444404 - Use default (true) value for browser.newtabpage.enabled for testing. r=jmaher
Ed Lee <edilee@mozilla.com> - Fri, 09 Mar 2018 10:47:10 -0800 - rev 460008
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1444404 - Use default (true) value for browser.newtabpage.enabled for testing. r=jmaher Before bug 1383599, the pref had effectively been always true as about:newtab always just loaded activity stream. Switching the test pref to be true matches the old behavior to fix the AWSY regression to later decide what this pref should be for testing in bug 1444498. MozReview-Commit-ID: Af9v2rgUZdl
dd45b23b67c8eabffaeb17111d23e1d887e57173: Backed out changeset 609e4952a46e (bug 1444082) for perma-failing android-4.3-arm7-api-16/opt-robocop-3 (RC3) CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Sat, 10 Mar 2018 01:14:09 +0200 - rev 460007
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Backed out changeset 609e4952a46e (bug 1444082) for perma-failing android-4.3-arm7-api-16/opt-robocop-3 (RC3) CLOSED TREE
010b589f89a0ded63676176e08255a927c429f94: Bug 1442749 - Add back line accidentally removed in bug 1432355. r=Gijs
Michael Kaply <mozilla@kaply.com> - Fri, 09 Mar 2018 15:30:33 -0600 - rev 460006
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442749 - Add back line accidentally removed in bug 1432355. r=Gijs MozReview-Commit-ID: B6BfCzwfeuc
3a4d96efd68f90a033516a3d68d30ebee01a5f08: Bug 1307555 - Mochitest. r=kats
Botond Ballo <botond@mozilla.com> - Mon, 26 Feb 2018 16:39:35 -0500 - rev 460005
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1307555 - Mochitest. r=kats MozReview-Commit-ID: 1e06rX4SQD8
d9910fc2faa6b0054668551c4f892798c5668850: Bug 1307555 - Create a hit test info item for a scroll frame's scrolled frame that's not clipped to the displayport. r=mstange
Botond Ballo <botond@mozilla.com> - Mon, 26 Feb 2018 19:03:32 -0500 - rev 460004
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1307555 - Create a hit test info item for a scroll frame's scrolled frame that's not clipped to the displayport. r=mstange MozReview-Commit-ID: 5MJg4zqxSAk
a49ec516aafd994407a19e50052e0c0e0e7546da: Bug 1442250 - 5. Reset native queue early when transferring; r=esawin
Jim Chen <nchen@mozilla.com> - Fri, 09 Mar 2018 12:34:38 -0500 - rev 460003
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442250 - 5. Reset native queue early when transferring; r=esawin When we reset the old native queue when transferring to another session, perform the reset right after the transfer() call, instead of in onTransfer(), which is too late for clearing stale pending calls. Then, after transferring to a new queue, let Gecko call Window.onReady to set the new queue's state if needed. That way the Java queue state is consistent with the Gecko state. MozReview-Commit-ID: CUXGrhR4FCD
beefe251970fd65eaa9b52bb28fa784a02488c97: Bug 1442250 - 4. Fix crash when child preloading fails; r=jchen
Jim Chen <nchen@mozilla.com> - Fri, 09 Mar 2018 12:34:37 -0500 - rev 460002
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442250 - 4. Fix crash when child preloading fails; r=jchen Fix a null pointer crash when we fail to preload a child process. MozReview-Commit-ID: FIJopxOVAEj
f06bf979916a4cb4a65402272827c1aa86c8e1d4: Bug 1442250 - 3. Track EventDispatcher attach/detach; r=esawin
Jim Chen <nchen@mozilla.com> - Fri, 09 Mar 2018 12:34:37 -0500 - rev 460001
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442250 - 3. Track EventDispatcher attach/detach; r=esawin In an "attach > detach > attach" sequence, detach will post a call to disposeNative, so the sequence looks like "attach > detach > attach > disposeNative". In that case, disposeNative will cancel attach. This patch makes us ignore disposeNative in that case, so the second attach works as intended. MozReview-Commit-ID: Kr55PZcsPg1
e534002a0483610dd61b6277c70be628aa1f5bc5: Bug 1442250 - 2. Unregister then re-register all listeners on close; r=esawin
Jim Chen <nchen@mozilla.com> - Fri, 09 Mar 2018 12:34:37 -0500 - rev 460000
Push 8824 by archaeopteryx@coole-files.de at Mon, 12 Mar 2018 14:54:48 +0000
Bug 1442250 - 2. Unregister then re-register all listeners on close; r=esawin Ensure that we unregister and re-register all listeners on closeWindow, so that the listeners are ready for any new windows that are subsequently opened. MozReview-Commit-ID: EKzCRS10odN
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip