40d2ccee4fa895a9b83db74259b8305ce072b99e: Backed out changeset 399d40cb5c1c (bug 1384688)
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 31 Jul 2017 20:09:47 +0200 - rev 420730
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 399d40cb5c1c (bug 1384688)
b32c85d2d03181b02a1243af8e39f2b98a164f60: Backed out changeset 802c36bf1b27 (bug 1384688)
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 31 Jul 2017 20:09:41 +0200 - rev 420729
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Backed out changeset 802c36bf1b27 (bug 1384688)
802c36bf1b27ed53c8c396c6e081e3f0ab02b53f: Bug 1384688 - Update profile version to 8. r=njn
Markus Stange <mstange@themasta.com> - Thu, 27 Jul 2017 19:11:53 -0400 - rev 420728
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384688 - Update profile version to 8. r=njn MozReview-Commit-ID: K8IGUZ3NTRY
399d40cb5c1c2046a4296043976609863e2496bb: Bug 1384688 - Add a pausedRanges field to the profile JSON of each process which lists time ranges during which the profiler was paused or collecting a profile. r=njn
Markus Stange <mstange@themasta.com> - Fri, 28 Jul 2017 16:40:37 -0400 - rev 420727
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384688 - Add a pausedRanges field to the profile JSON of each process which lists time ranges during which the profiler was paused or collecting a profile. r=njn MozReview-Commit-ID: 6nzt7uHTLVm
3ad8f1ba9de6ebe7fae8b41ea5c3e280b8b71b86: Bug 1384688 - Pass aIsShuttingDown == true when obtaining shutdown profiles. r=njn
Markus Stange <mstange@themasta.com> - Fri, 28 Jul 2017 16:16:54 -0400 - rev 420726
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384688 - Pass aIsShuttingDown == true when obtaining shutdown profiles. r=njn MozReview-Commit-ID: Aw79gYQgkqy
e9d92bc3be81366484f4929d1554c21e73a7ff59: Bug 1384688 - Add an aIsShuttingDown argument to profiler_get_profile() and to profiler_stream_json_for_this_process(). r=njn
Markus Stange <mstange@themasta.com> - Mon, 31 Jul 2017 13:11:19 -0400 - rev 420725
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384688 - Add an aIsShuttingDown argument to profiler_get_profile() and to profiler_stream_json_for_this_process(). r=njn When set to true, the resulting profile will have a non-null meta.shutdownTime field which is set to current time. Non-shutdown profiles also get that field, but it's null for them. MozReview-Commit-ID: 1vpmhBR8rC6
ed86b892433b5c4049122b0561a8012a353c6ea1: Bug 1384688 - Add thread register and unregister time. r=njn
Markus Stange <mstange@themasta.com> - Fri, 28 Jul 2017 15:43:19 -0400 - rev 420724
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384688 - Add thread register and unregister time. r=njn MozReview-Commit-ID: JDRP8m7QrE1
5bc2b72074a38e3b7101a8afdb7457f5241c427c: Bug 1385868 - Stop reporting installer size as a treeherder job detail r=gps
William Lachance <wlachance@mozilla.com> - Mon, 31 Jul 2017 08:51:31 -0400 - rev 420723
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1385868 - Stop reporting installer size as a treeherder job detail r=gps MozReview-Commit-ID: CruOSWu0BT8
8227a596f3fd5de690caf5e8d66d731b50f1c6ed: Bug 1369604: Add additional comments to Highlights performance changes. r=mcomella
Michael Comella <michael.l.comella@gmail.com> - Fri, 28 Jul 2017 18:06:48 -0700 - rev 420722
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1369604: Add additional comments to Highlights performance changes. r=mcomella MozReview-Commit-ID: A5uzxbKisWF
95ca4a6f89572763b25a41403861871104af6f44: Bug 1369604 - review: rm comment from WONTFIX'd bug. r=mcomella
Michael Comella <michael.l.comella@gmail.com> - Fri, 28 Jul 2017 17:58:05 -0700 - rev 420721
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1369604 - review: rm comment from WONTFIX'd bug. r=mcomella MozReview-Commit-ID: 5zgonuODZHQ
dd051eb3bbf65a6276b374ce70a523831c1c4628: Bug 1369604: Force lazily-loaded metadata to load on background thread. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Fri, 28 Jul 2017 15:02:57 -0700 - rev 420720
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1369604: Force lazily-loaded metadata to load on background thread. r=liuche This undoes a caveat created from the last changeset; I did not profile this change. MozReview-Commit-ID: 6jpXyt0GRUj
e755f4ab80fdc2f6f9571854502034b1cb930ff1: Bug 1369604: Replace Metadata JSON parsing with faster regex matching. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Fri, 28 Jul 2017 13:45:41 -0700 - rev 420719
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1369604: Replace Metadata JSON parsing with faster regex matching. r=liuche I replaced JSON parsing for all highlight candidates (at most, 500) with a faster estimation using regex: we only use the full JSON parsing to get the perfect values for the items to be shown (~5). One caveat of this change: JSON parsing will be moved to the main thread when the getMetadataSlow is lazily-loaded. Disclaimer: my device seems to be running faster than yesterday so profiling may not be consistent but here are the profiling results: - HighlightsRanking.extractFeatures: 78.1% -> 54.5% - Highlight.<init>: 26.5% -> 14.5% - JSONObject.<init>: 11.4% -> rm'd - initFast*: (replaced JSONObject.<init> & friends) -> 4.2% With ^ the disclaimer in mind, runtime decreased from 12.6s to 5.3s (this is slower due to profiling). MozReview-Commit-ID: CTqAyDDmaJQ
fefc5d61b05107bd4aff588ab2c02e9976aa7d27: Bug 1369604: Replace features HashMap with indexing into an array. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 26 Jul 2017 17:16:14 -0700 - rev 420718
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1369604: Replace features HashMap with indexing into an array. r=liuche After the previous changeset, some numbers stood out: - HighlightsRanking.extractFeatures: 44.9% - HighlightCandidate.getFeatureValue: 19.4% - Collections.secondaryHash: 17.3% - HashMap.get: 11.7% My hypothesis was that our HighlightCandidate.features implementation was slow: it was mapping FeatureNames -> values in a HashMap but HashMap look-ups are slower than a direct memory access. I replaced the implementation with a direct access from an array - about as fast as we can get. This encouraged me to make some changes with the following benefits: - Rewrote HighlightsRanking.normalize to save iterations and allocations. - Rm code from HighlightsRanking.scoreEntries: we no longer need to iterate to construct the filtered items, we just index directly into the list - Rewrote HighlightsRanking.decay(), which I think is a little clearer now. - Saved a few iterator/object allocations inside inner loops in places. The tests pass and we have coverage for the normalize changes but not for scoreEntries. --- For perf, my changes affected multiple methods so the percentages are no longer reliable but I can verify absolute runtime changes. I ran three tests, the best of which showed an overall 33% runtime compared to the previous changeset and the other two profiles showed a 66% overall runtime. In particular, for the middle run, the changes for affected methods go from X microseconds to Y microseconds: - Features.get: 3,554,796 -> 322,145 - secondaryHash: 3,165,785 -> 35,253 - HighlightsRanking.normalize: 6,578,481 -> 1,734,078 - HighlightsRanking.scoreEntries: 3,017,272 -> 448,300 As far as I know, my changes should not have introduced any new inefficiencies to the code. MozReview-Commit-ID: 9THXe8KqBbB
2c33020e12d1ff0b279758bf938892bbf0097fec: Bug 1369604: Use HighlightCandidateCursorIndices to cache. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 24 Jul 2017 18:12:05 -0700 - rev 420717
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1369604: Use HighlightCandidateCursorIndices to cache. r=liuche This reduces the calls to `getColumnIndexOrThrow` to 9 (from 1.6k) and HighlightsRanking.extractFeatures goes from 77.1% inclusive CPU time -> 40.8%, 14.6k ms -> 7.1k ms. MozReview-Commit-ID: L6HqvBK5I4i
1c901b2b59712b57efdc77ac7510fb7d271fd0d6: Bug 1356271 - add a test to measure how many layout flushes it takes for a simple location bar search. r=florian
Mike Conley <mconley@mozilla.com> - Wed, 14 Jun 2017 15:45:33 -0400 - rev 420716
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1356271 - add a test to measure how many layout flushes it takes for a simple location bar search. r=florian MozReview-Commit-ID: GFDvSIn53Zh
79ac0025e9e861d70f8fab9bfe7aa9e166c5e091: Bug 1356271 - Make it so that it's easier to define repeating reflows for reflow tests. r=florian
Mike Conley <mconley@mozilla.com> - Mon, 10 Jul 2017 18:07:25 -0400 - rev 420715
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1356271 - Make it so that it's easier to define repeating reflows for reflow tests. r=florian MozReview-Commit-ID: 5ZL5RtItbiL
8536b787a5c7be6a453133e95a3de8e1bb86f6b9: Bug 1356271 - Clean up comment about reflow test helper now that we're using a better mechanism to dirty the frame tree. r=florian
Mike Conley <mconley@mozilla.com> - Thu, 13 Jul 2017 08:41:51 -0700 - rev 420714
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1356271 - Clean up comment about reflow test helper now that we're using a better mechanism to dirty the frame tree. r=florian MozReview-Commit-ID: 6YjhG0fOyjO
5f2af8ad61397dfaa61ede3cc1334d85f9be057d: Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs
Jared Wein <jwein@mozilla.com> - Mon, 31 Jul 2017 11:39:05 -0400 - rev 420713
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs This change in markup was necessary to implement bug 1352063. I have audited all other CSS to make sure other selectors looking for this icon still apply. This was the only one found that needed to be updated. MozReview-Commit-ID: 6O1iUUjJ0dh
0e724df2d505714cb63f3bd32e3b29f95f9c546e: Bug 1378820 - remove usage of sdk/clipboard in devtools clipboard helper;r=gl
Julian Descottes <jdescottes@mozilla.com> - Mon, 31 Jul 2017 14:02:37 +0200 - rev 420712
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1378820 - remove usage of sdk/clipboard in devtools clipboard helper;r=gl Remove previous helper APIs: - currentFlavors() - getData() The only consumer for both APIs was in devtools/cient/inspector/inspector. The logic was: - call currentFlavors() - if clipboard contains: - "text/unicode" or - "text/html" but not "image/png" - then call getData() But actually calling getData() without any argument means that unless "image/png" flavor is available, we will always use the "text/unicode" flavor. (see current code for sdk helper: http://searchfox.org/mozilla-central/rev/09c065976fd4f18d4ad764d7cb4bbc684bf56714/addon-sdk/source/lib/sdk/clipboard.js#204-209) If the text/unicode flavor was available at the same time as image/png, the code would have returned the image data, which is probably not what we expect in the context of the inspector. I think we should explicitly request for text/unicode. So this patch introduces a new getText() api in the devtools clipboard helper, which is a simplified version of the sdk get() helper. We could always extend it to also support text/html. MozReview-Commit-ID: E3JVj9boVKe
992636ea8646c921c5cb59c86b7287a6cd746143: Bug 1384654 - Horizontally flip the 'pin to overflow' animation during the fade out when in RTL. r=Gijs
Jared Wein <jwein@mozilla.com> - Mon, 31 Jul 2017 10:23:33 -0400 - rev 420711
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1384654 - Horizontally flip the 'pin to overflow' animation during the fade out when in RTL. r=Gijs MozReview-Commit-ID: 7OKoPYdPYNV
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip