3ba898f98afad26f0b12d5e63b6c273392376311: Bug 1539137 - Fix help link in browser languages dialog r=Gijs a=pascalc
Mark Striemer <mstriemer@mozilla.com> - Wed, 03 Apr 2019 23:01:29 +0000 - rev 522980
Push 11012 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:46:08 +0000
Bug 1539137 - Fix help link in browser languages dialog r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25998
dff20faae9f496959a1a42722e8f9a7e64f0abde: Bug 1541314 - Remove animation from choose what to sync svg r=mstange a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Wed, 03 Apr 2019 15:48:16 +0000 - rev 522979
Push 11012 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:46:08 +0000
Bug 1541314 - Remove animation from choose what to sync svg r=mstange a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25940
ad953d1d63f6d9fda6b4483a16632d8938a966f4: Bug 1541168: Remove remaining newChannelFromURI2 appearances. r=valentin a=pascalc
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 03 Apr 2019 10:45:48 +0000 - rev 522978
Push 11012 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:46:08 +0000
Bug 1541168: Remove remaining newChannelFromURI2 appearances. r=valentin a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25916
e0f62b77623697545dd2eb5c7e061a65a723f68e: Bug 1540944 - Get new group from the correct realm in SetProto. r=luke a=pascalc
Jan de Mooij <jdemooij@mozilla.com> - Tue, 02 Apr 2019 19:41:07 +0000 - rev 522977
Push 11012 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:46:08 +0000
Bug 1540944 - Get new group from the correct realm in SetProto. r=luke a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25803
2c01eafb7bb89195e76f6ea8daf817496b27ec44: Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster a=pascalc
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 03 Apr 2019 15:46:57 +0000 - rev 522976
Push 11012 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:46:08 +0000
Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster a=pascalc Some sites use `email`, `tel` and `tel-national` values for @autocomplete even when they are used as the username and 'username' would be more appropriate. We already allowed type=email / type=tel so allowing the autocomplete equivalents is reasonable. Differential Revision: https://phabricator.services.mozilla.com/D25883
7a7eda97a8f280c0cfec5a2968d6d81e2b87999c: Bug 1538218 - Correct REMOVE_DISTRIBUTION_DIR command. r=mhowell a=pascalc
Michael Kaply <mozilla@kaply.com> - Mon, 01 Apr 2019 23:57:14 +0000 - rev 522975
Push 11012 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:46:08 +0000
Bug 1538218 - Correct REMOVE_DISTRIBUTION_DIR command. r=mhowell a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25681
73fa8de4eb471cefb70727cf39b4638e86a2437e: Bug 1537117 - Update the search engine quick-switching functionality to work with an async SearchService API. r=florian a=pascalc
Mike de Boer <mdeboer@mozilla.com> - Tue, 02 Apr 2019 14:15:35 +0000 - rev 522974
Push 11012 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:46:08 +0000
Bug 1537117 - Update the search engine quick-switching functionality to work with an async SearchService API. r=florian a=pascalc I also updated the logic to properly cycle through the visible search engines list and added a unit test that was missing, somehow. Differential Revision: https://phabricator.services.mozilla.com/D25368
7a9bd3d0841234093d06a71516e1e22c4af0d905: Bug 1540231 - Stop dispatching a task to the TaskQueue when we are already in it. r=jya a=pascalc
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Apr 2019 22:05:48 +0000 - rev 522973
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1540231 - Stop dispatching a task to the TaskQueue when we are already in it. r=jya a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25576
ca218beefd316b68731d8e89c87bfae8c6f92483: Bug 1539408 Pass referrerInfo to gContextMenuContentData in non-remote r=Gijs a=pascalc
Thomas Nguyen <tnguyen@mozilla.com> - Tue, 02 Apr 2019 08:53:28 +0000 - rev 522972
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1539408 Pass referrerInfo to gContextMenuContentData in non-remote r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25419
11a26a76e494aaaaba3db0aec7b33a4e9dfff4bf: bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem) r=dao a=pascalc
Khyati Agarwal <f20160385@hyderabad.bits-pilani.ac.in> - Tue, 02 Apr 2019 10:26:04 +0000 - rev 522971
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem) r=dao a=pascalc Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem) Differential Revision: https://phabricator.services.mozilla.com/D25521
4b57a43c92b979133a21fd1a3b27989e9c048119: Bug 1539208 - P2 - Use RandomNum while failing to get a random number from RandomGenerator a=pascalc
shindli <shindli@mozilla.com> - Mon, 01 Apr 2019 17:34:38 +0300 - rev 522970
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1539208 - P2 - Use RandomNum while failing to get a random number from RandomGenerator a=pascalc Reviewers: asuth, baku Reviewed By: baku Subscribers: reviewbot Bug #: 1539208 Differential Revision: https://phabricator.services.mozilla.com/D25104
6168e6cc5761ddbf95cc5b7466a339c432a1ba07: Bug 1539208 - P1 - Return an error when the Reponse object is null'd a=pascalc
shindli <shindli@mozilla.com> - Mon, 01 Apr 2019 17:35:46 +0300 - rev 522969
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1539208 - P1 - Return an error when the Reponse object is null'd a=pascalc Reviewers: mayhemer, baku Reviewed By: mayhemer Bug #: 1539208 Differential Revision: https://phabricator.services.mozilla.com/D25228
78f43d6cbd56ffeff48ddeefb73f0ce7bf2010da: Bug 1533989 - Make InputEvent.data and InputEvent.dataTransfer not expose clipboard data if user disables clipboard events r=smaug a=pascalc
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 29 Mar 2019 16:08:11 +0000 - rev 522968
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1533989 - Make InputEvent.data and InputEvent.dataTransfer not expose clipboard data if user disables clipboard events r=smaug a=pascalc If user disables clipboard events, it means that they don't want to expose clipboard data to web apps even if web apps cannot handle "paste" operation. Therefore, they must not want to leak clipboard data with `InputEvent.data` and `InputEvent.dataTransfer`. This patch makes `InputEvent::GetData()` and `InputEvent::GetDataTransfer()` returns empty string or new `DataTransfer` object which has only empty string if: - They are called by content JS. - The event is a trusted event. - `inputType` value is `insertFromPaste` or `insertFromPasteAsQuotation`. The reason why we don't return null for both is, Input Events spec declares `data` or `dataTransfer` shouldn't be null in the `inputType` values. And the reason why we don't return empty `DataTransfer` is, web apps may expect at least one data is stored in non-null `dataTransfer` value. Differential Revision: https://phabricator.services.mozilla.com/D25350
81e863ea76d5add70e24fc5134498cc21dd95eb2: Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak a=pascalc
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Sat, 30 Mar 2019 04:20:20 +0000 - rev 522967
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak a=pascalc Normally autocomplete results are cached based upon the search string but to get the desired behaviour we want two different sets of results for the same search string depending on how the autocomplete search was started: a) Via automatically focusing a password field. b) Every other method of starting an autocomplete search. In order to not have cached results used, the result code for case (a) [an empty result] will be `RESULT_FAILURE` and I've updated the autocomplete code to not re-use an error result. In the coming months we may be rewriting our content autocomplete code but that would be too risky to uplift to 67 so for now I'm tracking when satchel automatically opens the popup upon focus and then using that state in the autocomplete result creation code to know whether to include the footer. Differential Revision: https://phabricator.services.mozilla.com/D25173
f64e6108bdfc6462983667170768450c320efaf7: Bug 1479145 - Give RGB textures a 32-byte aligned stride on macOS in order to improve texture upload efficiency on certain drivers. r=mattwoodrow a=pascalc
Markus Stange <mstange@themasta.com> - Fri, 29 Mar 2019 20:11:12 +0000 - rev 522966
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1479145 - Give RGB textures a 32-byte aligned stride on macOS in order to improve texture upload efficiency on certain drivers. r=mattwoodrow a=pascalc In particular, it looks like this alignment is required by the Intel driver on macOS if you want to avoid CPU copies. It was already known that the efficiency gains from client storage only materialize if you follow certain restrictions: - The textures need to use the TEXTURE_RECTANGLE_ARB texture target. - The textures' format, internalFormat and type need to be chosen from a small list of supported configurations. Unsupported configurations will trigger format conversions on the CPU. - The GL_TEXTURE_STORAGE_HINT_APPLE may need to be set to shared or cached. - glTextureRangeAPPLE may or may not make a difference. It now appears that the stride alignment is another requirement: When uploading textures which otherwise comply with the above requirements, the Intel driver will still make copies using the CPU if the texture's stride is not 32-byte aligned. These CPU copies are reflected in a high CPU usage (as observed in Activity Monitor) and they show up in profiles as time spent inside _platform_memmove under glrUpdateTexture. However, when uploading 32-byte stride aligned textures which comply with the above requirements, this CPU usage goes away. There might still be hardware copies behind the scenes, but they no longer take up CPU time. Differential Revision: https://phabricator.services.mozilla.com/D25316
233aa5cf03be6c45ed388f2a7b3b73563de06e2c: Bug 1479145 - Handle arbitrary strides for WebGL-to-SharedSurface readback on platforms that support it. r=jgilbert a=pascalc
Markus Stange <mstange@themasta.com> - Fri, 29 Mar 2019 20:18:53 +0000 - rev 522965
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1479145 - Handle arbitrary strides for WebGL-to-SharedSurface readback on platforms that support it. r=jgilbert a=pascalc The only platforms that do not support GL_PACK_ROW_LENGTH are platforms with GLES 2. So on those platforms, trying to read back into buffers whose stride is not width * 4 will assert. That's fine because we usually don't encounter buffers with such large strides on GLES 2 platforms. The only platform that really needs to handle the large strides is macOS, and it always supports GL_PACK_ROW_LENGTH. On macOS, we often run into large strides on surfaces that we intend to upload as textures at some point, because large stride alignments are required for efficient upload performance on some drivers. Bug 1540209 tracks fixing the general case. Differential Revision: https://phabricator.services.mozilla.com/D25464
21acdae6bafe5ad41736fec5e14bb787622acb5d: Bug 1539541 - Enable FIDO U2F API, and permit registrations for Google Accounts r=keeler,qdot a=pascalc
J.C. Jones <jjones@mozilla.com> - Fri, 29 Mar 2019 17:16:13 +0000 - rev 522964
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1539541 - Enable FIDO U2F API, and permit registrations for Google Accounts r=keeler,qdot a=pascalc Per the thread "Intent-to-Ship: Backward-Compatibility FIDO U2F support for Google Accounts" on dev-platform [0], this bug is to: 1. Enable the security.webauth.u2f by default, to ride the trains 2. Remove the aOp == U2FOperation::Sign check from EvaluateAppID in WebAuthnUtil.cpp, permitting the Google override to work for Register as well as Sign. This would enable Firefox users to use FIDO U2F API on most all sites, subject to the algorithm limitations discussed in the section "Thorny issues in enabling our FIDO U2F API implementation" of that post. [0] https://groups.google.com/d/msg/mozilla.dev.platform/q5cj38hGTEA/lC834665BQAJ Differential Revision: https://phabricator.services.mozilla.com/D25241
985158cfb6950e416e0d4664e1aa9aad83c923ab: Bug 1539172 - Make nsContentUtils::DispatchInputEvent() notify content of valid state change of input element r=smaug a=pascalc
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 28 Mar 2019 23:40:18 +0000 - rev 522963
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1539172 - Make nsContentUtils::DispatchInputEvent() notify content of valid state change of input element r=smaug a=pascalc When `nsContentUtils::DispatchInputEvent()` dispatches `input` event, the editor's value was changed by somebody. In this case, it needs to update the valid state **and** notify to update the style. (Note that I'm not sure whether this is right approach.) Differential Revision: https://phabricator.services.mozilla.com/D25029
3dc7b1a572313386a459b174e7335847e3c1dbb2: Bug 1532730 - Update engines on reload. r=mikedeboer a=pascalc
Dale Harvey <dale@arandomurl.com> - Thu, 28 Mar 2019 16:32:41 +0000 - rev 522962
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1532730 - Update engines on reload. r=mikedeboer a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24192
864e16abd2f73a5a0d0ef7a887a3a90e0ee22a37: Bug 1539905 Cache yaml loading with copy of memoized values r=mtabara a=release
Simon Fraser <sfraser@mozilla.com> - Fri, 05 Apr 2019 20:36:37 +0300 - rev 522961
Push 11010 by mtabara@mozilla.com at Fri, 05 Apr 2019 17:44:22 +0000
Bug 1539905 Cache yaml loading with copy of memoized values r=mtabara a=release
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip