396203b98e350e0e52111423a8e04080c0ea60ef: Bug 1411156 - Set MOZ_DEBUG globally as both a CONFIG and a #define. r=mshal
Mike Hommey <mh+mozilla@glandium.org> - Tue, 24 Oct 2017 14:07:37 +0900 - rev 438785
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1411156 - Set MOZ_DEBUG globally as both a CONFIG and a #define. r=mshal Bug 1365460 introduced code paths behind MOZ_DEBUG #ifdefs, but MOZ_DEBUG is never defined, while it is available in CONFIG in moz.builds. This is kind of a confusing situation, but the fact that we've been able to avoid those problems for so long would tend to put the blame on mozjemalloc, and fixes should go there. Except that bug 1261161 explains that the only existing alternative (the DEBUG #define), as used in MFBT, is not working for spidermonkey, so it actually makes sense to converge to MOZ_DEBUG rather than DEBUG. So start defining MOZ_DEBUG globally, fixing the mozjemalloc issues of not having the debug code enabled. Bug 1261161 can then take care of changing the DEBUG #ifdefs.
43695cf06e96ffae6c50321371fa37c43f5ca3b4: Bug 1411201 - Don't disable inlining in mozjemalloc on debug builds. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 24 Oct 2017 18:42:24 +0900 - rev 438784
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1411201 - Don't disable inlining in mozjemalloc on debug builds. r=njn The way inlining is disabled in mozjemalloc is via a #define of "inline" to nothing, which is a dubious way to do that. This makes the compiler trigger warnings we -Werror on for some static functions. While there are such functions in mozjemalloc.cpp that could be fixed by wrapping them in the right #ifdefs, there are also others coming from headers, and it's not something that can be fixed in a satisfactory way. The right way to disable inlining is to pass the right compiler flags for that. But inlining is the least of the problems to debug optimized C++ code, so it feels like if debugging requires some optimization tweaking, it should be done manually with compile flags when needed, instead of fiddling with #defines to remove keywords.
b06e3211aae4c42509d4e897f2d91cd06ede314f: servo: Merge #19005 - style: Move animation-name and animation-iteration-count outside of mako (from emilio:less-mako-more-joy); r=jdm
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Oct 2017 15:29:21 -0500 - rev 438783
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #19005 - style: Move animation-name and animation-iteration-count outside of mako (from emilio:less-mako-more-joy); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: f9f71c7ed105dfb415c38bf6826942cb757b1bcc
626031d7d6fee7fc93790c3fafd96fb2f7ac0b8d: Bug 1410165 - Make the test harness properly listen to crash events when running a test more than once; r=mconley
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 20 Oct 2017 15:21:46 +0200 - rev 438782
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1410165 - Make the test harness properly listen to crash events when running a test more than once; r=mconley MozReview-Commit-ID: C3PDtOfaz0v
1593dfc4cf04af2d32060262a5a0e77ff5b2688d: Bug 1405359 - Add some logging code in ScrollingLayersHelper. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 24 Oct 2017 16:15:00 -0400 - rev 438781
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405359 - Add some logging code in ScrollingLayersHelper. r=jrmuizel MozReview-Commit-ID: 3OLNPHlkO9M
988d6a397ea8eb440e7fd521f818202124de8417: Bug 1405359 - Avoid pushing and popping identical clip stacks for adjacent display items. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 24 Oct 2017 16:15:00 -0400 - rev 438780
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405359 - Avoid pushing and popping identical clip stacks for adjacent display items. r=jrmuizel Instead of unconditionally pushing and popping clips per display item, this patch changes things so that for each recursive display list, we create an ItemClips struct. We push this onto the stack when we enter the display list, and pop it off at the end. For each display item, we check to see if the clips would actually change compared to the previous display item, and only do the pop/repush in that case. MozReview-Commit-ID: GadIp2J8TrA
154c415885b818ca3de8f21c44639994bddeab5d: Bug 1405359 - Make ScrollingLayersHelper a more stateful class. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 24 Oct 2017 16:15:00 -0400 - rev 438779
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405359 - Make ScrollingLayersHelper a more stateful class. r=jrmuizel This makes ScrollingLayersHelper a non-RAII type class, and instead adds methods to notify it of when we start processing a new transaction or a new display item within the transaction. This patch has no functional changes, it's non-obvious refactoring. MozReview-Commit-ID: 3yq9sPiHMge
f6ce05f8e699674a01d0df99a6a36c73191ba273: Bug 1405359 - Replace the mPushed* variables with a more encapsulated struct. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 24 Oct 2017 16:15:00 -0400 - rev 438778
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405359 - Replace the mPushed* variables with a more encapsulated struct. r=jrmuizel Storing the per-item clip state in a struct like this will allow us to easily compare the desired clip state across items, so we can avoid doing unnecessary work when going from one item to the next. This patch has no functional changes, it's just refactoring. MozReview-Commit-ID: 49B6hmsWZ4V
cb49e178390c45386141460e3ca2901cc3dc6346: Bug 1405359 - Stop passing around the clip id cache in all the functions. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 24 Oct 2017 16:14:59 -0400 - rev 438777
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405359 - Stop passing around the clip id cache in all the functions. r=jrmuizel Instead just keep a ref to it as a member variable. No functional change. MozReview-Commit-ID: 5fccUlSifsA
c46942fe16787f117609382f233a31b9f0773da9: Bug 1411374 Do not redefine PATH_MAX if it is already defined r=njn
Tom Ritter <tom@mozilla.com> - Tue, 24 Oct 2017 00:36:58 -0500 - rev 438776
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1411374 Do not redefine PATH_MAX if it is already defined r=njn MozReview-Commit-ID: trabOdGWYD
1b371d5bea7b34fc6eb076d08d87c5659999de0c: Bug 1411255 - Fixed unnecessary mut warning; r=valentin
Alex Gaynor <agaynor@mozilla.com> - Tue, 24 Oct 2017 09:42:28 -0400 - rev 438775
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1411255 - Fixed unnecessary mut warning; r=valentin MozReview-Commit-ID: 9MDk0LlA6uR
ba4a39241953d5079dba48dddac6093f161745aa: Bug 1386018 - Tell users that the default search engine was set by an extension r=bsilverberg,jaws
Mark Striemer <mstriemer@mozilla.com> - Wed, 18 Oct 2017 14:54:54 -0500 - rev 438774
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1386018 - Tell users that the default search engine was set by an extension r=bsilverberg,jaws MozReview-Commit-ID: A7uJ2lN0cLF
6780969991ed697b03b7a8b2cc80d46fc41d9828: Bug 1372958 Stack alignment on Windows is 4 bytes, not 16 r=luke
Tom Ritter <tom@mozilla.com> - Fri, 06 Oct 2017 16:43:07 -0500 - rev 438773
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1372958 Stack alignment on Windows is 4 bytes, not 16 r=luke MozReview-Commit-ID: sLOruY3UJE
4f223f11a08ff2c3c6cefa68722a10113c04317c: Bug 1334411 - Remove the UI for indexedDB in Permissions section of PageInfo and the identity block. r=johannh
Prathiksha <prathikshaprasadsuman@gmail.com> - Wed, 04 Oct 2017 19:59:19 +0530 - rev 438772
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1334411 - Remove the UI for indexedDB in Permissions section of PageInfo and the identity block. r=johannh MozReview-Commit-ID: 3OcrBcRPSgZ
c0030006cd60597af474e8d342593d8520a66939: Bug 1404733 - Handle non-utf8 better in wpt logging, r=maja_zf
James Graham <james@hoppipolla.co.uk> - Tue, 24 Oct 2017 18:30:05 +0100 - rev 438771
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1404733 - Handle non-utf8 better in wpt logging, r=maja_zf MozReview-Commit-ID: GMofBbKUtt0
19c04f7b934fcf918c5de93dca23f522b32a6a08: Bug 1411363 - Update Cargo.lock files for Rust 1.22. r=froydnj
Ralph Giles <giles@mozilla.com> - Tue, 24 Oct 2017 10:00:24 -0700 - rev 438770
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1411363 - Update Cargo.lock files for Rust 1.22. r=froydnj Cargo 0.23.0-beta, included with Rust 1.22.0-beta.2, wants to move the top-level package description out of the [root] section of Cargo.lock and into a parallel [[package]] section. Accept this update by temporarily running the build without passing --frozen and committing the result. This is accepted by the cargo versions included in the current and previous stable rust releases, so it will work with all supported toolchains. MozReview-Commit-ID: 1hMykhTknHi
7935635f721f66fa9d4533f9f7008c701211283b: Bug 1409542 part 2 - telemetry on why a resource marked prefetchable is not prefetched. r=francois,valentin
Nicholas Hurley <hurley@mozilla.com> - Fri, 20 Oct 2017 12:58:30 -0700 - rev 438769
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1409542 part 2 - telemetry on why a resource marked prefetchable is not prefetched. r=francois,valentin MozReview-Commit-ID: AFJnbTjU5Ju
a120a00b3f2e559418668798ed9f0f895ab19a6f: Bug 1409542 part 1 - telemetry on why a resource is marked prefetchable or not. r=francois,valentin
Nicholas Hurley <hurley@mozilla.com> - Tue, 17 Oct 2017 14:46:56 -0700 - rev 438768
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1409542 part 1 - telemetry on why a resource is marked prefetchable or not. r=francois,valentin MozReview-Commit-ID: IdSyFv8RSbY
e036a5afa8548d84ca07871f2b3c411d8dac8ef6: Bug 1409446 - Remove old code that is now unused. r=mstange
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 24 Oct 2017 15:46:00 -0400 - rev 438767
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1409446 - Remove old code that is now unused. r=mstange MozReview-Commit-ID: KEtcbIGTrn3
53894a33da8c5265e158c1b8871c1ed37ee8531c: Bug 1409446 - Switch over to the new code. r=mstange
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 24 Oct 2017 15:46:00 -0400 - rev 438766
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1409446 - Switch over to the new code. r=mstange One of the sticky-pos tests was only passing because of two wrongs that cancelled each other out in the old code. Specifically, instead of defining a nested clip with the sticky clip as an ancestor, the clip was being defined with the root ASR as an ancestor. Both resulted in the nested clip not scrolling with the actual scrolling scrollframe and so the test was passing. The new code changes things so that the nested clip is defined with the actual scrolling scrollframe as the ancestor, causing the reftest to fail. Fixing the clip ancestry is not hard but it reveals other problems so so I'm deferring that to a follow-up bug. MozReview-Commit-ID: DldAKi1AP4l
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip