395f1f1dfde1eefb0b6bf0a645db80454be219ba: Bug 1705102 - Make browser_984455_bookmarks_items_reparenting.js work with native context menus. r=mac-reviewers,bradwerth,mstange
Harry Twyford <htwyford@mozilla.com> - Wed, 14 Apr 2021 19:36:12 +0000 - rev 643552
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1705102 - Make browser_984455_bookmarks_items_reparenting.js work with native context menus. r=mac-reviewers,bradwerth,mstange Requesting review from mac-reviewers because this is just a boilerplate change. Differential Revision: https://phabricator.services.mozilla.com/D112039
472077cb1e3827a16c4939ec5cb2dc207629b409: Bug 1699844 - Make promiseDocumentFlushed handle presshell destruction correctly. r=smaug,botond
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Apr 2021 19:34:23 +0000 - rev 643551
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699844 - Make promiseDocumentFlushed handle presshell destruction correctly. r=smaug,botond By resolving the relevant promises, instead of crashing (and if we didn't crash we'd leave the window registered as a refresh driver observer, which would be bad). I wanted to reject them, since that's what we do when the page has no pres shell, but that'd make this test fail: https://searchfox.org/mozilla-central/rev/d8194cbbeaec11962ed67f83aea9984bf38f7c63/dom/base/test/browser_promiseDocumentFlushed.js#165-186 For this, we modify the OneShotPostRefreshObserver API to be more generic (and rename it OneShotManagedRefreshObserver). We fix APZ's usage of this API, which was doing something extremely weird (returning a refcounted object in a UniquePtr). This seems like an artifact from recent OneShotPostRefreshObserver cleanup. Differential Revision: https://phabricator.services.mozilla.com/D111851
a200fd30eccfd75faa88c5542722ced311dde5fd: Bug 1705173 - Fix memory leaks with gfx::MemStream. r=lsalzman
Andrew Osmond <aosmond@mozilla.com> - Wed, 14 Apr 2021 19:30:53 +0000 - rev 643550
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1705173 - Fix memory leaks with gfx::MemStream. r=lsalzman Differential Revision: https://phabricator.services.mozilla.com/D112071
ca2f82528ff24cff0bad8187786ad1a641f88e36: Backed out changeset 00d6baae6487 (bug 1702285) for Browser-chrome in browser/base/content/test/performance/browser_tabopen.js. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Wed, 14 Apr 2021 23:30:14 +0300 - rev 643549
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Backed out changeset 00d6baae6487 (bug 1702285) for Browser-chrome in browser/base/content/test/performance/browser_tabopen.js. CLOSED TREE
eb837f72d2efa15712e1238e3623b8c115856d23: Backed out 3 changesets (bug 1700963) for Browser-chrome failures in docshell/test/browser/browser_bug1309900_crossProcessHistoryNavigation.js. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Wed, 14 Apr 2021 23:26:05 +0300 - rev 643548
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Backed out 3 changesets (bug 1700963) for Browser-chrome failures in docshell/test/browser/browser_bug1309900_crossProcessHistoryNavigation.js. CLOSED TREE Backed out changeset cda35e554327 (bug 1700963) Backed out changeset fbafd75b06d3 (bug 1700963) Backed out changeset 8b922e4f612b (bug 1700963)
3bb2931efce168ec730dd6e622104fbd1ddd136b: Bug 1703793 - Some cleanup of nsHttpChannel r=necko-reviewers,kershaw
Dragana Damjanovic <dd.mozilla@gmail.com> - Wed, 14 Apr 2021 19:25:59 +0000 - rev 643547
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703793 - Some cleanup of nsHttpChannel r=necko-reviewers,kershaw Differential Revision: https://phabricator.services.mozilla.com/D111243
00d6baae64871a5cca9c86e55b3607a821b468e0: Bug 1702285 - Update tabstrip icons for Proton. r=desktop-theme-reviewers,dao
Jared Wein <jwein@mozilla.com> - Wed, 14 Apr 2021 19:17:03 +0000 - rev 643546
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1702285 - Update tabstrip icons for Proton. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D111009
ee4b9934e0741ace55a20a410a4f5aee0df5d2b3: Bug 1699844 - Add an escape hatch for the refcounted inside lambda checker. r=andi
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Apr 2021 19:12:02 +0000 - rev 643545
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699844 - Add an escape hatch for the refcounted inside lambda checker. r=andi Allow using the MOZ_KnownLive function to get around it. Use case is the following: I have an std::function member variable, and I want that member to be able to capture `this`. Using a strong reference creates a cycle and thus would leak. I know `this` to always outlive the member, so it is fine to use a weak capture there. Differential Revision: https://phabricator.services.mozilla.com/D111850
5fe42b0b50c6596c5e854c2fb169061b2c2bb462: Bug 1696039 - Align texture upload stride to multiples of 128 bytes on Adreno 3xx r=kvark
Jamie Nicol <jnicol@mozilla.com> - Wed, 14 Apr 2021 19:03:01 +0000 - rev 643544
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1696039 - Align texture upload stride to multiples of 128 bytes on Adreno 3xx r=kvark On Adreno 3xx we see intermittently corrupted or missing glyphs due to texture uploads failing. This has only started occuring since glyphs were switched to using R8 format textures, from RGBA8. Due to performance reasons on other Adreno devices, we currently ensure texture data has a stride aligned to 64 pixels. So the effect of switching texture format is that the alignment switched from 256 bytes to 64 bytes. It appears that PBO texture uploads must be performed with an alignment of 128 bytes on Adreno 3xx, otherwise this corruption may occur. Additionally, the 64 pixel requirement to hit the fast path does not seem to apply to Adreno 3xx. Therefore this patch sets the requirement to 128 bytes on Adreno 3xx, and leaves it as 64 pixels on other Adreno devices. It also renames optimal_pbo_stride to required_pbo_stride, to better reflect the fact that this is now sometimes required for correctness reasons, not just performance. Differential Revision: https://phabricator.services.mozilla.com/D112058
cda35e5543274ffa11e32e79937c36f9842566d7: Bug 1700963 - Stop relying on the "SessionStore:addSHistoryListener" message, r=nika
Kashav Madan <kshvmdn@gmail.com> - Wed, 14 Apr 2021 18:53:06 +0000 - rev 643543
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700963 - Stop relying on the "SessionStore:addSHistoryListener" message, r=nika We now create the listener after receiving a "browsing-context-did-set-embedder" and destroy it after receiving "browsing-context-discarded". Differential Revision: https://phabricator.services.mozilla.com/D110337
fbafd75b06d3027911918c702f2fa0946a519580: Bug 1700963 - Add a "browsing-context-did-set-embedder" observer notification, r=nika
Kashav Madan <kshvmdn@gmail.com> - Wed, 14 Apr 2021 18:53:06 +0000 - rev 643542
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700963 - Add a "browsing-context-did-set-embedder" observer notification, r=nika Depends on D110336 Differential Revision: https://phabricator.services.mozilla.com/D111709
8b922e4f612bc445c891e9c3d8ab973eef5d4d34: Bug 1700963 - Clean up SessionStore's SHistoryListener, r=nika
Kashav Madan <kshvmdn@gmail.com> - Wed, 14 Apr 2021 18:53:05 +0000 - rev 643541
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700963 - Clean up SessionStore's SHistoryListener, r=nika This cleans up the SHistoryListener class and does a few things: 1. Gets rid of the listener's `_sHistoryChanges` property, which is possible because _sHistoryChanges == false <-> _fromIdx == kNoIndex. 2. Simplifies the code that interacts with SHistoryListener in UpdateSessionStoreFromTablistener, and attempts to make that function a little more readable. 3. Ensures we're only doing the SessionHistory bit of UpdateSessionStoreFromTablistener for toplevel frames. Differential Revision: https://phabricator.services.mozilla.com/D110336
bbd7d0926b9038b224cffd6dc15cba2fc17ca69a: Bug 1705154 - fix typo in vpn banner content r=prathiksha,flod,fluent-reviewers
Luke Crouch <lcrouch@mozilla.com> - Wed, 14 Apr 2021 18:52:48 +0000 - rev 643540
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1705154 - fix typo in vpn banner content r=prathiksha,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D112067
d5121e6b3b609bba225b0806d9e6752af5fd93f3: Bug 1635068: fix removed dead pref extensions.screenshots.upload-disabled and unused function isUploadDisabled() r=emalysz
Falguni Islam <falgunimst95@gmail.com> - Wed, 14 Apr 2021 18:49:08 +0000 - rev 643539
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1635068: fix removed dead pref extensions.screenshots.upload-disabled and unused function isUploadDisabled() r=emalysz Differential Revision: https://phabricator.services.mozilla.com/D112010
3c2c9b13b8c2cd30a05a46e80fc13e947b5bd90e: Bug 1704818 - Enable webrender on PowerVR Rogue devices. r=aosmond
Jamie Nicol <jnicol@mozilla.com> - Wed, 14 Apr 2021 18:42:37 +0000 - rev 643538
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704818 - Enable webrender on PowerVR Rogue devices. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D111843
5045813af7d172ed5b9367b5a877528c3545c5cf: Bug 1704783 - Disable texture swizzling support on PowerVR Rogue devices. r=kvark
Jamie Nicol <jnicol@mozilla.com> - Wed, 14 Apr 2021 18:42:36 +0000 - rev 643537
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704783 - Disable texture swizzling support on PowerVR Rogue devices. r=kvark Running webrender on PowerVR Rogue devices results in some images being rendered with swapped R and B channels. This is because we use texture swizzling for images in the shared texture cache, and presumably the driver has a buggy implementation. This patch disables texture swizzling on all PowerVR Rogue devices as a precaution. It also ensures that we always use BGRA format textures in cases where texture swizzling is unsupported, otherwise we encounter GL errors when attempting to upload BGRA data to RGBA format textures, as GLES does not support format conversion during upload. Furthermore, we make it so that using RGBA+glTexStorage+swizzling is preferred to BGRA+glTexImage in cases where swizzling is actually supported, as we generally want to prefer glTexStorage to glTexImage. Lastly, in cases where neither BGRA or swizzling are supported, rather than attempting to upload BGRA data to RGBA textures (which will result in a GL error) we pretend the BGRA data is RGBA. This will result in the channels being swapped when rendering, but that is preferable to the alternative of images not being uploaded at all. This configuration shouldn't actually exist in the wild anyway. Differential Revision: https://phabricator.services.mozilla.com/D111840
215ec7244a6f5ef2797d639b1e770825f7a8c9cb: Bug 1703318 - Part 4: Avoid overlapping background update tasks accessing Glean storage concurrently. r=chutten,bytesized,application-update-reviewers
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Apr 2021 18:24:28 +0000 - rev 643536
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703318 - Part 4: Avoid overlapping background update tasks accessing Glean storage concurrently. r=chutten,bytesized,application-update-reviewers Differential Revision: https://phabricator.services.mozilla.com/D111881
2d8b8f11b599bcd72cbdf1fe739da9962d9bd927: Bug 1703318 - Part 3: Add Marionette "background-update" ping test. r=chutten,bytesized
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Apr 2021 18:24:28 +0000 - rev 643535
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703318 - Part 3: Add Marionette "background-update" ping test. r=chutten,bytesized This is subtle but not so subtle that it can't be understood. The major issue we might see is that the background update tasks all use the same `UpdRootD` and `app.update.background.enabled` state, essentially preventing concurrent Marionette tests. In the future we may be able to do better. Differential Revision: https://phabricator.services.mozilla.com/D111349
c39df4a8d9adffa53f357dcf5e34504e00ba91c1: Bug 1703318 - Part 2: Add update environment to "background-update" Glean ping. r=chutten,application-update-reviewers,bytesized
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Apr 2021 18:24:27 +0000 - rev 643534
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703318 - Part 2: Add update environment to "background-update" Glean ping. r=chutten,application-update-reviewers,bytesized Differential Revision: https://phabricator.services.mozilla.com/D111348
4a9b2fd76c6e2be1df17da8e6b00c58a2062e04d: Bug 1703318 - Part 1: Add "background-update" Glean ping. r=chutten,bytesized
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Apr 2021 18:24:27 +0000 - rev 643533
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703318 - Part 1: Add "background-update" Glean ping. r=chutten,bytesized This does a few things: 1) It registers a few basic health metrics and a new Glean custom ping. 2) It arranges to mirror the default profile's `datareporting.healthreport.uploadEnabled` preference to the temporary background task profile. This requires not setting that pref for every background task. This is not risky because the Telemetry mechanism is completely disabled in background tasks at this time. 3) It initializes Firefox-on-Glean. 4) It uses the Glean APIs to submit the Glean custom ping. Differential Revision: https://phabricator.services.mozilla.com/D111022
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip