391dbe0ceb290de3c1a6989aab62e602e55f176c: Backed out 5 changesets (bug 1711663) for causing build bustages on FileManager. CLOSED TREE
Iulian Moraru <imoraru@mozilla.com> - Tue, 01 Jun 2021 02:21:02 +0300 - rev 649893
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Backed out 5 changesets (bug 1711663) for causing build bustages on FileManager. CLOSED TREE Backed out changeset 9f3260aaab11 (bug 1711663) Backed out changeset adb6539a1e6f (bug 1711663) Backed out changeset 2b58a824285d (bug 1711663) Backed out changeset 28e04756a73d (bug 1711663) Backed out changeset 8a36c84e9269 (bug 1711663)
2746dcf5094b8ba4d84f8ca75e6d706d8c153fd7: Bug 1713378: Use a more accurate stack top pointer when registering the Android UI thread with the profiler; r=gerald,geckoview-reviewers,owlish
Aaron Klotz <aklotz@mozilla.com> - Mon, 31 May 2021 22:44:19 +0000 - rev 649892
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1713378: Use a more accurate stack top pointer when registering the Android UI thread with the profiler; r=gerald,geckoview-reviewers,owlish We were previously registering the Android UI thread with the profiler using the `PROFILER_REGISTER_THREAD` macro. This macro uses the address of a local variable as an estimate for the top of the thread's call stack. The profiler's sampling thread does not walk the stack any further past this value. This works fine most of the time, as it's usually one of the first things that we do when running a new thread. On the other hand, the Android UI thread already has a bunch of stuff on the stack (including VM frames) by the time we go to set this, plus we have two or three of our own calls already on the stack as well. Using the current stack frame as an estimate for the top of the stack results in the profiler omitting numerous frames from the Android UI thread because it mistakenly believes that it needs to stop walking the stack sooner than it actually needs to! Instead of using the macro, this patch uses pthreads to resolve the real stack top and supplies that pointer to the profiler instead. Differential Revision: https://phabricator.services.mozilla.com/D116284
4d9de2cde07d2854da07e3978fdbc38ca3573185: Bug 1713489 - Record telemetry for how long we spend waiting on the main thread to process image preload network steps. r=bas,dragana,necko-reviewers
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 31 May 2021 22:44:18 +0000 - rev 649891
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1713489 - Record telemetry for how long we spend waiting on the main thread to process image preload network steps. r=bas,dragana,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D116318
219a530441fd21d9fab2056163f96c09786d7a40: Bug 1540037 - part 30: Get rid of `TextEditor::SharedOutputString()` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 31 May 2021 22:34:00 +0000 - rev 649890
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1540037 - part 30: Get rid of `TextEditor::SharedOutputString()` r=m_kato It's now used only by `HTMLEditor::Rewrap()` and it does simple thing with `TextEditor::ComputeValueInternal()`. So, we can make `Rewrap()` directly do it instead. Differential Revision: https://phabricator.services.mozilla.com/D116347
a2dc0b41afced41ea6ddebc34c69dbdd4ae3e5e7: Bug 1713178 - Make `black` linter setup avoid updating the virtualenv if it's installed. r=ahal
Nick Alexander <nalexander@mozilla.com> - Mon, 31 May 2021 21:44:05 +0000 - rev 649889
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1713178 - Make `black` linter setup avoid updating the virtualenv if it's installed. r=ahal This could be easily generalized to avoid the updating the virtualenv more generally, but I think this functionality should be in the `virtualenv_manager` -- something like `install_pip_binary(...)` -- so I've just done the most impactful example here. Differential Revision: https://phabricator.services.mozilla.com/D116148
3a9cf4ad9344116ba51ef8d1d7937a9176747090: Bug 1713485 - Remove unused migrationPercent pref. r=botond
Kartikaya Gupta <kats@pancake.staktrace.com> - Mon, 31 May 2021 21:36:36 +0000 - rev 649888
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1713485 - Remove unused migrationPercent pref. r=botond With the migration completed, we don't need to keep this pref around anymore. The profile migration code used to set the pref value to 0 but since FF 86 the value of the pref didn't matter as the code would always clamp it to 100. So for consistency we eliminate that setting of the pref as well. Depends on D116322 Differential Revision: https://phabricator.services.mozilla.com/D116323
86af980c571026ed06183569d56d3f1153366734: Bug 1713485 - Remove code for completed migration. r=hiro
Kartikaya Gupta <kats@pancake.staktrace.com> - Mon, 31 May 2021 21:36:36 +0000 - rev 649887
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1713485 - Remove code for completed migration. r=hiro This is essentially dead-code removal. Since the GetNormalizedAppVersion() now always returns 86, the value of the `migration` variable in GetMouseWheelAnimationDurations() is always 100. And thus the function always returns the unmodified minMS and maxMS values stored in the prefs. We can therefore remove the function entirely and just use the pref values directly in the callers. Differential Revision: https://phabricator.services.mozilla.com/D116322
b7e10a54750ff3d079698e4f9f97a959ab76ed65: Bug 1694847 - Remove expired overshoot detector telemetry probe. r=botond
Kartikaya Gupta <kats@pancake.staktrace.com> - Mon, 31 May 2021 21:36:36 +0000 - rev 649886
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1694847 - Remove expired overshoot detector telemetry probe. r=botond Depends on D116320 Differential Revision: https://phabricator.services.mozilla.com/D116321
9211e7bd2637c31cf91d38ee78aec0821a13f73d: Bug 1694847 - Remove the expired SCROLL_INPUT_METHODS telemetry probe. r=botond
Kartikaya Gupta <kats@pancake.staktrace.com> - Mon, 31 May 2021 21:36:35 +0000 - rev 649885
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1694847 - Remove the expired SCROLL_INPUT_METHODS telemetry probe. r=botond Differential Revision: https://phabricator.services.mozilla.com/D116320
3669a66573ad1a78b944a05b5c40a8cc0b12035e: Bug 1713674 - Remove unsupported bookmarks.import/export definition r=rpl
Rob Wu <rob@robwu.nl> - Mon, 31 May 2021 21:21:19 +0000 - rev 649884
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1713674 - Remove unsupported bookmarks.import/export definition r=rpl Differential Revision: https://phabricator.services.mozilla.com/D116422
f7988048b5d7b7827c715ab63eab888f25c882b9: Bug 1702511 - [devtools] Avoid removing the navigation request on navigation in console batch registry. r=jdescottes,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 31 May 2021 20:29:56 +0000 - rev 649883
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1702511 - [devtools] Avoid removing the navigation request on navigation in console batch registry. r=jdescottes,nchevobbe Surprisingly, there is no issue with ResourceWatcher cache, but only with the WebConsoleWrapper which gets its inner cache purged. Differential Revision: https://phabricator.services.mozilla.com/D112232
1a4738901acfca157f47b44faaa55ba9a06e9222: Bug 1702511 - [devtools] Expose isNavigationRequest on NETWORK_EVENT to highlight request done for top level document navigation. r=jdescottes,nchevobbe,bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 31 May 2021 20:29:56 +0000 - rev 649882
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1702511 - [devtools] Expose isNavigationRequest on NETWORK_EVENT to highlight request done for top level document navigation. r=jdescottes,nchevobbe,bomsy Differential Revision: https://phabricator.services.mozilla.com/D112921
3e18373a945ff09b23c4b71d26c5aa0d60195d1f: Bug 1702511 - [devtools] Clear console messages when doing a navigation across processes. r=jdescottes,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 31 May 2021 20:29:56 +0000 - rev 649881
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1702511 - [devtools] Clear console messages when doing a navigation across processes. r=jdescottes,nchevobbe Note that the timestamp being set in WebConsoleWrapper is overriding the one passed from will-navigate and ends up being wrong and too late. Differential Revision: https://phabricator.services.mozilla.com/D115974
90d2e0a0ead6aaab6dfaadb53a5354b22a94f681: Bug 1702511 - [devtools] Init WebConsoleWrapper before watching for console resources. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 31 May 2021 20:29:55 +0000 - rev 649880
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1702511 - [devtools] Init WebConsoleWrapper before watching for console resources. r=nchevobbe The following changeset, migrating from target's will-navigate events to DOCUMENT_EVENT resources, triggers some action dispatch while calling `_attachTargets`. i.e. Some dispatch* methods of WebConsoleWrapper get called. But as it wasn't initialized yet, it was throwing. Differential Revision: https://phabricator.services.mozilla.com/D116024
8967dc205c2191c67b30baa1960b842861292a8c: Bug 1702511 - [devtools] Flush resources when receiving the will-navigate event. r=jdescottes,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 31 May 2021 20:29:55 +0000 - rev 649879
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1702511 - [devtools] Flush resources when receiving the will-navigate event. r=jdescottes,nchevobbe That's to ensure clearing the panels sooner than later. A few tests depend on this. Without that, target actor's "navigate" event, which isn't throttled, fires *before* DOCUMENT_EVENT's will-navigate. That ends up being a logic issue in the console code. Differential Revision: https://phabricator.services.mozilla.com/D112230
a4562f19df5477490c07d91f257abe100c456dfe: Bug 1702511 - [devtools] Add backward compat code for DOCUMENT_EVENT will-navigate events. r=jdescottes,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 31 May 2021 20:29:55 +0000 - rev 649878
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1702511 - [devtools] Add backward compat code for DOCUMENT_EVENT will-navigate events. r=jdescottes,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D116344
a9b3acde1f3782fa5f4946fd07bafb7272c4a3d6: Bug 1713542 - Build composite tiles and descriptors earlier during frame building r=gfx-reviewers,lsalzman
Glenn Watson <git@intuitionlibrary.com> - Mon, 31 May 2021 20:24:44 +0000 - rev 649877
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1713542 - Build composite tiles and descriptors earlier during frame building r=gfx-reviewers,lsalzman Follow up patches will store composite tiles and descriptors in the local space of the tile. For that reason, we need to build them earlier, before the local_valid_rect is cleared when the render task(s) are created. This patch is refactoring only, it shouldn't have any functional effect. Differential Revision: https://phabricator.services.mozilla.com/D116327
86d27e5cae08a308de523f93869c5c555ac8c5e4: Backed out changeset b021a3ea639f (bug 1712754) at devs request. CLOSED TREE
Sandor Molnar <smolnar@mozilla.com> - Mon, 31 May 2021 23:19:06 +0300 - rev 649876
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Backed out changeset b021a3ea639f (bug 1712754) at devs request. CLOSED TREE
9f3260aaab1126ae26ce8198e6a546a8a71dbae9: Bug 1711663 - Extract non-template stuff into base classes; r=dom-storage-reviewers,asuth
Jan Varga <jvarga@mozilla.com> - Mon, 31 May 2021 19:50:24 +0000 - rev 649875
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1711663 - Extract non-template stuff into base classes; r=dom-storage-reviewers,asuth Differential Revision: https://phabricator.services.mozilla.com/D115361
adb6539a1e6fcfce348f41dc39ee9c8e1b68d6d3: Bug 1711663 - Clean up includes related to FileInfo/FileInfoManager/DatabaseFileInfo/DatabaseFileManager; r=dom-storage-reviewers,jstutte
Jan Varga <jvarga@mozilla.com> - Mon, 31 May 2021 19:50:24 +0000 - rev 649874
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1711663 - Clean up includes related to FileInfo/FileInfoManager/DatabaseFileInfo/DatabaseFileManager; r=dom-storage-reviewers,jstutte Differential Revision: https://phabricator.services.mozilla.com/D115360
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip