363c21e529d0e88f8b5422a825a846776b9cd11c: Bug 1457083 - part 7: Remove methods of TextEditRules and HTMLEditRules, which just return NS_OK r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 10 May 2018 16:04:06 +0900 - rev 473368
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457083 - part 7: Remove methods of TextEditRules and HTMLEditRules, which just return NS_OK r=m_kato Some Did*() of TextEditRules and HTMLEditRules do nothing except returning NS_OK. Let's remove them since there is no reason to keep them. MozReview-Commit-ID: Jcdh5rnm5Yc
e84f2a4cd2ae389f7e10ee4e5f8296b1d0ab98b5: Bug 1457083 - part 6: Get rid of unnecessary Selection argument from all protected/private methods of TextEditRules and HTMLEditRules r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 10 May 2018 15:03:21 +0900 - rev 473367
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457083 - part 6: Get rid of unnecessary Selection argument from all protected/private methods of TextEditRules and HTMLEditRules r=m_kato Now, each protected/private method of TextEditRules and HTMLEditRules can retrieve Selection instance safely and quickly. Therefore, their pointer or reference of Selection arguments are not necessary. Therefore, this patch removes them. MozReview-Commit-ID: 1SPmKXmd7kz
7574aa05f0cf9727be7dab744d2907cc77d41486: Bug 1457083 - part 5: Make all users of Selection in TextEditRules and HTMLEditRules use TextEditRules::SelectionRef() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 08 May 2018 17:30:05 +0900 - rev 473366
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457083 - part 5: Make all users of Selection in TextEditRules and HTMLEditRules use TextEditRules::SelectionRef() r=m_kato After this patch applies, most methods of TextEditRules and HTMLEditRules don't need to take Selection as their arguments. Therefore, next patch will remove them. MozReview-Commit-ID: 99r3ZkfG2In
c469a8b14bf4d221375b51255e801039597d7e39: Bug 1457083 - part 4: Replace mHTMLEditor in HTMLEditRules with HTMLEditorRef() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Apr 2018 01:42:22 +0900 - rev 473365
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457083 - part 4: Replace mHTMLEditor in HTMLEditRules with HTMLEditorRef() r=m_kato Although, this patch removes first check of mHTMLEditor in each method. If this causes some security issues, we should add now. However, automated tests don't indicate it. Anyway, it should be fixed by bug 1454900 in same cycle. MozReview-Commit-ID: 3LAtOQHyR5J
4320b35386e96417f68d4862f6a369473750d029: Bug 1457083 - part 3: Replace mTextEditor in TextEditRules with TextEditorRef() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Apr 2018 00:09:10 +0900 - rev 473364
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457083 - part 3: Replace mTextEditor in TextEditRules with TextEditorRef() r=m_kato This patch adds a debug methods to check if AutoSafeEditorData as expected and inserting top of each method whose mTextEditor is replaced with TextEditorRef(). MozReview-Commit-ID: 8yjHsypLMRx
fcacbe739f6779e1bdb51773c1480c9d3271c6ee: Bug 1457083 - part 2: Make all observer methods of HTMLEditRules create AutoSafeEditorData r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 26 Apr 2018 23:27:50 +0900 - rev 473363
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457083 - part 2: Make all observer methods of HTMLEditRules create AutoSafeEditorData r=m_kato Except HTMLEditRules::WillJoinNodes(), observer methods of HTMLEditRules accesses mHTMLEditor. Therefore, we need to make them create AutoSafeEditorData instance in the stack. Note that for reducing EditorBase::GetSelection() calls, this patch adds Selection& argument to all of them. MozReview-Commit-ID: 6mjuD2gZwVp
d7e797f898b05a4edc47b7369dad793162cb91e6: Bug 1457083 - part 1: Make public methods of TextEditUtils and HTMLEditUtils guarantee that the editor instance and selection instance won't be destroyed while it handles any edit actions r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 26 Apr 2018 22:41:34 +0900 - rev 473362
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457083 - part 1: Make public methods of TextEditUtils and HTMLEditUtils guarantee that the editor instance and selection instance won't be destroyed while it handles any edit actions r=m_kato This patch creates a stack class in TextEditRules, its name is AutoSafeEditorData and make all public methods (except editor observer methods) which may change DOM tree, fire some DOM events or calling some XPCOM listeners create its instance in the stack. Then, it grabs associated editor instance and its selection instance. Next patch will make remaining public methods create AutoSafeEditorData. MozReview-Commit-ID: 8oshdhL3ONQ
f5cbef593cc1a17680e3ac94b7fa9b23a9ee41c0: Bug 1451840 - Add button to Pocket doorhanger to request mobile app r=Gijs
anthony <anthony@getpocket.com> - Thu, 17 May 2018 14:12:02 -0700 - rev 473361
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1451840 - Add button to Pocket doorhanger to request mobile app r=Gijs By showing users an upsell, positioned as a feature, as part of the save confirmation and make it easy for users to get the mobile app, more users will understand the value of the Pocket mobile and start using the mobile app. The initial experiment will target existing logged in English users only. We've added flags to the server response on the save request that: - Set whether the user has the mobile app - Which variant of the experiment the user should be enrolled in If the user has an account, but they've never installed the Android or iOS app, we will display a new button inline in the current panel that will email a link to the mobile application to the user. MozReview-Commit-ID: 2xtPv5GPVbL *** Bug 1451840 - Add button to Pocket doorhanger to request mobile app - Specified default color on buttons - Removed unnecessary css styles - Resized icon display size - Made RTL friendly - Simplified SVGs - Updated buttons to be html buttons for screen readers MozReview-Commit-ID: HdTi1CZbXdc
081438ba2d2713123c98e7214c5e96dd9e231ade: Backed out 4 changesets (bug 1463055) for failing devtools at browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Mon, 21 May 2018 19:08:59 +0300 - rev 473360
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Backed out 4 changesets (bug 1463055) for failing devtools at browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE Backed out changeset 767352c4858e (bug 1463055) Backed out changeset 59dd330ceb81 (bug 1463055) Backed out changeset 52b3ed8fa57d (bug 1463055) Backed out changeset 125efe55befb (bug 1463055)
7c4c86f3913fe595adde26cc3d4cc3eec062b52e: Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;r=Paolo
Brian Grinstead <bgrinstead@mozilla.com> - Sat, 19 May 2018 13:56:06 -0700 - rev 473359
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;r=Paolo MozReview-Commit-ID: IG84xKxO9Wc
80cc5997d8cce2ab82bc2695a7f8f69356f595d0: Bug 1461345 - Move browser.search.order to list.json. r=adw
Michael Kaply <mozilla@kaply.com> - Fri, 18 May 2018 16:12:32 -0500 - rev 473358
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1461345 - Move browser.search.order to list.json. r=adw MozReview-Commit-ID: 4eaWb8mzIm6
610da3d903bec2983d0e56d051d7d915a6bb86bb: Bug 1462357 - remove the channel and socket interface id r=bagder,baku
Patrick McManus <mcmanus@ducksong.com> - Wed, 16 May 2018 16:05:03 -0400 - rev 473357
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1462357 - remove the channel and socket interface id r=bagder,baku the id was a b2g feature only settable via chrome privd xhr and is no longer active in the code base MozReview-Commit-ID: 84GPNvhvjNb
723ce0f95ab28a3ab4a8207ecbd15e7bcd181e9e: Bug 1463011 - Constexpr-ify mozilla::NotNull r=njn
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Mon, 21 May 2018 23:03:16 +0900 - rev 473356
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1463011 - Constexpr-ify mozilla::NotNull r=njn MozReview-Commit-ID: EyXmRskjtfU
6e571fd8686390e3d870a97e38f54ea69cfcf0b7: Merge mozilla-central to autoland. a=backout CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Mon, 21 May 2018 16:58:56 +0300 - rev 473355
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Merge mozilla-central to autoland. a=backout CLOSED TREE
767352c4858edb340a545ec56553a3f4c2aef13a: Bug 1463055 - Font editor: edit font that is both used and declared in font-family. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Mon, 21 May 2018 10:04:13 +0200 - rev 473354
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1463055 - Font editor: edit font that is both used and declared in font-family. r=pbro MozReview-Commit-ID: G7YOPLw7qLF
59dd330ceb81263637286e4e237c36fea4290875: Bug 1463055 - Font editor: read properties from computed style; write to inline style. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Mon, 21 May 2018 10:24:59 +0200 - rev 473353
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1463055 - Font editor: read properties from computed style; write to inline style. r=pbro MozReview-Commit-ID: 6sHeBgfbiDT
52b3ed8fa57d14c3528384383a170b6dd0427225: Bug 1463055 - Font editor: merge editor panel with overview (temporary until redesign). r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Mon, 21 May 2018 10:22:53 +0200 - rev 473352
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1463055 - Font editor: merge editor panel with overview (temporary until redesign). r=pbro MozReview-Commit-ID: 5QSEEGgsoPO
125efe55befbeff32f4a08d0820bec440b844018: Bug 1463055 - Font Editor: remove toggle from rule view and associated logic. r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Mon, 21 May 2018 09:44:11 +0200 - rev 473351
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1463055 - Font Editor: remove toggle from rule view and associated logic. r=pbro MozReview-Commit-ID: JlH1oUh5jaN
d1d367709ab13d99377dbdf4d7d1b161403bf23e: Bug 1450376 - Ignore blocked permission requests in permission prompt telemetry. r=jkt
Johann Hofmann <jhofmann@mozilla.com> - Wed, 16 May 2018 18:41:13 +0200 - rev 473350
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1450376 - Ignore blocked permission requests in permission prompt telemetry. r=jkt MozReview-Commit-ID: 5ykJl0ZSytD
f1fe5e4c8ce5f8bab3ed63e2c751fd3a5db43a3c: Backed out changeset 5352d48512f7 (bug 1458159) for failing reftest min-intrinsic-with-percents-across-elements.html == min-intrinsic-with-percents-across-elements-ref.html on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Mon, 21 May 2018 13:00:19 +0300 - rev 473349
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Backed out changeset 5352d48512f7 (bug 1458159) for failing reftest min-intrinsic-with-percents-across-elements.html == min-intrinsic-with-percents-across-elements-ref.html on a CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip