355c9ff9b895: Bug 1526717. Guard against libpng calling the info callback more than once. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Thu, 14 Mar 2019 14:32:37 -0500 - rev 522000
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1526717. Guard against libpng calling the info callback more than once. r=aosmond libpng uses the first IDAT chunk it encounters as a signal that it has read all header chunks and to send the info callback. The testcase png has an IDAT chunk, then a z chunk (not a known chunk type), and then another IDAT chunk. libpng tracks if we are in an "after idat" state, and throws a benign error if it encounters another IDAT chunk in "after idat" mode, but it just continues normally, processing the idat chunk as if it were the first and therefore sends the info callback again. This seems silly. https://searchfox.org/mozilla-central/rev/f1c7ba91fad60bfea184006f3728dd6ac48c8e56/media/libpng/pngpread.c#307
8854d4a16528: Bug 1343357 - Ignore lower-priority animateMotion if a to-animation is encountered r=dholbert
violet <violet.bugreport@gmail.com> - Fri, 15 Mar 2019 01:26:13 +0000 - rev 521999
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1343357 - Ignore lower-priority animateMotion if a to-animation is encountered r=dholbert Current impl at SVGMotionSMILType::Interpolate has some wrong assertions, it's probably caused by overlooking the special behavior of to-animation. These assumptions also lead weird animation in the product build. Now we take to-animation into account, and implement similar behavior as Chrome and Safari. Differential Revision: https://phabricator.services.mozilla.com/D23095
a34bdd9a2ebc: Bug 1535460 - Add dark theme styles, Discovery stream blocking and bug fixes to Activity Stream r=r1cky
k88hudson <k88hudson@gmail.com> - Thu, 14 Mar 2019 22:27:33 +0000 - rev 521998
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1535460 - Add dark theme styles, Discovery stream blocking and bug fixes to Activity Stream r=r1cky Differential Revision: https://phabricator.services.mozilla.com/D23589
76a3b7b0c9d7: Bug 1451104 - part 6 - don't remove the libstdc++ files from the mingw build; r=glandium
Nathan Froyd <froydnj@gmail.com> - Fri, 15 Mar 2019 01:29:33 +0000 - rev 521997
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1451104 - part 6 - don't remove the libstdc++ files from the mingw build; r=glandium History does not disclose why we needed this, but in the brave new GCC 6-compiled world, deleting these files means that host links can no longer find libstdc++, which causes problems. Let's put the files back. Differential Revision: https://phabricator.services.mozilla.com/D22884
858b68d306f2: Bug 1451104 - part 5 - move toolchains off GCC 4.9; r=glandium
Nathan Froyd <froydnj@gmail.com> - Fri, 15 Mar 2019 01:29:23 +0000 - rev 521996
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1451104 - part 5 - move toolchains off GCC 4.9; r=glandium Firefox itself has moved on to GCC 6.x; we can move our toolchains along too. Differential Revision: https://phabricator.services.mozilla.com/D22883
292ed1bb9143: Bug 1451104 - part 4 - sync up gcc-related toolchains and linux64-binutils binutils version; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Fri, 15 Mar 2019 01:29:14 +0000 - rev 521995
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1451104 - part 4 - sync up gcc-related toolchains and linux64-binutils binutils version; r=glandium We're going to copy an x86_64-unknown-linux-gnu ld into the clang build, which clang will then use in preference to things on PATH. We therefore need to ensure that this ld is the same ld as would be used for other builds, such as PGO. This change is the most expedient way to do that; future work will make the gcc job(s) depend on linux64-binutils directly. Differential Revision: https://phabricator.services.mozilla.com/D22882
f3290e95b38d: Bug 1451104 - part 3 - inform stage2/3 clang about gcc binutils; r=glandium
Nathan Froyd <froydnj@gmail.com> - Fri, 15 Mar 2019 01:29:04 +0000 - rev 521994
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1451104 - part 3 - inform stage2/3 clang about gcc binutils; r=glandium We do this to encourage clang to find an new-enough linker instead of the system one. Differential Revision: https://phabricator.services.mozilla.com/D22881
961ac7318786: Bug 1451104 - part 2 - force clang to always pick up its local GCC headers and libraries; r=glandium
Nathan Froyd <froydnj@gmail.com> - Fri, 15 Mar 2019 01:28:55 +0000 - rev 521993
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1451104 - part 2 - force clang to always pick up its local GCC headers and libraries; r=glandium We want our clang bootstrap to use the GCC headers we're building with, not whatever sysroot it happens to find on the server we're building on. The -gcc-toolchain argument we specify when building clang will also be picked up by llvm-config, so we need to strip it out when building the plugin. Otherwise, we will get peculiar failures about not being able to find C++ header files. Differential Revision: https://phabricator.services.mozilla.com/D22880
468eed96e879: Bug 1451104 - part 1 - be explicit about our GCC/binutils target and build machine; r=glandium
Nathan Froyd <froydnj@gmail.com> - Fri, 15 Mar 2019 01:28:10 +0000 - rev 521992
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1451104 - part 1 - be explicit about our GCC/binutils target and build machine; r=glandium Explicit is better than implicit, and helps ensure that GCC is always using the binutils we built it with, rather than the system binutils. Differential Revision: https://phabricator.services.mozilla.com/D22879
9d33ee85f2d4: Bug 1488991: Update remote browser position before showing context menu. r=pbro,smaug
Daisuke Akatsuka <dakatsuka@mozilla.com> - Fri, 15 Mar 2019 00:09:20 +0000 - rev 521991
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1488991: Update remote browser position before showing context menu. r=pbro,smaug The position of remote browser was not updated by resizing the window and changing the align of viewport etc, although will be updated when the window moves, the frame reflows and so on. Thus, in this patch, update the position of remote browser before showing context menu so as to locates at proper position. I investigated though, when reflow and moving happens, the position is updated by TabParent::UpdateDimensions()[1]. This patch as well is taking an approach which update the position explicitly by TabParent::UpdateDimensions() before showing context menu. [1] https://searchfox.org/mozilla-central/source/dom/ipc/TabParent.cpp#729 Differential Revision: https://phabricator.services.mozilla.com/D23470
f28acbccbc62: Bug 1525729 - Stop blocking extension startup on searchInitialized r=aswan
Rob Wu <rob@robwu.nl> - Wed, 13 Mar 2019 18:48:57 +0000 - rev 521990
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1525729 - Stop blocking extension startup on searchInitialized r=aswan Depends on D23311 Differential Revision: https://phabricator.services.mozilla.com/D19701
57a544b33b51: Bug 1534969 - Ensure that extension.id/uuid is set in browser tests r=aswan
Rob Wu <rob@robwu.nl> - Wed, 13 Mar 2019 18:48:53 +0000 - rev 521989
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1534969 - Ensure that extension.id/uuid is set in browser tests r=aswan Differential Revision: https://phabricator.services.mozilla.com/D23311
f32dc8409c3d: Bug 1524655 - Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey
Lina Cambridge <lina@yakshaving.ninja> - Thu, 14 Mar 2019 22:37:51 +0000 - rev 521988
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1524655 - Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey This commit also fixes a race in `test_error_reporting.html`, where the push service would initialize and attach its listeners after `sessionstore-windows-restored`. Even though the test replaces the real service with a mock, the former keeps listening for pref changes. When the test calls `setupPrefs` to enable the push connection, the real service tries to connect to the push server, which asserts in automation because non-local connections aren't allowed. We work around this by ensuring that `replacePushService` and `restorePushService` always wait for the service to shut down before replacing it with a mock, or restoring the real implementation. Finally, this commit removes a test that's no longer relevant, since we don't need to fetch all subscriptions at startup. Differential Revision: https://phabricator.services.mozilla.com/D20085
f0c35396d81f: Bug 1535223 - part3 : add log in TextTrack and TextTrackCue. r=jya
Alastor Wu <alwu@mozilla.com> - Thu, 14 Mar 2019 23:25:10 +0000 - rev 521987
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1535223 - part3 : add log in TextTrack and TextTrackCue. r=jya It would be helpful if we can also print the information in `TextTrack` and `TextTrackCue`. Differential Revision: https://phabricator.services.mozilla.com/D23449
49dd1144a43d: Bug 1535223 - part2 : update TextTrackManager's logs. r=jya
Alastor Wu <alwu@mozilla.com> - Thu, 14 Mar 2019 23:24:32 +0000 - rev 521986
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1535223 - part2 : update TextTrackManager's logs. r=jya Automatically print `TextTrackManager`'s address for the log marco, also update some exist logs. Differential Revision: https://phabricator.services.mozilla.com/D23448
8b0cef2fcae5: Bug 1535223 - part1 : rename log module's name. r=jya
Alastor Wu <alwu@mozilla.com> - Thu, 14 Mar 2019 23:21:28 +0000 - rev 521985
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1535223 - part1 : rename log module's name. r=jya Use more general name `WebVTT` for this log module, which will include other debug logs in other files later. Differential Revision: https://phabricator.services.mozilla.com/D23447
5621ae8031ce: Bug 1535214 run AudioWorklet for realtime AudioContext on GraphRunner thread r=padenot
Karl Tomlinson <karlt+@karlt.net> - Thu, 14 Mar 2019 13:40:07 +0000 - rev 521984
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1535214 run AudioWorklet for realtime AudioContext on GraphRunner thread r=padenot Differential Revision: https://phabricator.services.mozilla.com/D23445
5ce27c44f79e: Bug 1533783 - Avoid crashing when calling insertRule("@import ...") on a detached sheet. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Mar 2019 22:30:37 +0000 - rev 521983
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1533783 - Avoid crashing when calling insertRule("@import ...") on a detached sheet. r=heycam This should unblock the fuzzers for now, though it's not the ideal solution. It's the only reasonably easy solution to unblock them though, I think. We should probably always keep track of the document a stylesheet was associated with. We'll need that for constructible stylesheets anyway. That requires some though on how to get the cycle-collection and such right, though, and I wouldn't be able to write or land that ASAP. Differential Revision: https://phabricator.services.mozilla.com/D23584
c0613d0cb732: Bug 1535130 - Don't show breakpoint line when focused on close button r=jlast
David Walsh <davidwalsh83@gmail.com> - Thu, 14 Mar 2019 20:30:28 +0000 - rev 521982
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1535130 - Don't show breakpoint line when focused on close button r=jlast Differential Revision: https://phabricator.services.mozilla.com/D23409
33f142760b69: Bug 1534808 - Don't show pretty print option for non-JS sources r=jlast
David Walsh <davidwalsh83@gmail.com> - Thu, 14 Mar 2019 20:31:41 +0000 - rev 521981
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1534808 - Don't show pretty print option for non-JS sources r=jlast Differential Revision: https://phabricator.services.mozilla.com/D23333
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 tip