32eb76185a118a033a7525161f31290fe062f1e2: Bug 1496094 - Fix determining the correct target path of a reparse point. r=rstrong, a=pascalc
Matt Howell <mhowell@mozilla.com> - Fri, 05 Oct 2018 00:18:01 +0000 - rev 490193
Push 9942 by ryanvm@gmail.com at Fri, 05 Oct 2018 20:27:04 +0000
Bug 1496094 - Fix determining the correct target path of a reparse point. r=rstrong, a=pascalc The two standard reparse data buffer structs (SymbolicLinkReparseBuffer and MountPointReparseBuffer) both contain one UTF-16 array called PathBuffer which contains two paths, the "print name" and the "substitute name", with no separator between them. There are also fields in the struct that provide the offset and the length of both those paths (in bytes). I had originally missed that these were separate paths and that the print name will typically not match the substitute name for file system links. This patch corrects that oversight and uses the offsets to correctly check only the substitute name. Differential Revision: https://phabricator.services.mozilla.com/D7645
dd37ab60c111c34e9160509c75297cc39d6c9e0d: Bug 1489229 - Return early from WPAD runnable when pref has been changed. r=bagder, a=pascalc
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 04 Oct 2018 08:42:21 +0000 - rev 490192
Push 9942 by ryanvm@gmail.com at Fri, 05 Oct 2018 20:27:04 +0000
Bug 1489229 - Return early from WPAD runnable when pref has been changed. r=bagder, a=pascalc Bug 356831 added a release assert that when performing WPAD the network.proxy.type pref is always 4 (PROXYCONFIG_WPAD). However, when changing the pref, the runnable is scheduled to run before the PAC thread is shutdown, so it will see the pref that is not PROXYCONFIG_WPAD, while attempting to do WPAD. To avoid this situation, we simply exit early when we detect the wrong pref value. Differential Revision: https://phabricator.services.mozilla.com/D7617
6375a647b5b70f0dc565f57cdeea2dbd476d8102: Bug 1489229 - Crash on MOZ_RELEASE_ASSERT which checks that WPAD is not being called if not explicitly requested by the user prefs. r=valentin, a=pascalc
Polly Shaw <polly.shaw@gmail.com> - Mon, 01 Oct 2018 09:11:33 +0000 - rev 490191
Push 9942 by ryanvm@gmail.com at Fri, 05 Oct 2018 20:27:04 +0000
Bug 1489229 - Crash on MOZ_RELEASE_ASSERT which checks that WPAD is not being called if not explicitly requested by the user prefs. r=valentin, a=pascalc The author did not isolate and fix the cause of the assertion failure, but put in further diagnostics.The author did not isolate and fix the cause of the assertion failure, but put in further diagnostics. * an additional assertion was put in on the main thread (which if triggered would reveal the stack trace) * in one place where a previously a failure to read the network.proxy.type pref was ignored, execution of WPAD is now halted with a warning. Besides these improved diagnostics, in nsPACMan::LoadPACFromURI where an asynchronous call was made to nsPACMan::StartLoading *before* the preconditions for this call are set up was changed to be the other way around. The author suspects that the previous code may have led to race conditions when LoadPACFromURI was not called from the main thread, although it is not obvious that this would have caused such a crash. Differential Revision: https://phabricator.services.mozilla.com/D5388
4c33398398a55023ccae92d19ee0f18baf7f4a39: Bug 1486278 - Workaround Bug 1495350 in video controls. r=Gijs,birtles, a=pascalc
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 02 Oct 2018 19:11:31 +0000 - rev 490190
Push 9942 by ryanvm@gmail.com at Fri, 05 Oct 2018 20:27:04 +0000
Bug 1486278 - Workaround Bug 1495350 in video controls. r=Gijs,birtles, a=pascalc For compositor animations, we don't guarantee the finished promise callback to run in the first frame after the animation finishes. By setting fill: both, we set the animation to fill until the main thread has a chance to catch up. A filling animation has to be cancelled explicitly, otherwise the value of the animating style will be locked at the last frame of the animation. Differential Revision: https://phabricator.services.mozilla.com/D7317
f52b00b9fd5945caa9b5c177599dd5639d063eb7: Bug 1493089 - Cancel the pending animation instead of reversing it. r=Gijs, a=pascalc
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 26 Sep 2018 19:38:29 +0000 - rev 490189
Push 9942 by ryanvm@gmail.com at Fri, 05 Oct 2018 20:27:04 +0000
Bug 1493089 - Cancel the pending animation instead of reversing it. r=Gijs, a=pascalc My understanding of Web Animation API was wrong in bug 1449532. If a running animation is pending, playing a new (reversed) animation will cause it to play from the beginning of the new animation, instead of having the new animation to play, in reverse, from the current position. This has caused the user to see a fade out animation that shouldn't take place when the video loops, i.e. going from "seeking" to "seeked". The code now probe into the state of the animation instance and cancel the pending animation, reverse the running animation, or start the new (reversed) animation accordingly. Differential Revision: https://phabricator.services.mozilla.com/D6704
9671f6ac6cbeae04e605a35ebda003d1006e2af5: Backed out changeset 01237eeedfac (bug 1493629) for wpt failures on ContentSecurityPolicy. a=backout
Cosmin Sabou <csabou@mozilla.com> - Fri, 05 Oct 2018 19:43:53 +0300 - rev 490188
Push 9941 by csabou@mozilla.com at Fri, 05 Oct 2018 16:47:03 +0000
Backed out changeset 01237eeedfac (bug 1493629) for wpt failures on ContentSecurityPolicy. a=backout
0ab725eb0f3d5f99a6b1a3af163270c02dda5b35: No bug - Tagging 0ad842642aa7bca6216b9606a103250f08af0188 with DEVEDITION_63_0b12_RELEASE a=release CLOSED TREE
Mozilla Releng Treescript <release+treescript@mozilla.org> - Fri, 05 Oct 2018 16:19:21 +0000 - rev 490187
Push 9940 by ffxbld at Fri, 05 Oct 2018 16:19:30 +0000
No bug - Tagging 0ad842642aa7bca6216b9606a103250f08af0188 with DEVEDITION_63_0b12_RELEASE a=release CLOSED TREE
8ad6d89e237e5b08064f61fecc5b8432749fda73: Automatic version bump CLOSED TREE NO BUG a=release
Mozilla Releng Treescript <release+treescript@mozilla.org> - Fri, 05 Oct 2018 16:16:42 +0000 - rev 490186
Push 9939 by ffxbld at Fri, 05 Oct 2018 16:16:51 +0000
Automatic version bump CLOSED TREE NO BUG a=release
c3df2456a08175e477a13e322b577a045d132cb9: No bug - Tagging 0082062b759f342cb97dd2f46486ca29552b16e4 with FIREFOX_63_0b12_RELEASE a=release CLOSED TREE
Mozilla Releng Treescript <release+treescript@mozilla.org> - Fri, 05 Oct 2018 16:16:38 +0000 - rev 490185
Push 9939 by ffxbld at Fri, 05 Oct 2018 16:16:51 +0000
No bug - Tagging 0082062b759f342cb97dd2f46486ca29552b16e4 with FIREFOX_63_0b12_RELEASE a=release CLOSED TREE
3e4a2d14ca356812851c177c5d7fed4b32566e6f: Bug 1487167 - Various DOM rooting issues. r=bz, a=RyanVM
Steve Fink <sfink@mozilla.com> - Tue, 28 Aug 2018 21:26:50 -0700 - rev 490184
Push 9938 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:41:38 +0000
Bug 1487167 - Various DOM rooting issues. r=bz, a=RyanVM
b1b3f1e5ec42a960fddf10f10ae8a0ecba93f784: Backed out changesets 3886ffc45b71 and f6d84997277d (bug 1418470) for longer bake time.
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 05 Oct 2018 11:38:00 -0400 - rev 490183
Push 9938 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:41:38 +0000
Backed out changesets 3886ffc45b71 and f6d84997277d (bug 1418470) for longer bake time.
01237eeedfac765312a1322b28719782c3a71731: Bug 1493629 - Better management of CSP EventListener for workers. r=ckerschb, a=pascalc
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 05 Oct 2018 07:41:12 +0200 - rev 490182
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1493629 - Better management of CSP EventListener for workers. r=ckerschb, a=pascalc
135174a61d2db7777a05677af493e2ed23b8fe31: Bug 1494496 - Renew GEOLOCATION_REQUEST_GRANTED probe. r=jdm, a=pascalc
Tim D. Smith <tdsmith@mozilla.com> - Thu, 27 Sep 2018 18:41:45 +0000 - rev 490181
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1494496 - Renew GEOLOCATION_REQUEST_GRANTED probe. r=jdm, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D7027
c0c2333f0ffa31ba84e55585f9225f0fe62b0793: Bug 1494582 - Adjust toggle input direction for right-to-left layout. r=pbro, a=pascalc
Razvan Caliman <rcaliman@mozilla.com> - Thu, 04 Oct 2018 06:51:04 +0000 - rev 490180
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1494582 - Adjust toggle input direction for right-to-left layout. r=pbro, a=pascalc MozReview-Commit-ID: 5ItuYNHsmQt Differential Revision: https://phabricator.services.mozilla.com/D7623
b75cfee22e1e01acd8f2d87780d787d43eeb15e7: Bug 1495523 - Disable TRR after max-fails number of failed requests. r=valentin, a=pascalc
Daniel Stenberg <daniel@haxx.se> - Wed, 03 Oct 2018 11:53:46 +0000 - rev 490179
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1495523 - Disable TRR after max-fails number of failed requests. r=valentin, a=pascalc MozReview-Commit-ID: 2dSEY6DuP2A Differential Revision: https://phabricator.services.mozilla.com/D7587
00ea8935b012372f3623ef15b4506b7f69f983bd: Bug 1492308 - 1. Generate natives binding for all JNIObject classes; r=snorp, a=pascalc
Jim Chen <nchen@mozilla.com> - Tue, 02 Oct 2018 19:59:28 +0000 - rev 490178
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1492308 - 1. Generate natives binding for all JNIObject classes; r=snorp, a=pascalc Right now we skip generating natives binding for a class if the class doesn't have native methods. However, we should still generate the natives binding for JNIObject classes because these classes can still be attached to C++ objects even without native methods. Differential Revision: https://phabricator.services.mozilla.com/D7106 Bug 1492308 - 2. Create new native handle before clearing old one; r=snorp Create a new native handle first before deleting any old ones, so we can be sure the new handle would not have the same value as the old handle, which can confuse our code. Differential Revision: https://phabricator.services.mozilla.com/D7107 Bug 1492308 - 3. Add test for tapping after content crash; r=snorp Add a test for the crash scenario where PZC is used after content crashes and restarts. Differential Revision: https://phabricator.services.mozilla.com/D7108 Bug 1492308 - 4. Add new mechanism for safely disposing native objects; r=snorp Add a new mechanism in NativePtr::Detach to safely dispose objects. A new disposer Runnable is passed to OnDetach functions. The OnDetach functions invoke the disposer after changing the object state. The disposer then makes sure the object hasn't been attached to another native object in the meantime. Disposal is only performed when the current native object matches the original one. Differential Revision: https://phabricator.services.mozilla.com/D7109 Bug 1492308 - 5. Make various objects use the new disposal mechanism; r=snorp Make LayerViewSupport, NPZCSupport, and GeckoEditableSupport use the new disposal mechanism to ensure the disposal is performed safely. Differential Revision: https://phabricator.services.mozilla.com/D7110
24ee15badf0605bb429c87566eaf4f58c56e73b1: Bug 1299001 - Ensure that the toolbox resets the preferences set when it is closed. r=ochameau, a=pascalc
Luca Greco <lgreco@mozilla.com> - Tue, 02 Oct 2018 19:09:37 +0000 - rev 490177
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1299001 - Ensure that the toolbox resets the preferences set when it is closed. r=ochameau, a=pascalc This patch fixes a regression which has been likely introduced in the refactoring we did in Bug 1222047 on Firefox 63. Differential Revision: https://phabricator.services.mozilla.com/D7523
e181e77ac1586bfe3c56e8e971c05c767bf251aa: Bug 1409570 - Ensure that transactions matched with http/2 pushed streams are properly finished. r=bagder, a=pascalc
Nicholas Hurley <hurley@mozilla.com> - Mon, 01 Oct 2018 21:52:57 +0000 - rev 490176
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1409570 - Ensure that transactions matched with http/2 pushed streams are properly finished. r=bagder, a=pascalc There was an earlier fix to this, that fixed part of the issue, but that fix was racy. In the case where the transaction was matched with the pushed stream before the pushed stream received its END_STREAM, and the response headers did not include a content-length, the transaction would never notice that the data was done being sent. When that transaction was necessary for the load event to fire, the page would get stuck in the loading state until the user explicitly cancelled. This new patch ensures that the transaction will notice the EOS by making sure the pushed stream gets inserted into the list of push streams with data in the case described above. (The previous patch, which is still in the tree, is still necessary, but not sufficient, to fix the issue.) Differential Revision: https://phabricator.services.mozilla.com/D7298
d35270b1cafc2426dc20e3f5df2d0097990e1c44: Bug 1494203 - Ensure the pattern we're highlighting is not interpreted as a regular expression r=nalexander a=pascalc
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 03 Oct 2018 16:24:51 +0000 - rev 490175
Push 9936 by gsvelto@mozilla.com at Fri, 05 Oct 2018 13:21:59 +0000
Bug 1494203 - Ensure the pattern we're highlighting is not interpreted as a regular expression r=nalexander a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D6891
6be41a677718e648495777aaf49705538773d72c: Bug 1127855 - Handle title highlighting properly in all locales r=nalexander a=pascalc
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 24 Sep 2018 20:37:01 +0000 - rev 490174
Push 9936 by gsvelto@mozilla.com at Fri, 05 Oct 2018 13:21:59 +0000
Bug 1127855 - Handle title highlighting properly in all locales r=nalexander a=pascalc This patch uses a case-insensitive matcher to highlight the title of a history entry that's been typed by the user. Previously the matching substring was calculated manually as lowercase assuming that it's representation would have the same number of characters as the original mixed case. In some locales howerver this assumption is wrong leading to out-of-bound exceptions when highlighting part of the title. Differential Revision: https://phabricator.services.mozilla.com/D6661
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip