32a3b7c392070cb1f9eb7b1ec1e177c6303d9d3f: Bug 1368102: Part 5 - Move static content script matching into C++. r=mixedpuppy,zombie
Kris Maglione <maglione.k@gmail.com> - Sun, 04 Jun 2017 15:38:11 -0700 - rev 410377
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368102: Part 5 - Move static content script matching into C++. r=mixedpuppy,zombie MozReview-Commit-ID: Co04MoscqMx
417fd0cf65a8bddc78c59156cb317cc4156f9392: Bug 1368102: Part 4 - Use WebExtensionContentScript to match content scripts. r=mixedpuppy,zombie
Kris Maglione <maglione.k@gmail.com> - Sat, 03 Jun 2017 17:11:08 -0700 - rev 410376
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368102: Part 4 - Use WebExtensionContentScript to match content scripts. r=mixedpuppy,zombie MozReview-Commit-ID: 1Ga0259WjC
b9439245aa6bc591c4e138ea2f6978d7e3bab831: Bug 1368102: Part 3 - Use MatchPattern and MatchGlob bindings for content script matching. r=mixedpuppy
Kris Maglione <maglione.k@gmail.com> - Thu, 25 May 2017 15:42:18 -0700 - rev 410375
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368102: Part 3 - Use MatchPattern and MatchGlob bindings for content script matching. r=mixedpuppy MozReview-Commit-ID: AvNCU77I2Je
056e3d934eb26523b35fcdd4b1cdadca2c8bb190: Bug 1368102: Part 2 - Add WebExtensionContentScript bindings. r=billm,mixedpuppy
Kris Maglione <maglione.k@gmail.com> - Sat, 03 Jun 2017 22:03:19 -0700 - rev 410374
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368102: Part 2 - Add WebExtensionContentScript bindings. r=billm,mixedpuppy Bill, can you please review the binding code? Shane and zombie, can you please review the content script matching? MozReview-Commit-ID: IJB5s0a7r7S
863506a00d8362e8fe180001d0d4183c1b1f9d3c: Bug 1368102: Part 1 - Make AddonManagerWebAPI::IsValidSite public. r=aswan
Kris Maglione <maglione.k@gmail.com> - Tue, 23 May 2017 12:35:35 -0700 - rev 410373
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1368102: Part 1 - Make AddonManagerWebAPI::IsValidSite public. r=aswan MozReview-Commit-ID: JNNyfY8eabB
e6001a0646bb46df0266896fe5bf2069b6cfadae: Bug 1322235: Part 7 - DeCOMtaminate moz-extension protocol handler. r=billm
Kris Maglione <maglione.k@gmail.com> - Tue, 23 May 2017 14:40:38 -0700 - rev 410372
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1322235: Part 7 - DeCOMtaminate moz-extension protocol handler. r=billm This removes unnecessary COM overhead from the extension protocol service, particularly from the flag lookup code, which is called often, and from hot paths. The devirtualized lookups should have virtually no overhead for extensions without web-accessible resources, and very little overhead except when resources are specified as non-prefix globs. MozReview-Commit-ID: 4hQ7GuQSjvW
35e67c38d3cd93cc43f4665849847959f7d97656: Bug 1322235: Part 6 - Replace AddonPolicyService with a stub implementation in ExtensionPolicyService. r=mixedpuppy,zombie
Kris Maglione <maglione.k@gmail.com> - Sat, 03 Jun 2017 17:12:14 -0700 - rev 410371
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1322235: Part 6 - Replace AddonPolicyService with a stub implementation in ExtensionPolicyService. r=mixedpuppy,zombie This replaces the JS policy service stubs with a pure C++ version which directly makes policy decisions based on active WebExtensionPolicy objects. This is the first step in a larger refactoring, which will remove the ExtensionManagement module entirely, and replace the current add-on policy service with direct, non-virtual access to native WebExtensionPolicy objects. It will also be followed by related changes to migrate the content script and extension page matching to native code, based on the existing MatchPattern and WebExtensionPolicy bindings. MozReview-Commit-ID: 2MpbmXZGiPZ
02ce614daf1999405cd4e63d60ab2b6ebd4e4048: Bug 1322235: Part 5 - Add an ExtensionPolicyService singleton class to track active extension policies. r=billm,mixedpuppy
Kris Maglione <maglione.k@gmail.com> - Tue, 23 May 2017 19:15:10 -0700 - rev 410370
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1322235: Part 5 - Add an ExtensionPolicyService singleton class to track active extension policies. r=billm,mixedpuppy Bill, can you please review the binding changes? Shane, can you please review the policy service? This is the first step to making extension policy data directly available to C++ code without any COM overhead. It tracks the set of currently active extensions, and how they map to add-on IDs and URIs. MozReview-Commit-ID: 9Z61AXFll3P
19d92b19910f3ce9bfa2b2874d17635fe323080b: Bug 1322235: Part 4 - Add initial native WebExtensionPolicy bindings. r=billm,aswan
Kris Maglione <maglione.k@gmail.com> - Wed, 24 May 2017 15:58:19 -0700 - rev 410369
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1322235: Part 4 - Add initial native WebExtensionPolicy bindings. r=billm,aswan Bill, can you please review the binding code and the general sanity of the platform code? Andrew and zombie, can you please review the policy logic and tests? As in part 1, this aims to reduce the overhead of our extension policy logic by making it directly available to native code with as little JS and XPConnect overhead as possible. MozReview-Commit-ID: 40m1wSEYtBo
34316bd2fecfb2802b135ea4f8592468c5fc7618: Bug 1322235: Part 3 - Use MatchPatternSet for whiteListedHosts and webRequest. r=aswan,zombie
Kris Maglione <maglione.k@gmail.com> - Sat, 03 Jun 2017 22:11:20 -0700 - rev 410368
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1322235: Part 3 - Use MatchPatternSet for whiteListedHosts and webRequest. r=aswan,zombie This is the second step to migrating the policy service to pure native code, with similar impacts and reasoning to the previous patch. MozReview-Commit-ID: L5XdPzWNZXM
50e2a20caa7a189c0ed5a8679f483a5b10100aaf: Bug 1322235: Part 2 - Use MatchGlob for webAccessibleResources. r=aswan
Kris Maglione <maglione.k@gmail.com> - Tue, 23 May 2017 22:04:22 -0700 - rev 410367
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1322235: Part 2 - Use MatchGlob for webAccessibleResources. r=aswan This is the first step toward migrating the web-accessible URL policy to purely native code. It should have a noticeable performance improvement on its own, but the main improvement comes from being able to pass the pattern objects to the pure C++ policy service. MozReview-Commit-ID: DHoGLVr8yJ9
94a3fb9eb7e4c933ae318ff9b0a5bc9a3ac28e75: Bug 1322235: Part 1 - Add native MatchPattern and MatchGlob bindings. r=billm,aswan
Kris Maglione <maglione.k@gmail.com> - Wed, 24 May 2017 14:57:29 -0700 - rev 410366
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1322235: Part 1 - Add native MatchPattern and MatchGlob bindings. r=billm,aswan Bill, can you please review the binding code, and the general sanity of the platform code. Andrew and zombie, can you please matching algorithms and tests. Change summary: The existing JavaScript matching code works well overall, but it needs to be called a lot, particularly from hot code paths. In most cases, the overhead of the matching code on its own adds up enough to cause a problem. When we have to call out to JavaScript via XPConnect to make a policy decision, it adds up even more. These classes solve both of these problems by a) being very fast, and b) being accessible directly from C++. They are particularly optimized for the common cases where only literal or prefix matches are required, and they take special steps to avoid virtual calls wherever possible, and caching computed URL values so that they can be reused across many match operations without additional overhead. MozReview-Commit-ID: BZzPZDQRnl
8726e36dafe1c875d86b33b5885f6b9e6d1a5a12: Bug 1369276 (part 2) - Convert ProfileEntry::Flags to Kind. r=shu.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Jun 2017 12:46:09 +1000 - rev 410365
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1369276 (part 2) - Convert ProfileEntry::Flags to Kind. r=shu. There are three flags in ProfileEntry::Flags, which suggests there are 2**3 = 8 combinations. But there are only actually 4 valid combinations. This patch converts the three flags to a single "kind" enum, which makes things clearer. Note also that the patch moves the condition at the start of AddPseudoEntry() to its callsite, for consistency with the earlier JS_OSR entry kind check.
70e36d9d546e22b44ec55eb5906987d95bfcbcc7: Bug 1369276 (part 1) - Fix category handling in AddPseudoEntry. r=shu.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 31 May 2017 15:03:55 +1000 - rev 410364
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1369276 (part 1) - Fix category handling in AddPseudoEntry. r=shu. The category handling code at the end of AddPseudoEntry has two problems. - The assertion checks |category| for the IS_CPP_ENTRY flag. This represents a confusion between the entry's |category| and its |flags|. They're both stored in a single uint32_t, but are conceptually different types. So the assertion is vacuously satisfied. Furthermore, there's no clear way to fix the assertion -- it doesn't make sense to check the entry's flags for IS_CPP_ENTRY, because this code can clearly take C++ or JS entries. So the patch just removes the assertion. - The category is compared to zero. This also doesn't make sense, because zero isn't a valid category. The patch removes this comparison.
5dd5d16e708558e464ef335c67defdf41838cea8: Bug 1370102 - Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event; r=kmag
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 30 May 2017 16:38:56 -0400 - rev 410363
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1370102 - Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event; r=kmag
be7ee8326facc899155d9d1c6573f73731921b9b: Bug 1370101 - Make test_windowProxyDeadWrapper.html correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event; r=kmag
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 30 May 2017 00:34:51 -0400 - rev 410362
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1370101 - Make test_windowProxyDeadWrapper.html correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event; r=kmag
1002aa75bf5df4820646ddc76e39752ef2116d34: merge mozilla-central to mozilla-inbound. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sun, 04 Jun 2017 20:11:31 +0200 - rev 410361
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
merge mozilla-central to mozilla-inbound. r=merge a=merge
5e9c3d9dd68e04f11da55fb3a85b99cbebb44dc7: Bug 1369585 - Explicitly identify the row and columns in cell infobar. r=gl
Micah Tigley <tigleym@gmail.com> - Sat, 03 Jun 2017 22:24:24 -0600 - rev 410360
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1369585 - Explicitly identify the row and columns in cell infobar. r=gl MozReview-Commit-ID: F4oKtM3IEbg
22108a33acd5ce6ecbf0ca5f696a01591c5c0ca1: Bug 1367209 part 4 - Use LookupForAdd to avoid an additional hashtable lookup when inserting a new entry. r=jfkthame
Mats Palmgren <mats@mozilla.com> - Sun, 04 Jun 2017 16:45:15 +0200 - rev 410359
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1367209 part 4 - Use LookupForAdd to avoid an additional hashtable lookup when inserting a new entry. r=jfkthame MozReview-Commit-ID: u24jLUvoCJ
1b9d1468f7b4c1eb9b40fb19137f252bb113aff4: Bug 1367209 part 3 - Add a generic frame state bit, NS_FRAME_HAS_CSS_COUNTERS, to indicate that a frame maybe has some counter styles and thus be known by nsCounterManager. r=jfkthame
Mats Palmgren <mats@mozilla.com> - Sun, 04 Jun 2017 16:45:15 +0200 - rev 410358
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1367209 part 3 - Add a generic frame state bit, NS_FRAME_HAS_CSS_COUNTERS, to indicate that a frame maybe has some counter styles and thus be known by nsCounterManager. r=jfkthame If a frame doesn't have that bit then skip mCounterManager.DestroyNodesFor() when the frame is destroyed because it's definitely not known by the CounterManager. MozReview-Commit-ID: Ky3575QvZME
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip