2cc96a86c1a19efe95e15d11cd71b12f51d4dd01: servo: Merge #6380 - Refactor WebGL implementation to move logic inside the DOM interfaces (from emilio:webgl-refactoring); r=jdm
ecoal95 <ecoal95@gmail.com> - Mon, 06 Jul 2015 09:12:59 -0600 - rev 383284
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6380 - Refactor WebGL implementation to move logic inside the DOM interfaces (from emilio:webgl-refactoring); r=jdm This improves the encapsulation and consistency in our WebGL implementation. Also allows to implement new methods such as `getShaderSource()`. It will also allow us to use `delete()` in the destructors of them (note that we will probably want to keep track of them from the context before). Some concerns: **Trait method repetition**: I'm aware that the traits `WebGL{Buffer,Renderbuffer,Framebuffer,Texture}Helpers` are basically the same, but `delete()` and `id()` methods are everywhere. I've thought something like: ```rust pub trait WebGLIdentifiable { type WebGLId; // id is sometimes i32 (see WebGLUniformLocation) fn id(&self) -> Self::WebGLId; } pub trait WebGLBindable { fn bind(&self); } pub trait WebGLDeletable { fn delete(&self); } ``` But I'd want to know your opinion first. **`renderer` repetition**: Thought of moving the field: `renderer: Sender<CanvasMsg>` to `WebGLObject`, but I think it makes it way more complicated to read, and also a bit unnecessary, at least IMO (`WebGLObject` will never interact with the field directly). It would also mean that all `WebGLObject`s should have one, which is true at this moment, but maybe not with WebGL 2, for example. Source-Repo: https://github.com/servo/servo Source-Revision: 0f8095b950dd144497919cfea65a1f154ed3ae9a
2418ce5461e49e5ba02388a33d327e854f33bd0b: servo: Merge #6547 - Borrow the QueueData for WorkQueue::run (from Ms2ger:workqueue-reference); r=pcwalton
Ms2ger <ms2ger@gmail.com> - Mon, 06 Jul 2015 08:29:17 -0600 - rev 383283
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6547 - Borrow the QueueData for WorkQueue::run (from Ms2ger:workqueue-reference); r=pcwalton This allows us to get rid of the raw pointers and unsafe dereferencing in the parallel layout implementation. Source-Repo: https://github.com/servo/servo Source-Revision: a3821bf24094bf5bb2a9553e66b69da3b6430aa5
9863096b28ab7a64f94a8ffe2282548db2c881ec: servo: Merge #6364 - layout: Outline the individual property cascading functions to reduce I-cache footprint (from pcwalton:debloat-cascade); r=SimonSapin
Patrick Walton <pcwalton@mimiga.net> - Mon, 06 Jul 2015 07:45:38 -0600 - rev 383282
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6364 - layout: Outline the individual property cascading functions to reduce I-cache footprint (from pcwalton:debloat-cascade); r=SimonSapin Reduces the size of `properties::cascade` from over 100K of code to under 5K. Due to the improved I-cache utilization, improves ARM scaling on 4 cores by 15%. r? @SimonSapin (feel free to punt to someone else if you like) Source-Repo: https://github.com/servo/servo Source-Revision: 6386addb01dfec4bda38f99e534516ddf5ff77aa
a0ee96a24726350c682301ae6684bbf3c3ab1df0: servo: Merge #6365 - layout: Disable parallel display list building by default (from pcwalton:sequential-display-list-construction); r=larsbergstrom
Patrick Walton <pcwalton@mimiga.net> - Mon, 06 Jul 2015 07:08:58 -0600 - rev 383281
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6365 - layout: Disable parallel display list building by default (from pcwalton:sequential-display-list-construction); r=larsbergstrom I've never see it result in a speedup. Actually, I don't think I've seen it result in anything better than a 50% slowdown. The arithmetic intensity is just too low, at least with the current algorithm. Parallel DL building can still be enabled with a debug flag if the algorithm is improved. r? @metajack Source-Repo: https://github.com/servo/servo Source-Revision: b876a54dce091e161b87340130446597dd864732
57bbafcfd876160d625565df01b6a0bebcb61724: servo: Merge #6505 - Implement crypto.getRandomValues() (from ttaubert:issue/4666-crypto-getRandomValues); r=Ms2ger
Tim Taubert <tim@timtaubert.de> - Sun, 05 Jul 2015 22:16:19 -0600 - rev 383280
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6505 - Implement crypto.getRandomValues() (from ttaubert:issue/4666-crypto-getRandomValues); r=Ms2ger Didn't touch mozjs or rust-mozjs because implementing that in the code generator didn't seem too easy. I'm using the same workaround that the TextDecoder does. Using the OsRng should be the right choice here? As the OS keeps state for us we wouldn't need to have a global rng instance to keep around. Fixes #4666. Source-Repo: https://github.com/servo/servo Source-Revision: c0222628264423a67bf98775be83dcf2f85211ab
679df333834c922092aee5873b457ba60660d6da: servo: Merge #6546 - Remove LayoutChan from LayoutDataWrapper (from michaelwu:slim-layoutdatawrapper); r=Ms2ger
Michael Wu <mwu@mozilla.com> - Sun, 05 Jul 2015 21:39:12 -0600 - rev 383279
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6546 - Remove LayoutChan from LayoutDataWrapper (from michaelwu:slim-layoutdatawrapper); r=Ms2ger Saves 32 bytes in Node. Source-Repo: https://github.com/servo/servo Source-Revision: cc73aad447f0455606a5a6005d31aa55334668a8
fb8a8ebb901b40b96d1237bf6564811b2e4c4cf2: servo: Merge #6557 - Update rust-mozjs (from Ms2ger:update-js); r=jdm
Ms2ger <ms2ger@gmail.com> - Sun, 05 Jul 2015 09:38:20 -0600 - rev 383278
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6557 - Update rust-mozjs (from Ms2ger:update-js); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: db9e29a5f3c3600dcdd5c2b4e5a3e1e0baf917d7
90d96cebbc8f0c1932a02ae3c783da7db13f0dd5: servo: Merge #6556 - Utilize iterators for AttrValue::from_serialized_tokenlist (from frewsxcv:AttrValue-from_serialized_tokenlist); r=Ms2ger
Corey Farwell <coreyf@rwell.org> - Sat, 04 Jul 2015 21:08:11 -0600 - rev 383277
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6556 - Utilize iterators for AttrValue::from_serialized_tokenlist (from frewsxcv:AttrValue-from_serialized_tokenlist); r=Ms2ger Source-Repo: https://github.com/servo/servo Source-Revision: 0fb6604cb37da0ca0f4852328def21100a38fd63
a90222a00bcfb637317d17944fc55aeb158621bd: servo: Merge #6553 - Unit test for util::str::split_html_space_chars (from frewsxcv:split-html-test); r=Ms2ger
Corey Farwell <coreyf@rwell.org> - Sat, 04 Jul 2015 19:59:32 -0600 - rev 383276
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6553 - Unit test for util::str::split_html_space_chars (from frewsxcv:split-html-test); r=Ms2ger I was concerned for a little bit that passing just whitespace to the split_html_space_chars function would result in len > 0, so I wrote this small unit test to make sure it does the right thing. Even though it does do the right thing, I think there's still value in committing the unit test. Source-Repo: https://github.com/servo/servo Source-Revision: d3d4976d8ed7cd7e92a1246513e125d1a6093d2a
dd20d830723d7037efbd59f5934a39908f04f23a: servo: Merge #6552 - Remove some redundant let bindings (from dzbarsky:master); r=Ms2ger
David Zbarsky <dzbarsky@gmail.com> - Sat, 04 Jul 2015 07:34:29 -0600 - rev 383275
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6552 - Remove some redundant let bindings (from dzbarsky:master); r=Ms2ger Source-Repo: https://github.com/servo/servo Source-Revision: 236250c3fc7313346e490ce249083bb94d0dad74
3d20626a6b1f4492da5f1ef0fc3c46870c83e87f: servo: Merge #6551 - Store a LayoutJS<Element> in LayoutElement (from Ms2ger:layoutelement); r=nox
Ms2ger <ms2ger@gmail.com> - Sat, 04 Jul 2015 04:00:29 -0600 - rev 383274
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6551 - Store a LayoutJS<Element> in LayoutElement (from Ms2ger:layoutelement); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 2e1c9785dc5725f809c56b7bafb7a3a68fb1dca0
afa7fa71c8df2b138dd26d1741a922829626a523: servo: Merge #6550 - Fix build warnings (from Ms2ger:warnings); r=larsbergstrom
Ms2ger <ms2ger@gmail.com> - Sat, 04 Jul 2015 01:01:25 -0600 - rev 383273
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6550 - Fix build warnings (from Ms2ger:warnings); r=larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: c7f1716ee1778893004d5210c5945cf1d7839160
c1ef868db9c22dbd2be6f57344c7d708e2d8746a: servo: Merge #6549 - Remove *Cast::from_actual (from Ms2ger:from_actual); r=nox
Ms2ger <ms2ger@gmail.com> - Fri, 03 Jul 2015 22:56:17 -0600 - rev 383272
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6549 - Remove *Cast::from_actual (from Ms2ger:from_actual); r=nox Since JSRef was removed, from_actual duplicates from_ref. Source-Repo: https://github.com/servo/servo Source-Revision: 0298c92670bee90c06f98fac2e8469d1238d1bd4
c6d17f93c9aac06cb87e85685c29cc61bde7078d: servo: Merge #6548 - Upgrade to rustc 1.3.0-dev (f3b97a74a 2015-07-03) (from servo:rustup_2015-07-03); r=nox
Simon Sapin <simon.sapin@exyr.org> - Fri, 03 Jul 2015 21:47:02 -0600 - rev 383271
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6548 - Upgrade to rustc 1.3.0-dev (f3b97a74a 2015-07-03) (from servo:rustup_2015-07-03); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: f5f64dab749d0851ef82be3cdc7fb2bd1cb09956
db8a28198ae7064703aded3c4785cf226878150b: servo: Merge #6545 - Factor out common forward/back navigation code in HTMLIFrameElementMethods (from dzbarsky:master); r=Ms2ger
David Zbarsky <dzbarsky@gmail.com> - Fri, 03 Jul 2015 18:49:37 -0600 - rev 383270
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6545 - Factor out common forward/back navigation code in HTMLIFrameElementMethods (from dzbarsky:master); r=Ms2ger Source-Repo: https://github.com/servo/servo Source-Revision: 02d84a13470271d18198af118d4f25ee45fe6917
bd9a46e6833ba39b19767fdc62db2c9897df1036: servo: Merge #6513 - Remove the data field from WorkQueue (from Ms2ger:workqueue-data); r=pcwalton
Ms2ger <ms2ger@gmail.com> - Fri, 03 Jul 2015 07:22:44 -0600 - rev 383269
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6513 - Remove the data field from WorkQueue (from Ms2ger:workqueue-data); r=pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: d09881b051e01f145bf701d48d6d91167bccbe30
5b40f13f9591631f44cfe14baf9b4b34b6d79fb7: servo: Merge #6504 - Move back to using a labeled break in WorkQueue (from Ms2ger:workqueue-labeled-break); r=pcwalton
Ms2ger <ms2ger@gmail.com> - Fri, 03 Jul 2015 06:39:53 -0600 - rev 383268
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6504 - Move back to using a labeled break in WorkQueue (from Ms2ger:workqueue-labeled-break); r=pcwalton This was changed in 18a2050a64cd6f320cc59cb490a69b0e895f11d3; it appears to work fine now. Source-Repo: https://github.com/servo/servo Source-Revision: 59d3b45b74a22fa807872b78e881991e86f7c6ee
349225962e6ef907eca3000fe86f90222a6d263e: servo: Merge #6538 - Some cleanup in HTMLAnchorElement (from Ms2ger:a-cleanup); r=jdm
Ms2ger <ms2ger@gmail.com> - Thu, 02 Jul 2015 23:32:59 -0600 - rev 383267
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6538 - Some cleanup in HTMLAnchorElement (from Ms2ger:a-cleanup); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: 73b52c095a448116c0f9db23894a0932d0d53484
6df6f8819fbf43fb5b742b48796ced25ef46dac5: servo: Merge #6533 - Check the result of JS_Init (from Ms2ger:init); r=jdm
Ms2ger <ms2ger@gmail.com> - Thu, 02 Jul 2015 08:20:03 -0600 - rev 383266
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6533 - Check the result of JS_Init (from Ms2ger:init); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: eb5fbb6ea26c68fb875da51d57b1c85eeffae43b
212a6ec9f811c904314f20a08f3768c8aa22836b: servo: Merge #6510 - Update Worker location for redirects (from mintern:fix-worker-redirect-location); r=Ms2ger
Brandon Mintern <brandon@mintern.net> - Thu, 02 Jul 2015 03:28:29 -0600 - rev 383265
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #6510 - Update Worker location for redirects (from mintern:fix-worker-redirect-location); r=Ms2ger Fixes #4146 Source-Repo: https://github.com/servo/servo Source-Revision: be9d60664d26e979489fe891b7b11468bb89ba2a
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip