2c40e21dafaa718d667bb2718f0f36f402b67614: Bug 1270011 - Check normalData.windows[0] exists before accessing tab count. r=margaret, a=lizzard
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 01 May 2016 22:11:17 +0200 - rev 332811
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1270011 - Check normalData.windows[0] exists before accessing tab count. r=margaret, a=lizzard There is no window in the normalData when clearing browsing history on quit with tab restore set to "never restore", which breaks the assumption made in the logging function. It also means that in that case, the current session will show up as "Tabs from last time" on next startup despite wanting to clear the history on exit. MozReview-Commit-ID: Ft4jdomopFL
00a32da7e4d6e85fdcf3618fb757d7cd8df4eefb: Bug 1269081 - Only apply Firefox's default styles if the add-on author sets "browser_style" to true in the manifest. r=kmag, a=lizzard
Blake Winton <bwinton@latte.ca> - Mon, 02 May 2016 10:59:36 -0400 - rev 332810
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1269081 - Only apply Firefox's default styles if the add-on author sets "browser_style" to true in the manifest. r=kmag, a=lizzard MozReview-Commit-ID: JjH0sCkh1U7
fb681e961325a5fd7d98c903f16dc024e17e49b5: Bug 1268303 - Better WorkerFeature management in Console API, r=smaug, a=al
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 07 May 2016 07:49:15 +0200 - rev 332809
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1268303 - Better WorkerFeature management in Console API, r=smaug, a=al
d1e8949f9e790141748fe1ceba2a76bc6b9fb72d: Bug 1269832 - Only show base domain for http/https URLs. r=margaret,kats, a=ritu
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 04 May 2016 13:30:48 +0200 - rev 332808
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1269832 - Only show base domain for http/https URLs. r=margaret,kats, a=ritu MozReview-Commit-ID: Dzk6vN2cyVb
8fd6c0a620ca78d14b446a16282895812fb1f511: Bug 1266926 - Move CaptureStreamTrackSource cleanup to Destroy method. r=jesup, a=al
Andreas Pehrson <pehrsons@gmail.com> - Mon, 09 May 2016 11:52:53 +0200 - rev 332807
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1266926 - Move CaptureStreamTrackSource cleanup to Destroy method. r=jesup, a=al
5e345d6d359c93ccb70aeaf6cccb3713f217a3ab: Bug 1266933. Pass image extend mode to prescale and tile drawable on OS X. r=jrmuizel, a=lizzard
Mason Chang <mchang@mozilla.com> - Thu, 05 May 2016 07:59:30 -0700 - rev 332806
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1266933. Pass image extend mode to prescale and tile drawable on OS X. r=jrmuizel, a=lizzard
36e12a7d0ae8166ce03cefc51c93ac3456a12daf: Bug 1266484 - Fix crash in libsystem_kernel.dylib@0x16db6 when using Pinboard bookmarklet. r=gabor, a=lizzard
Haik Aftandilian <haftandilian@mozilla.com> - Mon, 25 Apr 2016 09:33:00 -0400 - rev 332805
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1266484 - Fix crash in libsystem_kernel.dylib@0x16db6 when using Pinboard bookmarklet. r=gabor, a=lizzard
bf290651a401d007f849c1fbd9b246fce41d3b0e: Bug 1259537 - Unbreak libc++ build after bug 1245076. r=glandium, a=lizzard
Jan Beich <jbeich@FreeBSD.org> - Sun, 01 May 2016 09:32:10 +0000 - rev 332804
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1259537 - Unbreak libc++ build after bug 1245076. r=glandium, a=lizzard MozReview-Commit-ID: 31otXvuDu4A
63b7cc21ae7cf57d72b1a3a1b169ba3ea9fc237d: Backed out changeset 537e8f7a4950 (bug 1258450) for crashes.
Michael Comella <michael.l.comella@gmail.com> - Mon, 09 May 2016 16:05:49 -0700 - rev 332803
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Backed out changeset 537e8f7a4950 (bug 1258450) for crashes. MozReview-Commit-ID: AguqO9ce29A
1a31ddc2411f1bf4b9f6766811b5fb4ff3891c27: Bug 1270968 - Build fix. a=bustage
Chris Pearce <cpearce@mozilla.com> - Tue, 10 May 2016 08:44:50 +1200 - rev 332802
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1270968 - Build fix. a=bustage Bug 1268313 renamed NS_NewRunnableMethod to mozilla::NewRunnableMethod, but that hasn't been uplifted, causing this bustage.
95eba1c7da971bc1068e1b307c11310716851e3e: Bug 1267567 - Unit test for non-ASCII AutoConfig files. r=mkaply a=ritu
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 07 May 2016 00:06:33 +0900 - rev 332801
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1267567 - Unit test for non-ASCII AutoConfig files. r=mkaply a=ritu
d2397dcceff47e7a981ec70b4e3337624947f272: Bug 1267567 - Treat string prefs as Unicode when the script encoding is UTF-8. r=mkaply a=ritu
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 07 May 2016 00:06:33 +0900 - rev 332800
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1267567 - Treat string prefs as Unicode when the script encoding is UTF-8. r=mkaply a=ritu
9247694843ecada80021515c747239cc3226c621: Bug 1269412 - In nsWebBrowserPersist::EndDownload set mCompleted = true before issuing the state stop notification r=jld a=ritu
Philip Chee <philip.chee@gmail.com> - Fri, 06 May 2016 03:54:11 +0800 - rev 332799
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1269412 - In nsWebBrowserPersist::EndDownload set mCompleted = true before issuing the state stop notification r=jld a=ritu
36f6b5aa4e050fa70872228ff90858333ae4838a: Bug 1269185 - Prevent crashes in Windows when zip files cannot be read. r=spohl a=ritu
Kirk Steuber <ksteuber@mozilla.com> - Wed, 04 May 2016 12:57:21 -0700 - rev 332798
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1269185 - Prevent crashes in Windows when zip files cannot be read. r=spohl a=ritu MozReview-Commit-ID: 32uEegoKL4J
95a27b2a8a2d95e9b1c47d527b7034a438df1c39: Bug 1269165 - Restore ALSA plugins detection on non-Linux after bug 757637. r=jesup a=ritu
Jan Beich <jbeich@FreeBSD.org> - Sat, 30 Apr 2016 21:52:00 -0400 - rev 332797
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1269165 - Restore ALSA plugins detection on non-Linux after bug 757637. r=jesup a=ritu
bbbcc8fc51fa0b6b58e75c4ec7c15834daddf89b: Bug 1268984 - Prefer to re-use a GMPParent with the requested nodeId rather than clone. r=jesup a=ritu
Chris Pearce <cpearce@mozilla.com> - Thu, 05 May 2016 22:35:44 +1200 - rev 332796
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1268984 - Prefer to re-use a GMPParent with the requested nodeId rather than clone. r=jesup a=ritu If you request a GMPParent with a nodeId, you should get any already running instances with the same nodeId in preference to cloning an existing GMP and assigning it the nodeId. This is ensures that EME GMP actors that are same-origin run in the same GMP instance. The GMP gtests are failing because of the cross-origin checks in GeckoMediaPluginServiceParent::SelectPluginForAPI(). The loop there selects the first GMPParent that can be used from the nodeId passed in. We previously assumed a GMPParent can be used from a nodeId if the GMPParent has the same nodeId, or if it has not loaded its process and it has no nodeId. The problem with assuming that, is if an in-use GMPParent with the target nodeId lies in the GeckoMediaPluginServiceParent::mPlugins list after a GMPParent with no nodeId, we'll end up using the first GMPParent (the one with no nodeId) rather than the one with the target nodeId. The solution is to change GeckoMediaPluginServiceParent::SelectPluginForAPI() so that effectively if we have a target nodeId, we'll select the first GMPParent that has the same nodeId, or we'll clone the first which supported all the requested capabilities/tags. This means when you request a GMPParent with a given nodeId, you'll get the one with the same nodeId (origin) by preference. MozReview-Commit-ID: 4yVnrO8B1Pg
c74d913c3ac872cd9ceda1d3608f6aec00e08a22: Bug 1268984 - Store GMPStorage on GMPServiceParent so that it persists inside the same PB session. r=gerald a=ritu
Chris Pearce <cpearce@mozilla.com> - Thu, 05 May 2016 11:41:33 +1200 - rev 332795
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1268984 - Store GMPStorage on GMPServiceParent so that it persists inside the same PB session. r=gerald a=ritu Prior to this change, we'd store the GMPStorage records for private browsing sessions in the GMPStorageParent. The problem with this is that they only have a lifespan matching their corresponding GMPParent. This means that if a GMP stores something in a PB session, and the GMP is shutdown and then re-created, we are likely to loose the stored data. This could mean that the PB session gets results it doesn't expect, and thus expose a way for PB mode to be detected. MozReview-Commit-ID: 1OMD0LvidYs
eb0ba9144f456570389203b8882e7bff3b452f7e: Bug 1268984 - Ensure GMPs are re-inserted in GMPServiceParent::mPlugins in the same order in ReAddOnGMPThread. r=gerald,jesup a=ritu
Chris Pearce <cpearce@mozilla.com> - Wed, 04 May 2016 13:57:20 +1200 - rev 332794
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1268984 - Ensure GMPs are re-inserted in GMPServiceParent::mPlugins in the same order in ReAddOnGMPThread. r=gerald,jesup a=ritu The GMP which GeckoMediaPluginServiceParent::FindPluginForAPIFrom() returns depends on the order in which GMPs lie in GMPServiceParent::mPlugins. However when we shutdown a GMPParent we remove and then re-append the GMPParent to mPlugins. This means the order in which GMPs lie in the list changes. So when WebRTC requests an H.264 decoder, the first time it will get OpenH264, since that's first in the list. But once we dispose of that decoder, its GMPParent will be cloned and the clone will be appended to the end of the list. This means the next time WebRTC requests a decoder, it'll get whatever was next in the list. This could be the Adobe GMP, which seems to be able to handle whatever WebRTC is putting into it. However, if you do this enough times, you'll get the Widevine CDM, which can't handle whatever WebRTC is putting into it. So a quick hack to fix this is in ReAddOnGMPThread is to re-insert the clone of the GMP into the slot in mPlugins that the original occupied. Then WebRTC will always get OpenH264 whenever it requests for an H.264 decoder, as the order of the GMPParents in mPlugins won't change. MozReview-Commit-ID: Ii4AMqDqAo9
28836236ca2ff8720b178ed728643423788d3deb: Bug 1266286 - Ensure crash reports work for GMP used by EME code. r=mconley a=ritu
Chris Pearce <cpearce@mozilla.com> - Wed, 04 May 2016 20:32:00 -0400 - rev 332793
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1266286 - Ensure crash reports work for GMP used by EME code. r=mconley a=ritu Crash reporting for GMPs being used from the EME call site are not generating crash reports because they depend on the MediaKeys object calling GMPService::AddPluginCrashHandler() to associate a window to which the PluginCrashedEvent is fired. This doesn't work with e10s enabled because the GMPParent which causes the plugin crash handlers to run is in the chrome process, but the MediaKeys which adds the handler is in the child process. So the crash handler is on the GMPServiceChild, but we only run the crash handlers that were added to the GMPServiceParent in the chrome/parent process. The solution is to broadcast a message from the chrome process to all the content processes when a GMP has crashed that causes the GMPServiceChild to also run its crash handlers. MozReview-Commit-ID: 8Lek16G9ZGb
9e517a5f0b04812c571945218a0a34716f746468: Bug 1270968 - Add mechanism to clear GMP storage when its version changes. r=gerald a=ritu
Chris Pearce <cpearce@mozilla.com> - Sat, 07 May 2016 09:19:15 +1200 - rev 332792
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1270968 - Add mechanism to clear GMP storage when its version changes. r=gerald a=ritu In bug 1264497 we discovered that Netflix was broken because we'd made a change to not send the Adobe GMP the device bound nodeId, which it stored in GMP storage. When the GMP was comparing the nodeId it had stored against what it was passed (nothing) the comparison was failing. Users could have worked around this problem by clearing their GMP storage, whereupon the Adobe GMP will have stored "nothing" as its nodeId. When bug 1264497 was fixed, users who'd cleared their storage will see Netflix fail again, as their stored nodeId of "nothing" will again not match what we pass in. So to fix Netflix for these users, we need to clear GMP storage. This is another instance of a more general problem that we have occasionally encountered, namely that sometimes GMP storage becomes incompatible, and we need to clear it. Having a general mechanism that we can use to clear storage remotely will be helpful, so this patch adds one, and triggers it to fire. This mechanism is pref controlled, so that we can issue a hotfix if necessary to clear GMP storage. MozReview-Commit-ID: GzSyBj0P2JG
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip