2bbdeafb0a5813426f9dbe97f4a42f57fde89770: Bug 1460917 - Fonts not displaying with FontExplorer X fonts in Firefox 60. r=handyman, a=RyanVM
Haik Aftandilian <haftandilian@mozilla.com> - Mon, 14 May 2018 16:04:55 -0700 - rev 470828
Push 9235 by ryanvm@gmail.com at Thu, 17 May 2018 13:49:58 +0000
Bug 1460917 - Fonts not displaying with FontExplorer X fonts in Firefox 60. r=handyman, a=RyanVM Add back font whitelist rules removed by the fix for bug 1393259 to workaround font sandbox extensions not being issued automatically on OS X 10.11 and earlier. MozReview-Commit-ID: 2hT0BzN3Ggq
f23b9482597f30e6a252592b1aceaa1f083d0f31: Bug 1452361 - Don't reset to default permissions for cookies in page info. r=nhnt11, a=RyanVM
Johann Hofmann <jhofmann@mozilla.com> - Wed, 09 May 2018 15:39:26 +0200 - rev 470827
Push 9235 by ryanvm@gmail.com at Thu, 17 May 2018 13:49:58 +0000
Bug 1452361 - Don't reset to default permissions for cookies in page info. r=nhnt11, a=RyanVM This commit makes the page info window treat cookie permissions a little differently, to reflect that the "default" value for cookies is a combination of two prefs that doesn't strictly map onto the ALLOW/SESSION/DENY system of permissions. I also added some more general pageinfo permissions tests. MozReview-Commit-ID: 80vd61Rv867
e303321bec189ad04d881680cdf19f3973ab6e2a: Bug 1461093 - Remove vertical padding from #titlebar-buttonbox. r=stransky, a=RyanVM
Dão Gottwald <dao@mozilla.com> - Sat, 12 May 2018 13:23:05 +0200 - rev 470826
Push 9235 by ryanvm@gmail.com at Thu, 17 May 2018 13:49:58 +0000
Bug 1461093 - Remove vertical padding from #titlebar-buttonbox. r=stransky, a=RyanVM MozReview-Commit-ID: 8ptkqHA8wCZ
3b349484f1de921c889850a70f85bbe220893e33: Bug 1459162 - Update dimensions early in ClearTarget. r=lsalzman a=abillings
Jonathan Kew <jkew@mozilla.com> - Thu, 17 May 2018 09:49:58 +0100 - rev 470825
Push 9234 by jkew@mozilla.com at Thu, 17 May 2018 08:54:31 +0000
Bug 1459162 - Update dimensions early in ClearTarget. r=lsalzman a=abillings
233d36dfd5c9071593c372212c56da1cfc15c6bf: Bug 1459997 - Add much more rigorous assertions for retained-dl assumptions. r=miko, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 01 May 2018 11:56:40 -0400 - rev 470824
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1459997 - Add much more rigorous assertions for retained-dl assumptions. r=miko, a=RyanVM This adds an assertion checking for duplicate items whenever we create an item, and when we merge an item into the final list. I had to disable tracking for the anonymous inner list for nsDisplayPerspective and nsDisplayTransform (and manually forward RemoveFrame to them), as well as skipping the assertion for multi-page (since we can end up duplicating wrap lists, but isn't a problem, since we don't retain these). MozReview-Commit-ID: 4n6rx9bQNan
457462d0bb3d797f68a35ead733bb8fdbb1dd75d: Bug 1460526 - Don't attempt to do a partial rebuild when a sublist DAG gets too complex, always rebuild the whole display list. r=miko, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 15 May 2018 14:21:05 +1200 - rev 470823
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1460526 - Don't attempt to do a partial rebuild when a sublist DAG gets too complex, always rebuild the whole display list. r=miko, a=RyanVM MozReview-Commit-ID: 5u3sBSepgJa
909e56123552926e7b3b7f2431604a849d51c36c: Bug 1461812 - Make sure we fully cleanup any partially constructed display lists when returning a failure from AttemptPartialUpdate. r=miko, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 16 May 2018 12:55:08 +1200 - rev 470822
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1461812 - Make sure we fully cleanup any partially constructed display lists when returning a failure from AttemptPartialUpdate. r=miko, a=RyanVM MozReview-Commit-ID: DJBG6UFcoyR
2932a4b5f7e77885014ce42d09ae14e3096f37b6: Bug 1461231 - Don't omit deleted items when constructing the DAG, since we need to record that we made a modification during MergeDisplayLists. r=miko, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 15 May 2018 14:20:59 +1200 - rev 470821
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1461231 - Don't omit deleted items when constructing the DAG, since we need to record that we made a modification during MergeDisplayLists. r=miko, a=RyanVM We can unconditionally delete the item though, and just put a placeholder entry into the DAG. MozReview-Commit-ID: 7a2UnaByIZu
a5b962b8bb3d9a9301430bc47ce975e5279b2043: Bug 1459441 - Make sure we build the full display list when we have blend containers in order to get the correct sorting for them. r=mstange, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 10 May 2018 11:39:12 +1200 - rev 470820
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1459441 - Make sure we build the full display list when we have blend containers in order to get the correct sorting for them. r=mstange, a=RyanVM MozReview-Commit-ID: ECTU7enMb1r
064b3540e831abdb746ecb36f50c7d8cc01762d0: Bug 1452464. r=miko, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 10 May 2018 16:34:25 +1200 - rev 470819
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1452464. r=miko, a=RyanVM
1d11b6bedc3057a1cfea8762d17874b6567c836b: Bug 1453541 - Part 3: Add reftests. r=mstange, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 15 Apr 2018 16:38:45 +1200 - rev 470818
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1453541 - Part 3: Add reftests. r=mstange, a=RyanVM MozReview-Commit-ID: 95DOq6UBUnq
35c4b04bb305f9f6cdf9c58cc6e3e5ab4ca4ab08: Bug 1453541 - Part 2: Look for Out Of Flow frames with modified ancestors during ProcessFrame instead of during display list building. r=mstange, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 15 Apr 2018 16:38:45 +1200 - rev 470817
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1453541 - Part 2: Look for Out Of Flow frames with modified ancestors during ProcessFrame instead of during display list building. r=mstange, a=RyanVM MozReview-Commit-ID: KsgrFqr2gVN
f13fb5d37547d5e9d870bf92557f18354446883f: Bug 1453541 - Part 1: Move more code into ProcessFrame so that we can call it from multiple places. r=mstange, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 15 Apr 2018 16:38:44 +1200 - rev 470816
Push 9233 by ryanvm@gmail.com at Thu, 17 May 2018 01:26:03 +0000
Bug 1453541 - Part 1: Move more code into ProcessFrame so that we can call it from multiple places. r=mstange, a=RyanVM MozReview-Commit-ID: AOXPgteSgTL
ea0bb21de30467e052dbc8913e6571aae86d241e: Bug 1455462 - Part 6. Add test of confirming the position of 'all menu' popup. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:19:00 -0400 - rev 470815
Push 9232 by ryanvm@gmail.com at Thu, 17 May 2018 00:06:15 +0000
Bug 1455462 - Part 6. Add test of confirming the position of 'all menu' popup. r=jdescottes, a=RyanVM The accessing all menu button will be shown to the inspector, so this test will use inspector's this button. This button didn't have an id, so this patch will add id for testing. MozReview-Commit-ID: 2xFXYKwpQoe
abd62e896138d08e0fcf69542a0b3dec1b2cf11a: Bug 1455462 - Part 5. Add toolbox's menu position test. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:19:00 -0400 - rev 470814
Push 9232 by ryanvm@gmail.com at Thu, 17 May 2018 00:06:15 +0000
Bug 1455462 - Part 5. Add toolbox's menu position test. r=jdescottes, a=RyanVM This test will check that popup menu of toolbox will be displayed under the menu button. This test tolerates an error since some platform (like macOS) will add the offset value. (i.e. eIntID_ContextMenuOffsetHorizontal and eIntID_ContextMenuOffsetVertical) MozReview-Commit-ID: 5TaM5JiNhdk
181056a15e4ba770b13220a0547e88fc7e69dbf9: Bug 1455462 - Part 4. Use the async_task in devtool's zoom test. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:19:00 -0400 - rev 470813
Push 9232 by ryanvm@gmail.com at Thu, 17 May 2018 00:06:15 +0000
Bug 1455462 - Part 4. Use the async_task in devtool's zoom test. r=jdescottes, a=RyanVM This patch will change test to use the async_task before touching this tests and use the first decimal place when checking a result.
fa0085fa3c49f482d5734aa8800508a5dd3615a1: Bug 1455462 - Part 3. Use zoom value when showing popup menu. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:18:00 -0400 - rev 470812
Push 9232 by ryanvm@gmail.com at Thu, 17 May 2018 00:06:15 +0000
Bug 1455462 - Part 3. Use zoom value when showing popup menu. r=jdescottes, a=RyanVM The openPopupAtScreen() use the zoomed css coordinate value as position value, devtools's caller of this function use css pixel value without zoom. So position of popup will missaligned if zooming out/in the devtool panel.
69dec209ab576d4c6af7fe85b3fa16cca495a89a: Bug 1455462 - Part 2. Use the rounded zoom value of devtool panel. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:17:00 -0400 - rev 470811
Push 9232 by ryanvm@gmail.com at Thu, 17 May 2018 00:06:15 +0000
Bug 1455462 - Part 2. Use the rounded zoom value of devtool panel. r=jdescottes, a=RyanVM This patch will use rounded zoom value of dev tool panel. This changes will ensure the zoom value test.
d234aa23f84f8c13a301c95787c06f60a4ed8ba0: Bug 1455462 - Part 1. Use the toolbox.zoomIn3.key shortcut. r=ochameau, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:17:00 -0400 - rev 470810
Push 9232 by ryanvm@gmail.com at Thu, 17 May 2018 00:06:15 +0000
Bug 1455462 - Part 1. Use the toolbox.zoomIn3.key shortcut. r=ochameau, a=RyanVM This key will empty string, so we don't use this key now. But we might use this key in the future.
594d4ff3b55bca69fedc366b0573bf17e204f118: Bug 1460767 - Return device ineligible when appropriate for U2F. r=ttaubert, a=RyanVM
J.C. Jones <jjones@mozilla.com> - Thu, 10 May 2018 16:36:18 -0700 - rev 470809
Push 9232 by ryanvm@gmail.com at Thu, 17 May 2018 00:06:15 +0000
Bug 1460767 - Return device ineligible when appropriate for U2F. r=ttaubert, a=RyanVM Summary: FIDO U2F's specification says that when the wrong security key responds to a signature, or when an already-registered key exists, that the UA should return error code 4, DEVICE_INELIGIBLE. We used to do that, but adjusted some things for WebAuthn and now we don't. This changes the soft token to return that at the appropriate times, and updates the expectations of U2F.cpp that it should use InvalidStateError as the signal to reutrn DEVICE_INELIGIBLE. Also, note that WebAuthn's specification says that if any authenticator returns "InvalidStateError" that it should be propagated, as it indicates that the authenticator obtained user consent and failed to complete its job [1]. This change to the Soft Token affects the WebAuthn tests, but in a good way. Reading the WebAuthn spec, we should not be returning NotAllowedError when there is consent from the user via the token (which the softtoken always deliveres). As such, this adjusts the affected WebAuthn tests, and adds a couple useful checks to test_webauthn_get_assertion.html for future purposes. [1] https://w3c.github.io/webauthn/#createCredential section 5.1.3 "Create a new credential", Step 20, Note 2: "If any authenticator returns an error status equivalent to "InvalidStateError"..." Test Plan: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2fc930f7fc8eea69b1ebc96748fe95e150a92a4 Reviewers: ttaubert Bug #: 1460767 Differential Revision: https://phabricator.services.mozilla.com/D1269
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip