2b2606848e3b999736c7550db2ec68cc8af25be3: servo: Merge #18395 - Use a 1-element smallvec for selector lists (from jdm:selector-smallvec); r=SimonSapin
Josh Matthews <josh@joshmatthews.net> - Wed, 06 Sep 2017 15:33:20 -0500 - rev 428737
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18395 - Use a 1-element smallvec for selector lists (from jdm:selector-smallvec); r=SimonSapin Profiling shows this reducing parsing time by a few milliseconds on the tp6 facebook case. The gtest benchmark with the same concatenated stylesheets also shows a significant improvement. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: 5e321cadf3308d21c4bc7de5061c5fc08670c18a
252f4499d3725ced8761b96c44cc6edd5e3b74ef: Bug 1382440 - Fix CPUUsageWatcher on OSX and Linux r=froydnj
Doug Thayer <dothayer@mozilla.com> - Mon, 28 Aug 2017 14:00:22 -0700 - rev 428736
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1382440 - Fix CPUUsageWatcher on OSX and Linux r=froydnj Properly enclose all relevant details of CPUUsageWatcher in ifdefs which control whether it should be active or not. Additionally, apparently clock_gettime is not defined on OSX prior to 10.12, so this is failing to compile for OSX on the build server, but not locally. However, clock_get_time and getrusage should cover our use cases sufficiently. MozReview-Commit-ID: Ffi6yXLb9gO
b84af3674b4968066d8a41e3670ea0f57bce1381: Bug 1382440 - Watch CPU usage in BHR r=froydnj
Doug Thayer <dothayer@mozilla.com> - Mon, 24 Jul 2017 13:46:09 -0700 - rev 428735
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1382440 - Watch CPU usage in BHR r=froydnj We would like to be able to see if a given hang in BHR occurred under high CPU load, as this is an indication that the hang is of less use to us, since it's likely that the external CPU use is more responsible for it. The way this works is fairly simple. We get the system CPU usage on a scale from 0 to 1, and we get the current process's CPU usage, also on a scale from 0 to 1, and we subtract the latter from the former. We then compare this value to a threshold, which is 1 - (1 / p), where p is the number of (virtual) cores on the machine. This threshold might need to be tuned, so that we require an entire physical core in order to not annotate the hang, but for now it seemed the most reasonable line in the sand. I should note that this considers CPU usage in child or parent processes as external. While we are responsible for that CPU usage, it still indicates that the stack we receive from BHR is of little value to us, since the source of the actual hang is external to that stack. MozReview-Commit-ID: JkG53zq1MdY
bc13c43f67712786325bdea324246bea41a0b076: Backed out 2 changesets (bug 1396723) for build failures in TestDoublyLinkedList.cpp a=backout
Wes Kocher <wkocher@mozilla.com> - Wed, 06 Sep 2017 14:30:41 -0700 - rev 428734
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out 2 changesets (bug 1396723) for build failures in TestDoublyLinkedList.cpp a=backout Backed out changeset 1c0f9d069ade (bug 1396723) Backed out changeset 6ca94a450b81 (bug 1396723) MozReview-Commit-ID: 2w3WTvhpg6J
a5aa81a626da9e7cf14f6600ee8ac0ed9b6cee1f: Bug 1397460 - Don't throw for a failure in cpows_child.js. r=billm
Andrew McCreight <continuation@gmail.com> - Wed, 06 Sep 2017 13:45:22 -0700 - rev 428733
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1397460 - Don't throw for a failure in cpows_child.js. r=billm When ok() is passed false, we send a message to the parent, which will cause the test to fail. Throwing in this helper in the child just makes the test hang for a while. MozReview-Commit-ID: 4gwBACPYfDO
ad5c7dbaa4d6c2f31c3b5a89c159f781a2f92902: Bug 1387130 - Use original tabstrip scrolling behaviour when using scrollbuttons. r=dao
Mike Conley <mconley@mozilla.com> - Wed, 06 Sep 2017 13:28:48 -0400 - rev 428732
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1387130 - Use original tabstrip scrolling behaviour when using scrollbuttons. r=dao In bug 1356705, we switched scrollbox to use CSS smooth scroll when the scrollbox is configured to scroll smoothly. This caused the tab strip to scroll with a "pulse" when using the arrow scrollbuttons. This is because we scroll by a single tab each time, as opposed to scrolling by pixels. This reverts part of bug 1356705 so that we use instant scrolling instead of smooth scrolling in the scrollbuttons case, which returns the original behaviour of the strip without the pulse. MozReview-Commit-ID: D8QQ8kQ7AjM
1c0f9d069aded626bdd92b80996470ea778c8d9d: Bug 1396723 - Use DoublyLinkedList in mozjemalloc. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Sat, 02 Sep 2017 08:55:42 +0900 - rev 428731
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1396723 - Use DoublyLinkedList in mozjemalloc. r=froydnj Mozjemalloc uses its own doubly linked list, which, being inherited from C code, doesn't do much type checking, and, in practice, is rather similar to DoublyLinkedList, so use the latter instead.
6ca94a450b810dce5cbb82b2fa13f3a34630a27b: Bug 1396723 - Simplify the trait users of DoublyLinkedList need to define. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Sat, 02 Sep 2017 08:09:58 +0900 - rev 428730
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1396723 - Simplify the trait users of DoublyLinkedList need to define. r=froydnj While the flexibility of the current trait is nice, it's actually not used to its fullest anywhere, and is boilerplate-y. While it is useful to be able to put the links anywhere, there's not much usefulness from being able to split mNext and mPrev. So instead of a trait that allows to get/set mNext and mPrev independently, we just use a trait that tells how to get a reference to a DoublyLinkedListElement from a list element itself.
74131a35a149450b24ca17d4bde05abee558a99f: Bug 1395729 - Disable frame merging for nsTextFrame. r=mattwoodrow
Alexis Beingessner <a.beingessner@gmail.com> - Wed, 06 Sep 2017 13:49:31 -0400 - rev 428729
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1395729 - Disable frame merging for nsTextFrame. r=mattwoodrow MozReview-Commit-ID: C0kq5IYgUMG
6169c1d97aab3ef1fcad843619916040fe698e96: Backed out changeset 80e9cd4126b4 (bug 1397052) for adding a hazard to the build a=backout
Wes Kocher <wkocher@mozilla.com> - Wed, 06 Sep 2017 13:54:07 -0700 - rev 428728
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out changeset 80e9cd4126b4 (bug 1397052) for adding a hazard to the build a=backout MozReview-Commit-ID: I5ZLNHEfj1j
9b0cf253ad1f40a5fd284524a38c4976100abfcc: Bug 1397440 - Added a very useful comment r=rillian
Navid <nmehregani@mozilla.com> - Wed, 06 Sep 2017 16:36:22 -0400 - rev 428727
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1397440 - Added a very useful comment r=rillian This is a practice commit to clarify what arguments we're accepting. MozReview-Commit-ID: 2qQbNAYzGwr
60a28a7012ede9f22b45174c8b730a89c640636b: Backed out changeset 3adbca67c67a (bug 1386384) for failures in browser_webconsole_check_stubs_css_message.js a=backout
Wes Kocher <wkocher@mozilla.com> - Wed, 06 Sep 2017 13:47:13 -0700 - rev 428726
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out changeset 3adbca67c67a (bug 1386384) for failures in browser_webconsole_check_stubs_css_message.js a=backout MozReview-Commit-ID: KcVljvaTReX
3f4037fca66795fda968e20fb2b164320f5a357b: servo: Merge #18396 - Reduce duplication in generated ServoComputedData::to_declaration_block (from jdm:codesize); r=emilio
Josh Matthews <josh@joshmatthews.net> - Wed, 06 Sep 2017 13:44:30 -0500 - rev 428725
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18396 - Reduce duplication in generated ServoComputedData::to_declaration_block (from jdm:codesize); r=emilio This reduces the size of the code in libXUL by 23.4k according to bloaty. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors Source-Repo: https://github.com/servo/servo Source-Revision: af587e5f84cabaa9fd500438adb1d24218b898e2
53286dcc59e9455e53222cc49ae13883982d6224: Bug 1390455 - regression test for CSS rule columns; r=gl,jryans
Tom Tromey <tom@tromey.com> - Tue, 05 Sep 2017 11:39:45 -0600 - rev 428724
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1390455 - regression test for CSS rule columns; r=gl,jryans This adds an integration test for the CSS rule column issue from bug 1390455. The fix was landed in upstream rust-cssparser. MozReview-Commit-ID: 34rLhe3BCqx
f9c03c26c8763e78a2c70f1afc6cfb0fc92ec493: Backed out 7 changesets (bug 1364364) for failures in test_multi_sharedWorker_lifetimes.html a=backout
Wes Kocher <wkocher@mozilla.com> - Wed, 06 Sep 2017 13:07:13 -0700 - rev 428723
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out 7 changesets (bug 1364364) for failures in test_multi_sharedWorker_lifetimes.html a=backout Backed out changeset 6298563c1a81 (bug 1364364) Backed out changeset 285633e277cb (bug 1364364) Backed out changeset 6abd3298188a (bug 1364364) Backed out changeset 6a0ec9eff8c3 (bug 1364364) Backed out changeset f23aa9861e9b (bug 1364364) Backed out changeset 5d6bf02b495a (bug 1364364) Backed out changeset c9420f4e27f7 (bug 1364364) MozReview-Commit-ID: IAFeH325T14
492ea790f0493e82e754f18eb2b8cde3ea8946f3: Bug 1396600 - Make some efforts to lazy load properties-db. r=tromey
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 06 Sep 2017 18:54:07 +0200 - rev 428722
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1396600 - Make some efforts to lazy load properties-db. r=tromey MozReview-Commit-ID: LGgVb5kxN7X
45084f5718b924ffcbd6a791cf3607546c47befb: Bug 1386900 - Add test for parsing invalid filter values. r=xidorn
Josh Mattheus <josh@josmatthews.net> - Wed, 06 Sep 2017 21:25:14 +0200 - rev 428721
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386900 - Add test for parsing invalid filter values. r=xidorn MozReview-Commit-ID: FxbyxXRGmBB
3adbca67c67a33c46b14256b879adfdc7b207909: Bug 1386384 - Update DevTools CSS stubs for Stylo. r=bgrins
J. Ryan Stinnett <jryans@gmail.com> - Wed, 06 Sep 2017 12:34:57 -0500 - rev 428720
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386384 - Update DevTools CSS stubs for Stylo. r=bgrins Two specific changes have occurred with Stylo: * `lineText` is no longer set because it caused performance regressions to compute it and it is currently unused by DevTools. * `columnNumber` is computed differently with Stylo. It's currently the beginning of property, instead of the end. Bug 1378861 is filed for future improvements to this info. MozReview-Commit-ID: 5vTdjNbuhXe
fc91951971ecb71886540056d630a468a5e04635: Bug 1396282 - Add query for getting Highlights (recent bookmarks and recent history with metadata). r=mak
Ed Lee <edilee@mozilla.com> - Sat, 02 Sep 2017 13:15:04 -0700 - rev 428719
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1396282 - Add query for getting Highlights (recent bookmarks and recent history with metadata). r=mak Adds index to moz_bookmarks.dateAdded for use by Highlights query for recent bookmarks. MozReview-Commit-ID: 7Gs8H0kUij2
73c7371abb7f25f819ec26438265d625fe6e5a7a: Bug 1389125 - Refactor ActivityStreamProvider in preparation for Highlights. r=ursula
Ed Lee <edilee@mozilla.com> - Sat, 02 Sep 2017 13:13:52 -0700 - rev 428718
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1389125 - Refactor ActivityStreamProvider in preparation for Highlights. r=ursula Add helpers for shared adjusting limit, bookmarkGuid sub-SELECT, WHERE and params. More efficiently select https and correctly select bookmarks. Remove _addETLD, getHistorySize and getBookmarksSize. Allow for activity stream caller to customize more options. MozReview-Commit-ID: Lj9AhoFJar
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip