1f1eec6abd9b1a33186fd463ba1406adb7e1c233: Bug 1507032 - Work around bug in wayland (< 1.12) headers. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 22:48:26 +0000 - rev 502871
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507032 - Work around bug in wayland (< 1.12) headers. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D11837
e762fce85daa2b0399f443c4644c6e61a11b1eb3: Bug 1507152 - add fuzzy-if to transforms-1.html to support refreshed win10 image. r=mattwoodrow
Joel Maher <jmaher@mozilla.com> - Wed, 14 Nov 2018 22:43:15 +0000 - rev 502870
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507152 - add fuzzy-if to transforms-1.html to support refreshed win10 image. r=mattwoodrow add fuzzy-if to transforms-1.html to support refreshed win10 image Differential Revision: https://phabricator.services.mozilla.com/D11894
e96d9b255d52bb341617eb34a6f2f8996b7a0033: Bug 1506734 - Allow paths and distribution directory for certificates. r=Felipe
Michael Kaply <mozilla@kaply.com> - Wed, 14 Nov 2018 21:47:22 +0000 - rev 502869
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506734 - Allow paths and distribution directory for certificates. r=Felipe Differential Revision: https://phabricator.services.mozilla.com/D11707
a4b64b6bd26b0a5091f545c9389a8dca1e0641cf: Bug 1504247 - Define a high-resolution page load time histogram r=dao,chutten
Tim D. Smith <tdsmith@mozilla.com> - Wed, 14 Nov 2018 21:37:51 +0000 - rev 502868
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1504247 - Define a high-resolution page load time histogram r=dao,chutten The FX_PAGE_LOAD_MS histogram, implemented in Bug 790213, measures the time it takes Firefox to load a page's static content. Unfortunately, it uses only 20 buckets to cover a 10,000ms range, so resolution is quite poor. The modal bucket is 860ms wide. There is at least anecdotal evidence that increasing page load times by increments as small as 100 ms can alter user behavior, so much better resolution is required to have confidence in changes we expect to alter page load times. Also fixes Bug 1364957. Differential Revision: https://phabricator.services.mozilla.com/D11198
daffe63f1a1f313446c7f4c29e24de04f4ed1062: Bug 1503756 - Change name of media device; r=achronop
Gregory Szorc <gps@mozilla.com> - Wed, 14 Nov 2018 20:02:57 +0000 - rev 502867
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1503756 - Change name of media device; r=achronop Regenerating the ubuntu1604-test Docker image pulls in a new package version that changes the name of a media device. This media device name is currently hard coded in the mochitest test harness. This commit makes a change to force regeneration of the Docker image and updates the hardcoded device name to reflect the new version. Differential Revision: https://phabricator.services.mozilla.com/D11927
aeea4bb2f0f7b78efadec21a2c916d8e54b844e4: Bug 1428361 - remove some 'on by default' permissions from the macOS plugin sandbox; r=haik
Alex Gaynor <agaynor@mozilla.com> - Wed, 14 Nov 2018 16:46:05 +0000 - rev 502866
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1428361 - remove some 'on by default' permissions from the macOS plugin sandbox; r=haik Differential Revision: https://phabricator.services.mozilla.com/D11892
9728b79f2ff41f879452ab78e565896f3de431b8: Bug 1507241 - fixing svg icon for Learn More icon. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 14 Nov 2018 19:14:51 +0000 - rev 502865
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507241 - fixing svg icon for Learn More icon. r=gl MozReview-Commit-ID: 6MPdICcrQ3C Differential Revision: https://phabricator.services.mozilla.com/D11918
43251725e5db3e6610a04c0c7fd492e25b175b5c: Bug 1507154 - disable grid-placement-auto-implicit-001.html on win10. r=mats
Joel Maher <jmaher@mozilla.com> - Wed, 14 Nov 2018 19:11:00 +0000 - rev 502864
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507154 - disable grid-placement-auto-implicit-001.html on win10. r=mats disable grid-placement-auto-implicit-001.html on win10 Differential Revision: https://phabricator.services.mozilla.com/D11895
a7df15c51806e92f48a3ce5f1b8ce80eb52f707f: Bug 1500467 - Mark stack labels for JS built-ins as RELEVANT_FOR_JS. r=njn
Markus Stange <mstange@themasta.com> - Wed, 14 Nov 2018 18:55:38 +0000 - rev 502863
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500467 - Mark stack labels for JS built-ins as RELEVANT_FOR_JS. r=njn Depends on D9302 Differential Revision: https://phabricator.services.mozilla.com/D11333
74eb2570702555623f1367440f1e5b14a8ab925e: Bug 1500467 - Mark AutoEntryScript label frames as RELEVANT_FOR_JS. r=njn
Markus Stange <mstange@themasta.com> - Wed, 14 Nov 2018 18:55:01 +0000 - rev 502862
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500467 - Mark AutoEntryScript label frames as RELEVANT_FOR_JS. r=njn Depends on D9301 Differential Revision: https://phabricator.services.mozilla.com/D9302
26a850e26e27fb333707128594c41ee01c6a9152: Bug 1500467 - Mark WebIDL profiler label frames as RELEVANT_FOR_JS. r=njn
Markus Stange <mstange@themasta.com> - Wed, 14 Nov 2018 18:54:59 +0000 - rev 502861
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500467 - Mark WebIDL profiler label frames as RELEVANT_FOR_JS. r=njn Depends on D9300 Differential Revision: https://phabricator.services.mozilla.com/D9301
9601c8af6d8d4d803581eb21ab6d0ae12a31ad59: Bug 1500467 - Add RELEVANT_FOR_JS flag and update profile format with an extra relevantForJS column in the stack table. r=njn
Markus Stange <mstange@themasta.com> - Wed, 14 Nov 2018 18:52:29 +0000 - rev 502860
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500467 - Add RELEVANT_FOR_JS flag and update profile format with an extra relevantForJS column in the stack table. r=njn Differential Revision: https://phabricator.services.mozilla.com/D9300
716676dbfa6feb38e5137db028051c61f965b200: Bug 1506759: remove `try-except` block which swallows `OSError` r=ted
Connor Sheehan <sheehan@mozilla.com> - Wed, 14 Nov 2018 16:33:22 +0000 - rev 502859
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506759: remove `try-except` block which swallows `OSError` r=ted We have a few bugs filed as intermittent failures all relating to an `AssertionError` on the return value of this block, which seems to have a relevant value when `OSError` is thrown. Removing this will not fix the problem but will at least let us see the true cause of the failure for debugging and stabilization. Differential Revision: https://phabricator.services.mozilla.com/D11884
664ffc33dd3a53e8c5a13f7ac0eac3fc5b2931ec: Bug 1507161 - adjust fuzzy-if statements for win10 tests that are failing on new windows10 ami image. r=ahal
Joel Maher <jmaher@mozilla.com> - Wed, 14 Nov 2018 18:37:30 +0000 - rev 502858
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507161 - adjust fuzzy-if statements for win10 tests that are failing on new windows10 ami image. r=ahal adjust fuzzy-if statements for win10 tests that are fialing on new windows 10 ami image Differential Revision: https://phabricator.services.mozilla.com/D11914
fca9442066f5a7afb6ae5dc1a051c3f43ba2c33a: Bug 1496503 - Install the rust panic hook early. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 22:35:35 +0000 - rev 502857
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1496503 - Install the rust panic hook early. r=froydnj Previously, our panic hook was only really useful when the crash reporter is used, because all it did apart from calling rust's default panic handler was to keep a pointer to the panic message for the crash reporter. Now that it just redirects to the Gecko crash code, it doesn't need to be tied to the crash reporter. In fact, to ensure it's consistently used in all cases, we ought to install it early on. Use a static initializer for that. Depends on D11720 Depends on D11720 Differential Revision: https://phabricator.services.mozilla.com/D11721
35f916cb6452aa55dd906c0c4f63b47e05dfa316: Bug 1496503 - Change the rust panic hook to delegate to Gecko's crash code. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 22:35:33 +0000 - rev 502856
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1496503 - Change the rust panic hook to delegate to Gecko's crash code. r=froydnj The current rust panic hook keeps a string for the crash reporter, and goes on calling the default rust panic hook, which prints out a crash stack... when RUST_BOOTSTRAP is set *and* when that works. Notably, on both mac and Windows, it only really works for local builds, but fails for debug builds from automation, although on automation itself, we also do stackwalk from crash minidumps, which alleviates the problem. Artifact debug builds are affected, though. More importantly, C++ calls to e.g. MOZ_CRASH have a similar but different behavior, in that they dump a stack trace on debug builds, by default (with exceptions, see below for one). The format of those stack traces is understood by the various fix*stack*py scripts under tools/rb/, that are used by the various test harnesses both on automation and locally. Additionally, the current rust panic hook, as it calls the default rust panic hook, ends up calling abort() on non-Windows platforms, which ends up being verbosely redirected to mozalloc_abort per https://dxr.mozilla.org/mozilla-central/rev/237e4c0633fda8e227b2ab3ab57e417c980a2811/memory/mozalloc/mozalloc_abort.cpp#79 which then calls MOZ_CRASH. Theoretically, /that/ would also print a stack trace, but doesn't because currently the stack trace printing code lives in libxul, and MOZ_CRASH only calls it when compiled from libxul-code, which mozalloc_abort is not part of. With this change, we make the rust panic handler call back into MOZ_CRASH directly. This has multiple advantages: - This is more consistent cross-platforms (Windows is not special anymore). - This is more consistent between C++ and rust (stack traces all look the same, and can all be post-processed by fix*stack*py if need be) - This is more consistent in behavior, where debug builds will show those stack traces without caring about environment variables. - It demangles C++ symbols in rust-initiated stack traces (for some reason that didn't happen with the rust panic handler) A few downsides: - the loss of demangling for some rust symbols. - the loss of addresses in the stacks, although they're not entirely useful - extra empty lines. The first should be fixable later one. The latter two are arguably something that should be consistent across C++ and rust, and should be changed if necessary, independently of this patch. Depends on D11719 Depends on D11719 Differential Revision: https://phabricator.services.mozilla.com/D11720
2c9ec3b001ffa8936b19fac944e9cf16d6e5e63a: Bug 1496503 - Use MOZ_CrashOOL in MOZ_CrashPrintf. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 22:35:25 +0000 - rev 502855
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1496503 - Use MOZ_CrashOOL in MOZ_CrashPrintf. r=froydnj Because we don't really need all this repetition. Depends on D11718 Depends on D11718 Differential Revision: https://phabricator.services.mozilla.com/D11719
c61a46d741f9649de8cdca1a431c2a51cf05f564: Bug 1496503 - Move MOZ_CrashOOL to Assertions.h. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 22:35:23 +0000 - rev 502854
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1496503 - Move MOZ_CrashOOL to Assertions.h. r=froydnj Ideally, we'd want the function to stay in Assertions.cpp, but that's only part of MFBT proper, and that doesn't have access to WalkTheStack like MOZ_CRASH has from being in Assertion.h, when included from Gecko code. Moving WalkTheStack to mozglue, putting it close together with MozStackWalk would be prefered, but that causes problems linking MFBT tests (which don't have access to mozglue), and other things. Overall, this was too deep a rabbit hole, and moving MOZ_CrashOOL to Assertions.h is much simpler. Since it's essentially the same as MOZ_CRASH, except it allows non-literal strings, we can make it inlined, and leave it to the compiler to drop the filename argument when it's not used. Differential Revision: https://phabricator.services.mozilla.com/D11718
682c6a11531bda7811aa573f86d4eb30cc2c43a1: Merge mozilla-central to autoland. a=merge on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Thu, 15 Nov 2018 00:35:07 +0200 - rev 502853
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Merge mozilla-central to autoland. a=merge on a CLOSED TREE
ae26c60a0f50dc98534e7e2bd65ee62254cb71f6: Bug 1495381 - Show Manifest URL for addon target only with This Firefox;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 14 Nov 2018 17:15:18 +0000 - rev 502852
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1495381 - Show Manifest URL for addon target only with This Firefox;r=daisuke Depends on D11643 Differential Revision: https://phabricator.services.mozilla.com/D11666
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip