1dc6a4ebc9e1373385e3b2d703b9319ca4694a10: Bug 1533156 - Remove toolkit/components/reader from GeckoView. r=snorp
Agi Sferro <agi@sferro.dev> - Thu, 14 Nov 2019 19:08:26 +0000 - rev 563872
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1533156 - Remove toolkit/components/reader from GeckoView. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D49035
ae5ead19921d90b992876fc1ef06c4ef81adf8ac: Bug 1530402 - Remove Fennec code from ext-utils.js. r=droeh
Agi Sferro <agi@sferro.dev> - Thu, 14 Nov 2019 19:08:24 +0000 - rev 563871
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1530402 - Remove Fennec code from ext-utils.js. r=droeh Differential Revision: https://phabricator.services.mozilla.com/D51641
a89e03dd6b3c3917d6c784d57e53fc0ef055d581: Bug 1595891 - Guard against IndexError in wpt get_test_window(); r=jgraham
Geoff Brown <gbrown@mozilla.com> - Thu, 14 Nov 2019 19:21:09 +0000 - rev 563870
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595891 - Guard against IndexError in wpt get_test_window(); r=jgraham Change order of conditions to avoid intermittent IndexError when there are no handles. Differential Revision: https://phabricator.services.mozilla.com/D52735
1e54f02ec937bc439dfd0241d8f9f6d677ebdad9: Bug 1595257 - Add annotations report to 'mach test-info report'; r=jmaher
Geoff Brown <gbrown@mozilla.com> - Thu, 14 Nov 2019 19:11:07 +0000 - rev 563869
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595257 - Add annotations report to 'mach test-info report'; r=jmaher This "annotations" report provides a different view of manifest data, concentrating on the manifest annotations, like "skip-if". What conditions are used in manifests? How many times does each occur? Differential Revision: https://phabricator.services.mozilla.com/D52926
62bdc923737702055fba46dfd3bc7778cb005f39: Bug 1595091 - Remove alwaysOnTop from the window features used by the abuse report dialog. r=mstriemer
Luca Greco <lgreco@mozilla.com> - Thu, 14 Nov 2019 19:06:03 +0000 - rev 563868
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595091 - Remove alwaysOnTop from the window features used by the abuse report dialog. r=mstriemer Differential Revision: https://phabricator.services.mozilla.com/D52896
3024dfdb5b4371e27276ee745a4c2200cf15a926: Bug 1591755 - Support Web Permissions in FxR for Desktop r=Gijs,pbz
thomasmo <thomasmo@mozilla.com> - Thu, 14 Nov 2019 18:51:32 +0000 - rev 563867
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1591755 - Support Web Permissions in FxR for Desktop r=Gijs,pbz This change will be the first of multiple changes to control permissions in FxR on PC. This change introduces a new class, FxrPermissionPromptPrototype, in the FxR front end code. With the introduction of this class, all permission requests are denied by default. Subsequent changes will provide UI to give user control. Differential Revision: https://phabricator.services.mozilla.com/D52283
fb4b9875d44d472f27ea1df1066e1f359b28a053: Bug 1596503 - Remove unnecessary trailing semicolon with rust nightly (breaks the build) r=jrmuizel
Sylvestre Ledru <sledru@mozilla.com> - Thu, 14 Nov 2019 18:25:00 +0000 - rev 563866
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1596503 - Remove unnecessary trailing semicolon with rust nightly (breaks the build) r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D53056
7405a856572c00f82145b8e5bf397998f6349ac1: Bug 1596137 - mozAddonManager.reportAbuse should reject on unsupported addon types. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 14 Nov 2019 16:42:30 +0000 - rev 563865
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1596137 - mozAddonManager.reportAbuse should reject on unsupported addon types. r=mixedpuppy mozAddonManager.reportAbuse should reject explicitly when called for an unsupported addon type, to make AMO able to detect when if triggering the integrated report failed instead of being cancelled by the user, and fallback on the report form integrated on the AMO website. Differential Revision: https://phabricator.services.mozilla.com/D52882
dd473ab6821ecc27e748a756dca9ea8ebceaf0c5: Bug 1405971 - Test that Webextension UUID doesn't leak via XHR/Fetch requests. r=mixedpuppy
Tom Schuster <evilpies@gmail.com> - Thu, 14 Nov 2019 18:11:30 +0000 - rev 563864
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1405971 - Test that Webextension UUID doesn't leak via XHR/Fetch requests. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D40854
3b42f1a5097a3ea23d91740ffd3bac899d128952: Bug 1405971 - Strip existing disallowed schemes in Origin header. r=JuniorHsu,ckerschb
Tom Schuster <evilpies@gmail.com> - Thu, 14 Nov 2019 18:11:16 +0000 - rev 563863
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1405971 - Strip existing disallowed schemes in Origin header. r=JuniorHsu,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D39781
0de59487070db211af91074884a00564363c8d85: Bug 1580156 - set WebRTC thread name r=dmajor
Nico Grunbaum <na-g@nostrum.com> - Thu, 07 Nov 2019 20:22:42 +0000 - rev 563862
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1580156 - set WebRTC thread name r=dmajor Differential Revision: https://phabricator.services.mozilla.com/D51975
776f4bc4d6113d1b6e301761f3c77fe33fb8df25: Bug 1596238, Make NodeIterator less AddRef/Release heavy by trying to avoid use of strong pointer when the node is skipped because of whatToShow, r=Ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 14 Nov 2019 17:29:27 +0000 - rev 563861
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1596238, Make NodeIterator less AddRef/Release heavy by trying to avoid use of strong pointer when the node is skipped because of whatToShow, r=Ehsan TreeWalker could use some similar changes, but that is a different bug. TreeWalker does use TestNode method too, which is why the new argument is optional. A new bug will be filed for TreeWalker. Differential Revision: https://phabricator.services.mozilla.com/D53016
24b134b55c5f70eab758d74682fc1f6ca829e0ff: Bug 1595787: Move ExternalImageHandler and OutputImageHandler traits to webrender_api. r=kvark
Josh Matthews <josh@joshmatthews.net> - Thu, 14 Nov 2019 17:40:28 +0000 - rev 563860
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595787: Move ExternalImageHandler and OutputImageHandler traits to webrender_api. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D52686
eb83c702dd4f197ab67ae3f78968e86317338773: Bug 1596220 - Document GMPProvider's findUpdates and checkForUpdates functions. r=spohl
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 14 Nov 2019 17:36:22 +0000 - rev 563859
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1596220 - Document GMPProvider's findUpdates and checkForUpdates functions. r=spohl Add documentation to help differentiate the use cases for these two functions. Differential Revision: https://phabricator.services.mozilla.com/D52911
868a55980ae8e0f6bda936e9a5c0cbb2311a5717: Bug 1595906 - Allow opting out of hardening compile flags on a granular basis r=froydnj
Ricky Stewart <rstewart@mozilla.com> - Thu, 14 Nov 2019 17:13:28 +0000 - rev 563858
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595906 - Allow opting out of hardening compile flags on a granular basis r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52756
70304898d836c345e2ad3583ed148bb5ba0797d9: Bug 1595927 - Remove XPCOM gunk around RemoteWebNavigation creation. r=mconley
Kris Maglione <maglione.k@gmail.com> - Thu, 14 Nov 2019 19:09:22 +0000 - rev 563857
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1595927 - Remove XPCOM gunk around RemoteWebNavigation creation. r=mconley It just adds a lot of unnecessary overhead and indirection. Differential Revision: https://phabricator.services.mozilla.com/D52753
93deb240edb2863e03c5756341d03a64361e5e9a: Bug 1596430 - Permit an additional stat to the NSS certDB metadata files r=florian
J.C. Jones <jjones@mozilla.com> - Thu, 14 Nov 2019 18:41:13 +0000 - rev 563856
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1596430 - Permit an additional stat to the NSS certDB metadata files r=florian Probably caused by Bug 1577803, which is a good change, so updating the tests. Differential Revision: https://phabricator.services.mozilla.com/D53050
9ba180fee075f942198a5e6cc9c40a48e0b1072c: Bug 1592007 - land NSS 87f35ba4c82f UPGRADE_NSS_RELEASE, r=keeler
J.C. Jones <jc@mozilla.com> - Thu, 14 Nov 2019 17:32:27 +0000 - rev 563855
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1592007 - land NSS 87f35ba4c82f UPGRADE_NSS_RELEASE, r=keeler 2019-11-13 J.C. Jones <jjones@mozilla.com> * lib/softoken/pkcs11c.c: Bug 1591363 - Fixup double-free of params in nsc_SetupPBEKeyGen r=keeler Caused in commit 7ef8d2604494. [87f35ba4c82f] [tip] 2019-11-07 Makoto Kato <m_kato@ga2.so-net.ne.jp> * lib/freebl/ctr.c: Bug 1592869 - Use NEON for ctr_xor. r=kjacobs Using NEON for ctr_xor, aes_ctr can improve 30%-40%i decode/encode time on Cortex-A72. [d244c7287908] 2019-11-12 Marcus Burghardt <mburghardt@mozilla.com> * gtests/pk11_gtest/pk11_pbkdf2_unittest.cc, lib/pk11wrap/pk11pbe.c, lib/pk11wrap/pk11skey.c, lib/softoken/pkcs11c.c: Bug 1591363 - PBKDF2 memory leaks in NSC_GenerateKey. r=jcj A memory leak was reported and confirmed in this bug. However, during the "manual" analysis of the flow, another possible leak was found. I created a patch for both leaks, added gtests for unexpected keySizes and adjusted the general syntax of the gtest file. [7ef8d2604494] 2019-11-11 Tom Prince <mozilla@hocat.ca> * automation/taskcluster/graph/src/extend.js, automation/taskcluster/windows/setup.sh: Bug 1594891 - Use tc-proxy for nss tooltool; r=dustin,jcj [c33b214b2ec8] 2019-11-08 Daiki Ueno <dueno@redhat.com> * gtests/ssl_gtest/ssl_dhe_unittest.cc, gtests/ssl_gtest/ssl_ecdh_unittest.cc, gtests/ssl_gtest/tls_connect.h, lib/ssl/ssl3con.c: Bug 1566131, check policy against hash algorithms used for ServerKeyExchange, r=mt Summary: This adds necessary policy checks in `ssl3_ComputeCommonKeyHash()`, right before calculating hashes. Note that it currently doesn't check MD5 as it still needs to be allowed in TLS 1.1 or earlier and many tests fail if we change that. Reviewers: mt Reviewed By: mt Bug #: 1566131 [c08947c6af57] 2019-11-08 Kai Engert <kaie@kuix.de> * coreconf/coreconf.dep: Dummy change, trigger a build to test latest NSPR commits. [e766899c72a5] * automation/taskcluster/graph/src/extend.js: Bug 1579836 - Execute NSPR tests as part of NSS continuous integration. r=jcj [46bfbabf7e75] 2019-11-08 Dustin J. Mitchell <dustin@mozilla.com> * automation/taskcluster/graph/npm-shrinkwrap.json, automation/taskcluster/graph/package.json, automation/taskcluster/graph/src/image_builder.js, automation/taskcluster/graph/src/queue.js, automation/taskcluster/scripts/tools.sh, automation/taskcluster/windows/gen_certs.sh, automation/taskcluster/windows/run_tests.sh: Bug 1594891 - Updates to run correctly on the new TC deployment r=jcj * Update the Taskcluster client used in the decision task to one that understands Taskcluster rootUrls. * Update scripts that fetch content to use the TASKCLUSTER_ROOT_URL * the absence of this variale signals an "old" worker so we use an "old" URL [67d630e7cb7c] 2019-11-07 Tom Prince <mozilla@hocat.ca> * .taskcluster.yml, automation/taskcluster/graph/src/extend.js, automation/taskcluster/graph/src/queue.js: Bug 1591275: Switch workers to use AWS Provder; r=kjacobs [a2bebaad41dd] 2019-11-06 Daiki Ueno <dueno@redhat.com> * gtests/pk11_gtest/pk11_module_unittest.cc: Bug 1577803, clang-format, a=bustage [c9014b2892d5] * gtests/pk11_gtest/pk11_module_unittest.cc, gtests/pkcs11testmodule/pkcs11testmodule.cpp, lib/pk11wrap/debug_module.c, lib/pk11wrap/pk11obj.c, lib/pk11wrap/pk11slot.c, lib/pk11wrap/secmodti.h, lib/util/pkcs11t.h: Bug 1577803, pk11wrap: set friendly flag if token implements CKP_PUBLIC_CERTIFICATES_TOKEN, r=rrelyea Summary: This makes NSS look for CKO_PROFILE object at token initialization time to check if it implements the [[ https://docs .oasis-open.org/pkcs11/pkcs11-profiles/v3.0/pkcs11-profiles-v3.0.pdf | Public Certificates Token profile ]] as defined in PKCS #11 v3.0. If it is found, the token is automatically marked as friendly so no authentication attempts will be made when accessing certificates. Reviewers: rrelyea Reviewed By: rrelyea Subscribers: reviewbot Bug #: 1577803 [b39c8eeabe6a] 2019-11-06 Martin Thomson <mt@lowentropy.net> * lib/freebl/blinit.c, lib/freebl/gcm-ppc.c: Bug 1566126 - clang-format, a=bustage [6125200fbc88] 2019-11-06 Lauri Kasanen <cand@gmx.com> * lib/freebl/Makefile, lib/freebl/altivec-types.h, lib/freebl/blapii.h, lib/freebl/blinit.c, lib/freebl/freebl.gyp, lib/freebl/gcm-ppc.c, lib/freebl/gcm.c, lib/freebl/gcm.h: Bug 1566126 - freebl: POWER GHASH Vector Acceleration, r=mt Implementation for POWER8 adapted from the ARM paper: https://conradoplg.cryptoland.net/files/2010/12/gcm14.pdf Benchmark of `bltest -E -m aes_gcm -i tests/aes_gcm/plaintext10 \ -v tests/aes_gcm/iv10 -k tests/aes_gcm/key10 -5 10` on POWER8 3.3GHz. NSS_DISABLE_HW_CRYPTO=1 mode in symmkey opreps cxreps context op time(sec) thrgput aes_gcm_e 309Mb 192 5M 0 0.000 10000.000 10.001 30Mb mode in symmkey opreps cxreps context op time(sec) thrgput aes_gcm_e 829Mb 192 14M 0 0.000 10000.000 10.001 82Mb Notable operf results, sw: samples % image name symbol name 226033 59.3991 libfreeblpriv3.so bmul 80606 21.1824 libfreeblpriv3.so rijndael_encryptBlock128 28851 7.5817 libfreeblpriv3.so gcm_HashMult_sftw hw: 213899 56.2037 libfreeblpriv3.so rijndael_encryptBlock128 45233 11.8853 libfreeblpriv3.so gcm_HashMult_hw So the ghash part is ~5.6x faster. Signed-off-by: Lauri Kasanen <cand@gmx.com> [3d7e509d6d20] 2019-11-05 Marcus Burghardt <mburghardt@mozilla.com> * lib/certdb/certdb.c, lib/util/secport.h: Bug 1589073 - Use of new PR_ASSERT_ARG in certdb.c. r=mt Bug 1588015 introduced in NSPR a new way to ASSERT values where the arguments are always used avoiding "unused variable" errors. This was implemented in NSS, at certdb.c. [73c28cad3dbb] 2019-11-05 Daiki Ueno <dueno@redhat.com> * cpputil/nss_scoped_ptrs.h, gtests/manifest.mn, gtests/pk11_gtest/manifest.mn, gtests/pk11_gtest/pk11_gtest.gyp, gtests/pk11_gtest/pk11_module_unittest.cc, gtests/pkcs11testmodule/Makefile, gtests/pkcs11testmodule/config.mk, gtests/pkcs11testmodule/manifest.mn, gtests/pkcs11testmodule/pkcs11testmodule.cpp, gtests/pkcs11testmodule/pkcs11testmodule.def, gtests/pkcs11testmodule/pkcs11testmodule.gyp, gtests/pkcs11testmodule/pkcs11testmodule.rc, nss.gyp: Bug 1577803, gtests: import pkcs11testmodule from Firefox, r=rrelyea Summary: This adds a mock PKCS #11 module from Firefox and add basic tests around it. This is needed for proper testing of PKCS #11 v3.0 profile objects (D45669). Reviewers: rrelyea Reviewed By: rrelyea Subscribers: reviewbot Bug #: 1577803 [0a86945adf74] Differential Revision: https://phabricator.services.mozilla.com/D52779
512d489d83e128358c960823d75b22bd59cb7163: Bug 1582297 - Suppress IPC "pipe error" messages if the cause was probably the other process exiting. r=froydnj
Jed Davis <jld@mozilla.com> - Tue, 12 Nov 2019 21:04:40 +0000 - rev 563854
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1582297 - Suppress IPC "pipe error" messages if the cause was probably the other process exiting. r=froydnj There are two issues here: 1. These error messages occur even during normal channel shutdown, because that's tracked in the mozilla::ipc::MessageChannel layer, which the ipc/chromium code can't access. 2. If we get this kind of error when the channel wasn't intentionally closed, it almost certainly means that the other process crashed. In that case, having error messages from a different process and a likely unrelated subsystem just leads to confusion and misfiled bugs. (Also complicating things: on Unix a closed channel often, but not always, results in an end-of-file indication, which already isn't logged; on Windows it's always a broken pipe error, which causes a much larger amount of log spam.) Bonus fix: the error that contains a fd number is clarified to avoid having it mistaken for an error code. Differential Revision: https://phabricator.services.mozilla.com/D52727
d395b70f3ff8af258f4ccb2e78cef02c27cf9ff4: Bug 1594122 - convert XBL binding to custom element in 348049-1.xhtml reftest r=bzbarsky
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 14 Nov 2019 17:40:20 +0000 - rev 563853
Push 12351 by ffxbld-merge at Mon, 02 Dec 2019 11:32:26 +0000
Bug 1594122 - convert XBL binding to custom element in 348049-1.xhtml reftest r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D52854
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip