Bug 1494543 - Part 2: Add model + short runtime name to the sidebar item. r=jdescottes,daisuke Added new getters to the ADB scanner so our runtime objects have now the information we need. Note that the UX of the devices in this patch doesn't still match what we had in the mockups (icons don't match, and we also need a circle with a tick), but since we have another bug to handle the CSS in the Sidebar, we can always adapt it there. The information needed to display what is shown in the mockups should be passed in this patch –if I miss anything, give me a shout! Differential Revision: https://phabricator.services.mozilla.com/D7705

Bug 1494543 - Part 1: Refactor sidebar items into different components. r=jdescottes,daisuke This is a refactor of the components used in the sidebar. TL;DR: sidebar items now use the composition approach outlined here https://reactjs.org/docs/composition-vs-inheritance.html Before we had a container `Sidebar` component, which in turn had `SidebarItem` components inside. The issue was that depending on what item is inside, the information and UX displayed is different. Before this patch, we had an optional commponent, `DeviceSidebarItemAction` –which was featuring a "Connect" button, and was only rendered in the runtime sidebar items. However, we now need to display even more info, so continue to pass optional components to `SidebarItem` was tricky. What this patch does is to preserve `SidebarItem` and treat is a generic container of more specific content. This is passed via the `children` prop, which React automatically maps to the DOM content that we pass to that component (this is the same concept as slots in Web Components / Vue). `SidebarItem` now only contains the logic to select items in the sidebar and render them in `<li>` elements. Two new components, `SidebarFixedItem` (for our "static" pages) and `SidebarDeviceItem` are now the ones instancing `SidebarItem` with their specific contents. Differential Revision: https://phabricator.services.mozilla.com/D7704

Bug 1484946 - Fix tree twisty color on in-content pages when selected and unfocused r=ntim,dao Differential Revision: https://phabricator.services.mozilla.com/D8669

Bug 1488468 - Move HTTP POST request to wait_for_ping in TestPingServer; r=davehunt Depends on D8531 Differential Revision: https://phabricator.services.mozilla.com/D8532

Bug 1488468 - Filter ping_list in Wait function of TelemetryTestCase; r=davehunt Differential Revision: https://phabricator.services.mozilla.com/D8531

Bug 1478219 - Remove search default and search order from l10n checks (mobile, desktop) r=Pike Differential Revision: https://phabricator.services.mozilla.com/D8832

Bug 1496240 - Change 'Blocked' to 'Blocking' for in Content Blocking Categories doorhanger part r=johannh Differential Revision: https://phabricator.services.mozilla.com/D8793

Bug 1494632 - Convert WorkerClient to protocol.js front. r=jdescottes MozReview-Commit-ID: BbtEReeG4v9 Depends on D7462 Differential Revision: https://phabricator.services.mozilla.com/D7463

Bug 1439450 - Ignore has_first_value() check in ProtocolParser. r=francois Sometimes the protocol buffer data (RiceEncodingData) sent by Google's Safe Browsing server has the following properties: 1. |has_first_value| is false 2. |num_entries| > 0 In this case, we can still parse the data and apply partial update correctly by assuming that the first value is equal to 0. Differential Revision: https://phabricator.services.mozilla.com/D6393

Merge mozilla-central to inbound. a=merge CLOSED TREE

Bug 1356536 - Add file type icons in network monitor. r=Honza Added request type icons in File column of Network Monitor Differential Revision: https://phabricator.services.mozilla.com/D7697

Bug 1484173 - Replace the mNeedsComposite counter with a timestamp. r=sotaro The mNeedsComposite counter was used to force a composite immediately if the scheduler received a number of composite requests without actually getting a vsync. It was necessary on Fennec because of main-thread contention. However it was wrong because it assumes only a single composite gets requested per vsync interval, which is not true. Instead of using a counter this patch uses a timestamp to ensure that we only force the vsync after two vsync intervals have elapsed. Depends on D8765 Differential Revision: https://phabricator.services.mozilla.com/D8766

Bug 1484173 - Expose the vsync interval via the CompositorVsyncSchedulerOwner interface. r=sotaro We need this for the next patch. Differential Revision: https://phabricator.services.mozilla.com/D8765

Bug 1498618 - Never apply clang-format on code in {{{ check_macroassembler_style r=nbp Differential Revision: https://phabricator.services.mozilla.com/D8571

Merge mozilla-central to autoland. a=merge CLOSED TREE

Merge inbound to mozilla-central. a=merge

Backed out 3 changesets (bug 1494549) for OSX devtools failures. CLOSED TREE Backed out changeset e9abf60db23b (bug 1494549) Backed out changeset 3e89e661031c (bug 1494549) Backed out changeset 0d7e2a4ad360 (bug 1494549)

Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke Depends on D8335 Differential Revision: https://phabricator.services.mozilla.com/D8513

Bug 1494549 - Add a mochitest test for status message;r=ladybenko Depends on D8334. In this changeset we also change the way we are reading the preferences in adb-addon.js to avoid caching the value of the preference the first time the module is loaded. This allows the module to follow updates of said preferences without having to restart Firefox. Differential Revision: https://phabricator.services.mozilla.com/D8335

Bug 1494549 - Show USB devices status in sidebar;r=ladybenko Maybe we want to land the simplest solution for now and discuss quickly how to style the message to reduce confusion in a follow up? Differential Revision: https://phabricator.services.mozilla.com/D8334