180b08bce5810da4b876e966f291bf1b90b53227: Bug 1494543 - Part 2: Add model + short runtime name to the sidebar item. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Tue, 16 Oct 2018 11:57:45 +0000 - rev 497199
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1494543 - Part 2: Add model + short runtime name to the sidebar item. r=jdescottes,daisuke Added new getters to the ADB scanner so our runtime objects have now the information we need. Note that the UX of the devices in this patch doesn't still match what we had in the mockups (icons don't match, and we also need a circle with a tick), but since we have another bug to handle the CSS in the Sidebar, we can always adapt it there. The information needed to display what is shown in the mockups should be passed in this patch –if I miss anything, give me a shout! Differential Revision: https://phabricator.services.mozilla.com/D7705
bca2310f556c6848737084fe009f7976f2cf6f3c: Bug 1494543 - Part 1: Refactor sidebar items into different components. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Tue, 16 Oct 2018 09:35:25 +0000 - rev 497198
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1494543 - Part 1: Refactor sidebar items into different components. r=jdescottes,daisuke This is a refactor of the components used in the sidebar. TL;DR: sidebar items now use the composition approach outlined here https://reactjs.org/docs/composition-vs-inheritance.html Before we had a container `Sidebar` component, which in turn had `SidebarItem` components inside. The issue was that depending on what item is inside, the information and UX displayed is different. Before this patch, we had an optional commponent, `DeviceSidebarItemAction` –which was featuring a "Connect" button, and was only rendered in the runtime sidebar items. However, we now need to display even more info, so continue to pass optional components to `SidebarItem` was tricky. What this patch does is to preserve `SidebarItem` and treat is a generic container of more specific content. This is passed via the `children` prop, which React automatically maps to the DOM content that we pass to that component (this is the same concept as slots in Web Components / Vue). `SidebarItem` now only contains the logic to select items in the sidebar and render them in `<li>` elements. Two new components, `SidebarFixedItem` (for our "static" pages) and `SidebarDeviceItem` are now the ones instancing `SidebarItem` with their specific contents. Differential Revision: https://phabricator.services.mozilla.com/D7704
ab9dfffff004480f216246435f2de37f801a636c: Bug 1484946 - Fix tree twisty color on in-content pages when selected and unfocused r=ntim,dao
Arshad Kazmi <arshadkazmi42@gmail.com> - Tue, 16 Oct 2018 10:18:56 +0000 - rev 497197
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1484946 - Fix tree twisty color on in-content pages when selected and unfocused r=ntim,dao Differential Revision: https://phabricator.services.mozilla.com/D8669
51b87be56bcae1931f2a8b76b2494c945c3b2db8: Bug 1488468 - Move HTTP POST request to wait_for_ping in TestPingServer; r=davehunt
Raphael Pierzina <rpierzina@mozilla.com> - Tue, 16 Oct 2018 10:42:06 +0000 - rev 497196
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1488468 - Move HTTP POST request to wait_for_ping in TestPingServer; r=davehunt Depends on D8531 Differential Revision: https://phabricator.services.mozilla.com/D8532
bf88501c1f8af00508f0a13029329ea2f005f51c: Bug 1488468 - Filter ping_list in Wait function of TelemetryTestCase; r=davehunt
Raphael Pierzina <rpierzina@mozilla.com> - Tue, 16 Oct 2018 08:28:56 +0000 - rev 497195
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1488468 - Filter ping_list in Wait function of TelemetryTestCase; r=davehunt Differential Revision: https://phabricator.services.mozilla.com/D8531
0f0249190e74309e4de3a16e9b15400e39ce518e: Bug 1478219 - Remove search default and search order from l10n checks (mobile, desktop) r=Pike
Francesco Lodolo (:flod) <flod@lodolo.net> - Tue, 16 Oct 2018 11:12:34 +0000 - rev 497194
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1478219 - Remove search default and search order from l10n checks (mobile, desktop) r=Pike Differential Revision: https://phabricator.services.mozilla.com/D8832
451ad77036b5068485a7affd6cc74768295d14e1: Bug 1496240 - Change 'Blocked' to 'Blocking' for in Content Blocking Categories doorhanger part r=johannh
Michael Kohler <me@michaelkohler.info> - Tue, 16 Oct 2018 10:45:01 +0000 - rev 497193
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1496240 - Change 'Blocked' to 'Blocking' for in Content Blocking Categories doorhanger part r=johannh Differential Revision: https://phabricator.services.mozilla.com/D8793
89308a0efe91b73daa395ca4af36727e5c151b4b: Bug 1494632 - Convert WorkerClient to protocol.js front. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 16 Oct 2018 09:39:11 +0000 - rev 497192
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1494632 - Convert WorkerClient to protocol.js front. r=jdescottes MozReview-Commit-ID: BbtEReeG4v9 Depends on D7462 Differential Revision: https://phabricator.services.mozilla.com/D7463
37d138b1e58b9c45ee3baef530bb133597b14eb3: Bug 1439450 - Ignore has_first_value() check in ProtocolParser. r=francois
Dimi Lee <dlee@mozilla.com> - Tue, 16 Oct 2018 10:36:01 +0000 - rev 497191
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1439450 - Ignore has_first_value() check in ProtocolParser. r=francois Sometimes the protocol buffer data (RiceEncodingData) sent by Google's Safe Browsing server has the following properties: 1. |has_first_value| is false 2. |num_entries| > 0 In this case, we can still parse the data and apply partial update correctly by assuming that the first value is equal to 0. Differential Revision: https://phabricator.services.mozilla.com/D6393
db589d2f37284b67611b56d969b4bc9442697002: Merge mozilla-central to inbound. a=merge CLOSED TREE
Margareta Eliza Balazs <ebalazs@mozilla.com> - Tue, 16 Oct 2018 12:39:05 +0300 - rev 497190
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Merge mozilla-central to inbound. a=merge CLOSED TREE
4fa33210cbc490a1dc353e2288b507138de81772: Bug 1356536 - Add file type icons in network monitor. r=Honza
Amy Chan <amy_yyc@yahoo.com> - Tue, 16 Oct 2018 10:30:23 +0000 - rev 497189
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1356536 - Add file type icons in network monitor. r=Honza Added request type icons in File column of Network Monitor Differential Revision: https://phabricator.services.mozilla.com/D7697
23ac21b643c2f398affbdfc7a59f97af70733a9c: Bug 1484173 - Replace the mNeedsComposite counter with a timestamp. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 16 Oct 2018 05:36:14 +0000 - rev 497188
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1484173 - Replace the mNeedsComposite counter with a timestamp. r=sotaro The mNeedsComposite counter was used to force a composite immediately if the scheduler received a number of composite requests without actually getting a vsync. It was necessary on Fennec because of main-thread contention. However it was wrong because it assumes only a single composite gets requested per vsync interval, which is not true. Instead of using a counter this patch uses a timestamp to ensure that we only force the vsync after two vsync intervals have elapsed. Depends on D8765 Differential Revision: https://phabricator.services.mozilla.com/D8766
b032c73f6f69d6e01fd86125ec1ce183061bdb78: Bug 1484173 - Expose the vsync interval via the CompositorVsyncSchedulerOwner interface. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 16 Oct 2018 00:33:51 +0000 - rev 497187
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1484173 - Expose the vsync interval via the CompositorVsyncSchedulerOwner interface. r=sotaro We need this for the next patch. Differential Revision: https://phabricator.services.mozilla.com/D8765
7127bf67c3b90bb70473774659a4cbad492dafe7: Bug 1498618 - Never apply clang-format on code in {{{ check_macroassembler_style r=nbp
Sylvestre Ledru <sledru@mozilla.com> - Mon, 15 Oct 2018 10:02:00 +0000 - rev 497186
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1498618 - Never apply clang-format on code in {{{ check_macroassembler_style r=nbp Differential Revision: https://phabricator.services.mozilla.com/D8571
dc75dad8f69b572650ddb2c4a0ea06661135837f: Merge mozilla-central to autoland. a=merge CLOSED TREE
Margareta Eliza Balazs <ebalazs@mozilla.com> - Tue, 16 Oct 2018 12:37:59 +0300 - rev 497185
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
9079bbe837184ed183b133a374753865b6768bc4: Merge inbound to mozilla-central. a=merge
Margareta Eliza Balazs <ebalazs@mozilla.com> - Tue, 16 Oct 2018 12:31:18 +0300 - rev 497184
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Merge inbound to mozilla-central. a=merge
1c6fa266a661d9cb37816e46537fb5664b9702c3: Backed out 3 changesets (bug 1494549) for OSX devtools failures. CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Tue, 16 Oct 2018 12:34:38 +0300 - rev 497183
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Backed out 3 changesets (bug 1494549) for OSX devtools failures. CLOSED TREE Backed out changeset e9abf60db23b (bug 1494549) Backed out changeset 3e89e661031c (bug 1494549) Backed out changeset 0d7e2a4ad360 (bug 1494549)
e9abf60db23b75c1807bc6afa5b3fa9d8d483af6: Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Mon, 15 Oct 2018 07:30:44 +0000 - rev 497182
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke Depends on D8335 Differential Revision: https://phabricator.services.mozilla.com/D8513
3e89e661031ccb8f6f1889c5b6c1687db03e3eaa: Bug 1494549 - Add a mochitest test for status message;r=ladybenko
Julian Descottes <jdescottes@mozilla.com> - Fri, 12 Oct 2018 07:20:22 +0000 - rev 497181
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1494549 - Add a mochitest test for status message;r=ladybenko Depends on D8334. In this changeset we also change the way we are reading the preferences in adb-addon.js to avoid caching the value of the preference the first time the module is loaded. This allows the module to follow updates of said preferences without having to restart Firefox. Differential Revision: https://phabricator.services.mozilla.com/D8335
0d7e2a4ad36090bb5599afd91fe749fd85b1fa36: Bug 1494549 - Show USB devices status in sidebar;r=ladybenko
Julian Descottes <jdescottes@mozilla.com> - Mon, 15 Oct 2018 15:31:14 +0000 - rev 497180
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1494549 - Show USB devices status in sidebar;r=ladybenko Maybe we want to land the simplest solution for now and discuss quickly how to style the message to reduce confusion in a follow up? Differential Revision: https://phabricator.services.mozilla.com/D8334
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip