14acffc2e1eca99806bda3099cdf12938772cd52: Bug 1397823 - part 3 - do a better job setting IPC::Message flags; r=kanru
Nathan Froyd <froydnj@mozilla.com> - Fri, 15 Sep 2017 08:06:11 -0400 - rev 430638
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1397823 - part 3 - do a better job setting IPC::Message flags; r=kanru The current IPC::Message constructor takes a large number of arguments, three of which--the nesting level, the priority, and the compression--are almost always constant by virtue of the vast majority of Message construction being done by auto-generated IPDL code. But then we take these constant values into the Message constructor, we check them for various values, and then based on those values, we perform a bunch of bitfield operations to store flags based on those values. This is wasted work. Furthermore, for replies to IPDL messages, we'll construct a Message object, and then call mutating setters on the Message object that will perform even more bitfield manipulations. Again, these operations are performing tasks at runtime that are the same every single time, and use information we already have at compile time. The impact of these extra operations is not large, maybe 15-30K of extra code, depending on platform. Nonetheless, we can easily make them go away, and make everything cleaner to boot. This patch adds a HeaderFlags class that encapsulates all the knowledge about the various kinds of flags Message needs to know about. We can construct HeaderFlags objects with strongly-typed enum arguments for the various kinds of flags, and the compiler can take care of folding all of those flags together into a constant when possible (and it is possible for all the IPDL-generated code that instantiates Messages). The upshot is that we do no unnecessary work in the Message constructor itself. We can also remove various mutating operations on Message, as those operations were only there to support post-constructor flag twiddling, which is no longer necessary.
6e7da31ab0b11eb3b4f2e372b350652b8b3e3597: Bug 1397823 - part 2 - tidy _generateMessageConstructor enums a little; r=kanru
Nathan Froyd <froydnj@mozilla.com> - Fri, 15 Sep 2017 08:06:11 -0400 - rev 430637
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1397823 - part 2 - tidy _generateMessageConstructor enums a little; r=kanru There's no need to be repeating 'IPC::Message::' prefixes or spreading around more ExprVar calls than we need here. Let's try to improve the signal-to-noise ratio of this code by introducing a helper function to inject some of the boilerplate for us.
1607f6d53f5273361ce35e47f94d3966c26611c6: Bug 1397823 - part 1 - move work into _generateMessageConstructor; r=kanru
Nathan Froyd <froydnj@mozilla.com> - Fri, 15 Sep 2017 08:06:11 -0400 - rev 430636
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1397823 - part 1 - move work into _generateMessageConstructor; r=kanru _generateMessageConstructor takes a lot of `md.FOO`-style parameters, which could be derived inside the function by simply passing `md`. Especially with the upcoming changes to calculate things like reply-ness of messages, sync-ness, etc, we'd be wanting to pass even more parameters like `md.FOO`. So let's just pass `md` in, and then we can make all the necessary future changes in a single place.
70f5f23a429f3d621e44307c191fa84c77fb2f61: Bug 1397407 - Apply deferred image key deletions to the next transaction. r=Gankro
Nicolas Silva <nsilva@mozilla.com> - Fri, 15 Sep 2017 13:24:31 +0200 - rev 430635
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1397407 - Apply deferred image key deletions to the next transaction. r=Gankro
d26e31b70dae473c5a13804b5c761b10765251a1: Bug 1399876: Relax the assertion about sending multiple eMouseEnterIntoWidget in TabParent. r=baku.
Stone Shih <sshih@mozilla.com> - Fri, 15 Sep 2017 15:41:53 +0800 - rev 430634
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1399876: Relax the assertion about sending multiple eMouseEnterIntoWidget in TabParent. r=baku. We may create a browser element and replace it while the TabChild isn't ready to handle input events.
92c830b99fe97c2970f0a58ecef8c8d8b6a2fa85: Bug 1387937 - Part 2. Add patch file. r=jfkthame
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 15 Sep 2017 19:07:06 +0900 - rev 430633
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1387937 - Part 2. Add patch file. r=jfkthame MozReview-Commit-ID: Ej5YLm9dz57
a9bf7b6cf6d4ed4f467e261d771281498b626cc6: Bug 1387937 - Part 1. Import changeset 40324. r=jfkthame
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 15 Sep 2017 18:57:20 +0900 - rev 430632
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1387937 - Part 1. Import changeset 40324. r=jfkthame MozReview-Commit-ID: 86oFSd6ifc7
6487b7e332d64d438976a19030bb94e639480391: Bug 1399848 - Update failing windows tests within dom/browser-element to comply with new toplevel data: URI navigation policy. r=smaug
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Fri, 15 Sep 2017 12:17:26 +0200 - rev 430631
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1399848 - Update failing windows tests within dom/browser-element to comply with new toplevel data: URI navigation policy. r=smaug
53d445528ef226c188bc39bee82dd4cefd1940d4: Bug 1399928 - RegExpShared::source should be a GCPtr r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 15 Sep 2017 11:04:40 +0100 - rev 430630
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1399928 - RegExpShared::source should be a GCPtr r=sfink
5c1007b062e3a2b3d2571983603ccc67a144f8b6: Bug 1399933 - Replace use of ObjectValueCrashOnTouch with PoisonedObjectValue r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 15 Sep 2017 11:04:40 +0100 - rev 430629
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1399933 - Replace use of ObjectValueCrashOnTouch with PoisonedObjectValue r=sfink
c4a244ec50df3b2fe64dad024275a9789ef113d0: merge mozilla-central to mozilla-inbound. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 15 Sep 2017 11:12:04 +0200 - rev 430628
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
merge mozilla-central to mozilla-inbound. r=merge a=merge
d1a21fb93a04f252365cfb02b32535cc7665eadd: Bug 1393716 - Don't run minidump analysis on content crashes if the browser is quitting r=ted.mielczarek
Gabriele Svelto <gsvelto@mozilla.com> - Sun, 03 Sep 2017 10:48:18 +0200 - rev 430627
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1393716 - Don't run minidump analysis on content crashes if the browser is quitting r=ted.mielczarek When a content crash is detected we run the minidump analyzer on it to extract a stack trace that will be sent with the crash ping. Since this operation can potentially take a long time this patch prevents it from happening if the browser is already quitting. Already running instances of the minidump analyzer are also killed. The patch includes test coverage for both the new codepaths. MozReview-Commit-ID: 4CQBp0v5KxE
07b93c7fec6c83f53a3bdce9becbb13f0fc397e5: Bug 1400066 - Gracefully handle unsupported platforms for U2F HID support r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 14 Sep 2017 18:11:47 -0700 - rev 430626
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1400066 - Gracefully handle unsupported platforms for U2F HID support r=ttaubert FreeBSD isn't currently support for FIDO U2F support, similar to Android, so this patch [1] from Jan Beich <jbeich@FreeBSD.org> treats Android and FreeBSD the same. With luck, someone will add in the platform support for both, soon! [1] https://github.com/jcjones/u2f-hid-rs/pull/44 MozReview-Commit-ID: DU7Rco2NLb3
0aed7d43efe295f6086cb3d1cb96326da5c2ebac: Bug 1400080 - Remove impossible telemetry test from WebAuthn r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 14 Sep 2017 19:17:52 -0700 - rev 430625
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1400080 - Remove impossible telemetry test from WebAuthn r=ttaubert Now that there are actual hardware devices, this test can't be run: it depended on there being a deliberately-erroring implementation of WebAuthn which would instantly reject promises. Fortunately, this test was really more a test that telemetry scalars work properly than really the functionality of WebAuthn. Sadly, I don't see any way to re-enable this test without adding a new test- only pref to the tree, which doesn't seem worth it for the telemetry. So this patch removes the offending test completely which was backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c115eec567a6 . MozReview-Commit-ID: LiLuQHbPU1z
16edc2f1ada8f6f22ae8c36dda417522ac4fa25c: Bug 1354536 - Part 1 - Introduce a string for the 'Recent Highlights' section soon the be added to the Library view. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Fri, 15 Sep 2017 10:10:14 +0200 - rev 430624
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1354536 - Part 1 - Introduce a string for the 'Recent Highlights' section soon the be added to the Library view. r=Gijs MozReview-Commit-ID: J1tcBxspjuI
a71dd9ce8a166bf5781ecbc53ead54bd50f4f8f2: Bug 1347833 - Add support to wrap long request parameters/cookies in the netmonitor sidebar. r=Honza
abhinav <abhinav.koppula@gmail.com> - Sun, 10 Sep 2017 00:08:06 +0530 - rev 430623
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1347833 - Add support to wrap long request parameters/cookies in the netmonitor sidebar. r=Honza MozReview-Commit-ID: LYQvQzxRC5G
9253681974414228318eacfdcaafdaae333855bb: Bug 1400232 - Hide the menu button separator in compact mode. r=johannh
Dão Gottwald <dao@mozilla.com> - Fri, 15 Sep 2017 16:16:59 +0200 - rev 430622
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1400232 - Hide the menu button separator in compact mode. r=johannh MozReview-Commit-ID: CKuXX6QZ3W5
8b0058e2a4a8a123e09470b7ee975963be88a158: Bug 1399460 - Fix for browser_webconsole_check_stubs_console_api. r=Honza
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 14 Sep 2017 18:49:43 +0200 - rev 430621
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1399460 - Fix for browser_webconsole_check_stubs_console_api. r=Honza The test that checked console api stubs was failing because we were trying to reach the server while the connection was closed, which throws an error. This patch filters-out log messages in the console output so we don't get unwanted server communication. The output is not important here since we are only listening to the consoleAPICall event. MozReview-Commit-ID: Ay5fQ1CSbLx
e7d1f0e04aaef260f2acd9f998eacf245ea2c363: Bug 1399460 - Fix browser_ext_devtools_inspectedWindow_eval_bindings.js failure. r=rpl
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 14 Sep 2017 17:59:33 +0200 - rev 430620
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1399460 - Fix browser_ext_devtools_inspectedWindow_eval_bindings.js failure. r=rpl The bug was failing because we were calling the server but the connection was already closed. In order to prevent such things, we check the number of nodes of the tree, and if it has only one, then we wait on a mutation that will ensure that server calls are done. MozReview-Commit-ID: 7kHAkYs2I4K
0f78304723803b6debe7f5cfacf5ad4cd45390d6: Bug 1399460 - Adapt the console to the new Reps bundle. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 07 Sep 2017 13:09:24 +0200 - rev 430619
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1399460 - Adapt the console to the new Reps bundle. r=Honza. This is mainly changing the props we pass to the ObjectInspector, and removing actions, state properties and reducers that we used to handle in the console but are now managed by the ObjectInspector itself. MozReview-Commit-ID: F2GabDqDjPe
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip