12deaef54bc6fc1910cfa1d0ebfa3a3b61e72d8d: Bug 1445588: Devirtualize nsIDocument::GetViewportInfo. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Mar 2018 12:57:12 +0100 - rev 461685
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445588: Devirtualize nsIDocument::GetViewportInfo. r=smaug Reviewers: smaug Bug #: 1445588 Differential Revision: https://phabricator.services.mozilla.com/D729 MozReview-Commit-ID: 4bW2Yo784Z
d25f89538c905c647a1e5d513b22b5bcd5ef936d: Bug 1445503 - Use MIN instead of unnecessary CLAMP r=karlt
Michael Webster <miketwebster@gmail.com> - Wed, 14 Mar 2018 00:50:00 +0200 - rev 461684
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445503 - Use MIN instead of unnecessary CLAMP r=karlt CLAMP is unnecessary as the minimum acceptable value is 0, and progressPercent is unsigned. CLAMP can trigger the following warning/error in some builds: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
70500f888010d32def06f39cd9449156ed08b258: Bug 1442978 - Add words to en-US dictionary. r=ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Sun, 04 Mar 2018 18:49:10 +0700 - rev 461683
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1442978 - Add words to en-US dictionary. r=ehsan
834986ac1667fa8c4c3ae41113ce83913079cacf: Bug 1438210: another followup: Avoid the previous patch busting new toolchains (sigh). r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Mar 2018 11:39:38 +0100 - rev 461682
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1438210: another followup: Avoid the previous patch busting new toolchains (sigh). r=me MozReview-Commit-ID: 7PkoklZLCk7
4685e6927a0c39793ea65c7389f90aa0a77816fa: Bug 1438210: followup: Add a constructor to unbust builds on older toolchains. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Mar 2018 11:34:01 +0100 - rev 461681
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1438210: followup: Add a constructor to unbust builds on older toolchains. r=me MozReview-Commit-ID: Cx0vnHt0OW6
4c7ae4c1496a83f68e473321e034bfda1804d6dd: Merge mozilla-central to mozilla-inbound
arthur.iakab <aiakab@mozilla.com> - Wed, 14 Mar 2018 12:18:15 +0200 - rev 461680
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Merge mozilla-central to mozilla-inbound
d2a1cfce834f06d85f94ac31578732169224e220: Bug 1424963: Replace remaining consumers of getPropertyCSSValue for getCSSImageURLs. r=florian,bz
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Mar 2018 20:02:05 +0100 - rev 461679
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1424963: Replace remaining consumers of getPropertyCSSValue for getCSSImageURLs. r=florian,bz The context-menu change is technically not idempotent, since something like: background-image: url(foo), linear-gradient(..); Would throw before. But that didn't seem like a great deal to me. MozReview-Commit-ID: 70pD1EyXDB
7e5eb5740cac2dbac9d803d5151ef4958bc51862: Bug 1424963: Add ChromeOnly CSSStyleDeclaration::GetCSSImageURLs. r=bz
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Mar 2018 19:52:32 +0100 - rev 461678
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1424963: Add ChromeOnly CSSStyleDeclaration::GetCSSImageURLs. r=bz MozReview-Commit-ID: CISe5jaQbIQ
6b06d04460074d2d4f81ada49ff36a57ccbf5ff7: Bug 1438210: Make slot assignment sound with layout after bug 1409975. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 13 Mar 2018 15:27:50 +0100 - rev 461677
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1438210: Make slot assignment sound with layout after bug 1409975. r=smaug Summary: Before that bug, we carefully told layout about all distribution changes before they happened, so layout could cleanup frames and styles synchronously properly (since otherwise there's no way afterwards to figure out what the tree shape was). That bug made it not do it correctly, causing this. I obviously need to write a bunch of tests for this... Reviewers: smaug Bug #: 1438210 Differential Revision: https://phabricator.services.mozilla.com/D724 MozReview-Commit-ID: 8uupNhoFwme
b9370ab70cbf1ae719bc271830be8ce995e6938c: Bug 1445351 - Add comment with bug reference (DONTBUILD)
Dão Gottwald <dao@mozilla.com> - Wed, 14 Mar 2018 07:32:58 +0100 - rev 461676
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445351 - Add comment with bug reference (DONTBUILD)
7dad306cf8fede99816cf454466ff16cbf38053c: Bug 1391255. Crash earlier if recording playback fails. r=kats
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 23 Feb 2018 13:14:39 -0500 - rev 461675
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1391255. Crash earlier if recording playback fails. r=kats This should help us narrow down what's going wrong a bit. MozReview-Commit-ID: 2Ah0nMCwv55
28707a88967e92bee769fcbae13584adc75ced84: Bug 1443297 - Fix sizing error for HostLayerManager::mCompositorBridgeID. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 14 Mar 2018 12:17:27 -0400 - rev 461674
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1443297 - Fix sizing error for HostLayerManager::mCompositorBridgeID. r=jrmuizel MozReview-Commit-ID: 5OWWCzkFOpL
e3cf4f31fc7c894b0830c4660091b18ba94c3d69: Backed out changeset 7a4f85c76c7c (bug 1444327) for Cl failurs on devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js
Dorel Luca <dluca@mozilla.com> - Wed, 14 Mar 2018 19:38:17 +0200 - rev 461673
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Backed out changeset 7a4f85c76c7c (bug 1444327) for Cl failurs on devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js
c1126af7196be04c223bd843c1d6878de6c96599: Bug 1445455 - Test that it's possible to show the same StatusPanel value twice in a row. r=dao
Mike Conley <mconley@mozilla.com> - Tue, 13 Mar 2018 18:21:47 -0400 - rev 461672
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445455 - Test that it's possible to show the same StatusPanel value twice in a row. r=dao MozReview-Commit-ID: 17U8JHVO2PN
39af208c6af0470b86694ed9e0a4c2bc29295a57: Bug 1445455 - StatusPanel needs to update label even when the label text has not changed. r=dao
Mike Conley <mconley@mozilla.com> - Tue, 13 Mar 2018 17:27:06 -0400 - rev 461671
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445455 - StatusPanel needs to update label even when the label text has not changed. r=dao MozReview-Commit-ID: BhfFZ14IEB8
9ae60e8e7b9f37299ca1be4f3558f0cea18d13cd: servo: Merge #20265 - Fix JS object conversion in unions (from Xanewok:fix-js-objects-in-unions); r=jdm
Igor Matuszewski <Xanewok@gmail.com> - Wed, 14 Mar 2018 12:04:23 -0400 - rev 461670
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
servo: Merge #20265 - Fix JS object conversion in unions (from Xanewok:fix-js-objects-in-unions); r=jdm <!-- Please describe your changes on the following line: --> Requires safe `Heap::boxed` constructor from https://github.com/servo/rust-mozjs/pull/395 (more info on it is in the PR). Since unions currently assume that their respective members root themselves and can be stored on heap, I modified the union member object conversion branch to convert to a `RootedTraceableBox<Heap<*mut JSObject>>` (which is the currently generated type for objects in said unions). I did it only for Unions and not dictionaries, since some dictionaries had bare `*mut JSObject` members - is this a mistake and something that needs further fixing? Does this need a test, e.g. passing a union with object to a function that returns said object, and comparing the results for equality? r? @jdm Generated code with this patch (for `StringOrObject`): ```rust impl FromJSValConvertible for StringOrObject { type Config = (); unsafe fn from_jsval(cx: *mut JSContext, value: HandleValue, _option: ()) -> Result<ConversionResult<StringOrObject>, ()> { if value.get().is_object() { match StringOrObject::TryConvertToObject(cx, value) { Err(_) => return Err(()), Ok(Some(value)) => return Ok(ConversionResult::Success(StringOrObject::Object(value))), Ok(None) => (), } } // (...) } } impl StringOrObject { // (...) unsafe fn TryConvertToObject(cx: *mut JSContext, value: HandleValue) -> Result<Option<RootedTraceableBox<Heap<*mut JSObject>>>, ()> { Ok(Some(RootedTraceableBox::from_box(Heap::boxed(value.get().to_object())))) } } ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #17011 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: e597cd9e1adc23ae30587ff6bffc05119ac33fb9
51b5d10855c9cce20abf96df79e91dc4176bb5bb: Bug 1445350 - fix browser_panelUINotifications_multiWindow.js so it doesn't fail on win10, r=dthayer
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 14 Mar 2018 13:18:35 +0000 - rev 461669
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445350 - fix browser_panelUINotifications_multiWindow.js so it doesn't fail on win10, r=dthayer MozReview-Commit-ID: Jk3ah2Xtr58
3a7a26b914ac50499ac4781e4ce6ce4fe3efbb3c: Bug 1444823 - Execute messageManager.sendAsyncMessage after runTest; r=jdescottes.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 14 Mar 2018 09:54:17 +0100 - rev 461668
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1444823 - Execute messageManager.sendAsyncMessage after runTest; r=jdescottes. MozReview-Commit-ID: Ansa6okYRg
4c204ccf3a7c511ce2cb33aec90dfbab0b3f082f: Bug 1445080 - fix handling of remote web progress for non-tab browsers, r=Gijs,mconley
Shane Caraveo <scaraveo@mozilla.com> - Wed, 14 Mar 2018 09:12:26 -0500 - rev 461667
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445080 - fix handling of remote web progress for non-tab browsers, r=Gijs,mconley Ensure remoteWebProgress is initialized for remote browsers. Includes devtools fix from jryans. MozReview-Commit-ID: Ce3TzwkNnyi
8e53f08e1d90e1036b75868a459addea99108c69: Bug 1437532 - prevent doing memset on a non-trivial type. r=jorendorff
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 13 Mar 2018 11:57:49 +0200 - rev 461666
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1437532 - prevent doing memset on a non-trivial type. r=jorendorff MozReview-Commit-ID: C8BfwJSHkWM
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip