120baee2ca230319136aae78661c57b012133ad9: Bug 1393399 P5 - report the recovery time telemetry; r=gerald
Kaku Kuo <kaku@mozilla.com> - Thu, 31 Aug 2017 18:02:06 +0800 - rev 427947
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1393399 P5 - report the recovery time telemetry; r=gerald MozReview-Commit-ID: 3Z0Esl1F6fV
00e03f0e1c1e6a7078f9680987ce42286612434c: Bug 1393399 P4 - implement GPUProcessCrashTelemetryLogger helper class; r=gerald
Kaku Kuo <kaku@mozilla.com> - Thu, 31 Aug 2017 17:56:17 +0800 - rev 427946
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1393399 P4 - implement GPUProcessCrashTelemetryLogger helper class; r=gerald GPUProcessCrashTelemetryLogger is used to report telemetry of the time used to recover a decoder from GPU crash. It uses MediaDecoderOwnerID to identify which video we're dealing with. It uses MediaDataDecoderID to make sure that the old MediaDataDecoder has been deleted and we're already recovered. It reports two recovery times, one is calculated from GPU crashed (that is, the time when VideoDecoderChild::ActorDestory() is called) and the other is calculated from the MFR is notified with NS_ERROR_DOM_MEDIA_NEED_NEW_DECODER error. MozReview-Commit-ID: 82BRc2Vs3cw
e3f58e6eeb8f3890673fc3795924dab52f135f83: Bug 1393399 P3 - keep the MediaDecoderOwner's identification in MFR; r=gerald
Kaku Kuo <kaku@mozilla.com> - Thu, 31 Aug 2017 17:31:51 +0800 - rev 427945
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1393399 P3 - keep the MediaDecoderOwner's identification in MFR; r=gerald When GPU process crashes, the MediaDecoder, MDSM, and MFR are all destroyed. So, we use MediaDecoderOwner to identify which video we're dealing with. MozReview-Commit-ID: 1cv08M7Cpcf
7de2b91cef4b8ab7a8e9caeabf294423e39d00b3: Bug 1393399 P2 - keep the GPU process crash time and send back to MFR; r=gerald
Kaku Kuo <kaku@mozilla.com> - Thu, 31 Aug 2017 17:21:28 +0800 - rev 427944
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1393399 P2 - keep the GPU process crash time and send back to MFR; r=gerald We keep the GPU crash time and send back to MFR through MediaResult. We cannot save the information in VideoDecoderChild as a static member because we are going to read it in MFR's task queue and the data was written in VideoDecoderManager's thread. This is going to be racing. MozReview-Commit-ID: FXqOgelWY6e
c88a7744a050eeb9597fedd9acf4836cbc9edecd: Bug 1393399 P1 - add telemetry probes; r=francois,gerald
Kaku Kuo <kaku@mozilla.com> - Fri, 01 Sep 2017 11:00:44 +0800 - rev 427943
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1393399 P1 - add telemetry probes; r=francois,gerald Here, we calculate the recovery time from two different start points because that when GPU crashes, VideoDecoderChild::ActorDestory() is called, but VideoDecoderChild doesn't dispatch events to trigger decoder recreation immediately. Instead, it waits until a new VideoDecoderManager has been recreated [1], and then rejects all pending promises to MFR with a NS_ERROR_DOM_MEDIA_NEED_NEW_DECODER, which triggers playback pipeline recreation. These two probes help us to know the gap between "GPU crash" and "MFR is notified". We don't need to wait for VideoDecoderManager recreation if we're certain that we don't create remote video decoder anymore. And if the gap is large, it might be a significant optimization. [1] http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/dom/media/ipc/VideoDecoderChild.cpp#124-145 MozReview-Commit-ID: DcI2CwWORxZ
38a6312f4f8c5aebb4b6ca1d205e1992b434b780: Bug 1393343 - move 'restore previous session' item into main menu and hide when auto-restore is enabled, r=mikedeboer
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 25 Aug 2017 11:40:49 +0100 - rev 427942
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1393343 - move 'restore previous session' item into main menu and hide when auto-restore is enabled, r=mikedeboer MozReview-Commit-ID: B3J9c936RL
1f29a8f5c69dd6b0937c3368b7d088454b8e65d1: servo: Merge #18351 - Refactor `.sort_by()` calls to use `.partial_cmp()` (from mateon1:profile-sort_by-partial_cmp); r=emilio
Mateusz Naściszewski <matin1111@wp.pl> - Sat, 02 Sep 2017 03:54:49 -0500 - rev 427941
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18351 - Refactor `.sort_by()` calls to use `.partial_cmp()` (from mateon1:profile-sort_by-partial_cmp); r=emilio Changes the closures passed to `sort_by` in this file with a simpler, and more correct version. Previously, potential NaNs in the array would float to the top. Either way, the program would crash, as the `get_statistics` function asserts the array it gets is sorted, which always fails with a NaN. Because of that, this change should not affect functionality. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because statistics collected by --profile should not have NaN values in the first place. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7dcd3ae50d090170fec4217248cc7864a1d2413a
4fb65ac5a58719f8afe0fe5e4056f7e8f40ad846: Bug 1374815 - fix sidebar hover styling and unify photon styling with the default, r=nhnt11
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 21 Aug 2017 17:37:27 +0100 - rev 427940
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1374815 - fix sidebar hover styling and unify photon styling with the default, r=nhnt11 This consolidates the photon styles into the old pre-photon styles, simplifying the CSS. As a result, it fixes the layout of the bookmarks menu as well. There's still some work left to do there to make submenus align properly with their parent once opened on Windows, but that isn't a regression caused by this bug so I am not addressing it here. I have deliberately not updated the checkmark besides aligning it properly on OS X - it seems we need more design details as to how that should look in the sidebar header menu as well as the bookmarks panel before changing that further (if indeed it does need further changes). MozReview-Commit-ID: JPl2VwUh3e1
f62dccfbc68e420b1a7538af09374e7edf446b25: Bug 1395527 part 2 - Delegate IsASCII and IsUTF8 to encoding_rs. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 01 Sep 2017 11:53:31 +0300 - rev 427939
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1395527 part 2 - Delegate IsASCII and IsUTF8 to encoding_rs. r=froydnj MozReview-Commit-ID: 49AGBPjW4Ca
06b701902e64ee55d8ce677ceee6db7fa7a1e44d: Bug 1395527 part 1 - Add microbenchmarks for IsASCII and IsUTF8. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 31 Aug 2017 14:46:25 +0300 - rev 427938
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1395527 part 1 - Add microbenchmarks for IsASCII and IsUTF8. r=froydnj MozReview-Commit-ID: 3oploVISQ3F
1fdc9b1dbb9e5b4f4ef03934dfa1827f3581d725: merge mozilla-central to autoland. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 02 Sep 2017 10:57:13 +0200 - rev 427937
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
merge mozilla-central to autoland. r=merge a=merge
b24a12ef6a1d0a5e00b3f72d5c6988070acdc0ec: servo: Merge #18350 - stylo: Expose -moz-system-metric and -moz-empty-except-children-with-localname (from emilio:ship-system-metric-stuff); r=bholley,manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 02 Sep 2017 02:49:29 -0500 - rev 427936
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18350 - stylo: Expose -moz-system-metric and -moz-empty-except-children-with-localname (from emilio:ship-system-metric-stuff); r=bholley,manishearth They don't have the flag in Gecko. Though I wonder if we could unship them from non-UA sheets. Bug: 1396048 Reviewed-by: bholley MozReview-Commit-ID: LGzGDjCZpJC Source-Repo: https://github.com/servo/servo Source-Revision: e0e09538fa97f5568c52266ee969ec21432e72f7
7a5f1092920acfd6bf70e055e40c96084185f258: Backed out changeset 820cb0437789 (bug 1394302) for failing new test, at least on Linux x64. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 02 Sep 2017 10:42:45 +0200 - rev 427935
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out changeset 820cb0437789 (bug 1394302) for failing new test, at least on Linux x64. r=backout
e990298e1596c5d5df0a73c929c0dacef88f5e53: Backed out changeset 40934888ed06 (bug 1395527) for Android bustage at uriloader/exthandler/android/nsMIMEInfoAndroid.cpp:62: too many arguments to function 'bool IsUTF8(const nsACString&)'. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 02 Sep 2017 10:39:06 +0200 - rev 427934
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out changeset 40934888ed06 (bug 1395527) for Android bustage at uriloader/exthandler/android/nsMIMEInfoAndroid.cpp:62: too many arguments to function 'bool IsUTF8(const nsACString&)'. r=backout
cae6eeaf3f0c73cb62b87f465e9dd69ea2132bd3: Backed out changeset d59b62713c66 (bug 1395527)
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 02 Sep 2017 10:38:20 +0200 - rev 427933
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Backed out changeset d59b62713c66 (bug 1395527)
d59b62713c66023954833e89374c5ecc2b92df72: Bug 1395527 part 2 - Delegate IsASCII and IsUTF8 to encoding_rs. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 01 Sep 2017 11:53:31 +0300 - rev 427932
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1395527 part 2 - Delegate IsASCII and IsUTF8 to encoding_rs. r=froydnj MozReview-Commit-ID: 49AGBPjW4Ca
40934888ed06465982350390750128f1dbdc831b: Bug 1395527 part 1 - Add microbenchmarks for IsASCII and IsUTF8. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 31 Aug 2017 14:46:25 +0300 - rev 427931
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1395527 part 1 - Add microbenchmarks for IsASCII and IsUTF8. r=froydnj MozReview-Commit-ID: 3oploVISQ3F
7c4c81a8b6996831b41b7a4865a7d7d04188887a: Bug 1393054 - Remove extra box-shadow from urlbar. r=dao
Dale Harvey <dale@arandomurl.com> - Fri, 01 Sep 2017 16:23:50 +0100 - rev 427930
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1393054 - Remove extra box-shadow from urlbar. r=dao MozReview-Commit-ID: GH1LAfxQ2kQ
230d2e70112d007d0f00711030c66ed7c295c314: servo: Merge #18340 - Use the better TokenStream API in dom_struct (from servo:dom-struct-errors); r=SimonSapin
Anthony Ramine <n.oxyde@gmail.com> - Sat, 02 Sep 2017 00:48:29 -0500 - rev 427929
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18340 - Use the better TokenStream API in dom_struct (from servo:dom-struct-errors); r=SimonSapin Before: ```rust error[E0412]: cannot find type `SourceBuffer` in this scope --> /Users/nox/src/servo/components/script/dom/mediasource.rs:25:1 | 25 | #[dom_struct] | ^^^^^^^^^^^^^ did you mean `SourceBufferList`? ``` After: ```rust error[E0412]: cannot find type `SourceBuffer` in this scope --> /Users/nox/src/servo/components/script/dom/mediasource.rs:28:39 | 28 | source_buffers: DOMRefCell<Vec<JS<SourceBuffer>>>, | ^^^^^^^^^^^^ did you mean `SourceBufferList`? ``` Source-Repo: https://github.com/servo/servo Source-Revision: 32b04b3f517cebcba34a23e6930860bbedb1431b
820cb0437789ef1d3c2aa054e803fa0203b45090: Bug 1394302 - stylo: Add mochitest; r=birtles
Manish Goregaokar <manishearth@gmail.com> - Thu, 31 Aug 2017 17:26:51 -0700 - rev 427928
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1394302 - stylo: Add mochitest; r=birtles MozReview-Commit-ID: DJ3zFqqMNXk
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip