11ec4393f23dfa2fd2c8cbe106d5a6126fe34885: Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:34 +0000 - rev 568118
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8 ContentTask tasks have a different lifetime than SpecialPowers tasks, with the former being tied to the lifetime of a message manager and the latter tied to the lifetime of a window global. That means that existing ContentTask callers which expect to be able to register load listeners before the creation of a window global, or which expect to persist after a page has navigated, won't work as SpecialPowers tasks. Since those sorts of tasks are not really resilient in the face of Fission, they should really be written to work differently, but this patch mostly just reverts them to using ContentTask for the time being. Differential Revision: https://phabricator.services.mozilla.com/D53744
c5404a7c286d356a7772c1155acce03d775c9695: Bug 1596918: Part 4b - Fix more ESLint issues after rewrite. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:34 +0000 - rev 568117
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 4b - Fix more ESLint issues after rewrite. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53743
7e9304405a465ac582fa2da5dbdb46887f6984fe: Bug 1596918: Part 4a - Re-add eslint-disable comments removed by rewrite. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:34 +0000 - rev 568116
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 4a - Re-add eslint-disable comments removed by rewrite. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53742
fa0f0aeabf99dd39169377f53781ed802e3236f8: Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:34 +0000 - rev 568115
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato Differential Revision: https://phabricator.services.mozilla.com/D53741
de196b077000731af0dd911d9e957b7b2d1b46e0: Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 19:11:58 +0000 - rev 568114
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato This is generally pretty straightforward, and rewrites nearly all calls. It skips the ones that it can detect using frame script globals like `sendAsyncMessage`, though. Differential Revision: https://phabricator.services.mozilla.com/D53740
e2312373dc55560eaee7f28ddd1bff4db06cf1f5: Bug 1596918: Part 2 - Add ESLint support for SpecialPowers.spawn globals. r=Standard8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:33 +0000 - rev 568113
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 2 - Add ESLint support for SpecialPowers.spawn globals. r=Standard8 This patch updates the existing ContentTask.spawn rule to do similar things for SpecialPowers.spawn calls, only with a slightly different set of globals. Differential Revision: https://phabricator.services.mozilla.com/D53739
5bae838f369c88fd0a703f4f1f684884359c9e29: Bug 1596918: Part 1e - Correctly handle query handlers throwing uncatchable exceptions. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:33 +0000 - rev 568112
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 1e - Correctly handle query handlers throwing uncatchable exceptions. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53738
1244972229bcc7ea55914ee9f93e4ad47065fc70: Bug 1596918: Part 1d - Fix some weird ChromeUtils.import calls. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:32 +0000 - rev 568111
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 1d - Fix some weird ChromeUtils.import calls. r=mccr8 This is somewhat unrelated, but I stumbled across it when writing part 1a, and it annoyed me. Differential Revision: https://phabricator.services.mozilla.com/D53737
d3ca99eedd7a69cd2c6720f77c8e7e14f10ba0d6: Bug 1596918: Part 1c - Make some more globals available to SpecialPowers.spawn tasks. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:32 +0000 - rev 568110
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 1c - Make some more globals available to SpecialPowers.spawn tasks. r=mccr8 A number of additional globals are available to ContentTask.spawn tasks compared to SpecialPowers.spawn tasks. Most of these are available by accident, as a side-effect of running in a shared frame script global, or being evaled in the context of the content-task.js frame script, but several of them are pretty broadly useful, or difficult to obtain from a Sandbox environment without reaching into arbitrary nearby globals. This patch adds some of the more useful ones to the default task environment. Differential Revision: https://phabricator.services.mozilla.com/D53736
1c0c0603f79f4e7ddb2cc0541e17ebed8bc676ba: Bug 1596918: Part 1b - Allow callers to automatically import JSMs for all SpecialPowers.spawn calls. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:32 +0000 - rev 568109
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 1b - Allow callers to automatically import JSMs for all SpecialPowers.spawn calls. r=mccr8 Some tests currently use an initial `ContentTask.spawn` call to import certain modules into the frame script global that subsequent tasks will run in. Since each `SpecialPowers.spawn` task runs in its own sandbox, this method doesn't work for them. This patch adds a helper, `SpecialPowers.addTaskImport`, which allows similar functionality by automatically importing the given module for any task spawned by the `SpecialPowers` instance it was called on. Differential Revision: https://phabricator.services.mozilla.com/D53735
8c1d67a0291435e500ae6d517855bf22aed7bf72: Bug 1596918: Part 1a - Add support for more assertion/info methods to SpecialPowers.spawn. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:44:32 +0000 - rev 568108
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1596918: Part 1a - Add support for more assertion/info methods to SpecialPowers.spawn. r=mccr8 ContentTask.spawn supports some common global mochitest assertion methods as aliases for corresponding Assert methods, along with espected-fail `todo` variants, and the `info` method for logging messages without triggering assertions. The easiest way to mass-convert existing callers is to just add support for these to SpecialPowers.spawn, which this patch does. Differential Revision: https://phabricator.services.mozilla.com/D53734
8d30b15ca8f932b30ffdf55910fe6e9e2036ca73: Bug 1486964 - Disable -moz-touch-enabled in all channels. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 07 Dec 2019 00:07:58 +0000 - rev 568107
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1486964 - Disable -moz-touch-enabled in all channels. r=hiro We've had it disabled on Nightly with no fallout for a while, and having it enabled breaks websites with touch screens as described in this bug and related ones. Given the above, let's disable it in all channels, and we'll remove the code in the next cycle. Differential Revision: https://phabricator.services.mozilla.com/D56264
aa4e0207b45fbab40ab0d310b67630c6aced6859: Bug 1588839 - Part 3: Preserve cross-process async stacks in sendQuery/sendAsyncMessage calls. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:59:23 +0000 - rev 568106
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1588839 - Part 3: Preserve cross-process async stacks in sendQuery/sendAsyncMessage calls. r=bzbarsky This makes it much simpler to track down the source of message handler errors by linking the cross-process caller chains which sent the problematic message. Differential Revision: https://phabricator.services.mozilla.com/D50883
c51a9a372a814900562f90376156528329d946c2: Bug 1588839 - Part 2: Return the actual rejection value when a sendQuery handler rejects. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:59:21 +0000 - rev 568105
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1588839 - Part 2: Return the actual rejection value when a sendQuery handler rejects. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D50882
e4783542b7c854ae4aa5cf60ac27e5e1ff19d56a: Bug 1588839 - Part 1 - Add helper to allow structured cloning Error/Exception objects. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 18:59:14 +0000 - rev 568104
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1588839 - Part 1 - Add helper to allow structured cloning Error/Exception objects. r=bzbarsky In order to be able to reasonably debug error results from things like JSWindowActor.sendQuery, we need to be able to clone errors across process boundaries, so that they can be propagated to the caller that initiated a query. The standard for the structured clone algorithm does not allow cloning errors directly, so this patch instead adds a chrome-only wrapper object which supports structured clone writing, and on reading, automatically decodes to the error object it wraps. Callers who wish to clone an Error or Exception object simply need to wrap it in a ClonedErrorHolder before sending. Differential Revision: https://phabricator.services.mozilla.com/D50881
df371f905d3afb90b216009a8d4fc4d78ad33ae2: Bug 1588839 - Part 0 - Add js::IsSavedFrame helper. r=jimb
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 17:45:53 +0000 - rev 568103
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1588839 - Part 0 - Add js::IsSavedFrame helper. r=jimb This is necessary for sanity checking values sent from content processes before using them with APIs which require SavedFrame objects. Differential Revision: https://phabricator.services.mozilla.com/D50880
ae020aef580f046a2e5277b726c3e2d4f50734e1: Backed out 6 changesets (bug 1595964, bug 1596939) for causing failures in browser_application_panel_list-domain-workers.js
Noemi Erli <nerli@mozilla.com> - Sat, 07 Dec 2019 20:13:22 +0200 - rev 568102
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Backed out 6 changesets (bug 1595964, bug 1596939) for causing failures in browser_application_panel_list-domain-workers.js Backed out changeset 65c870147654 (bug 1595964) Backed out changeset 74a982a9144a (bug 1596939) Backed out changeset c21c15689e77 (bug 1596939) Backed out changeset a6848f4d219d (bug 1596939) Backed out changeset 4f538e6c6dcc (bug 1595964) Backed out changeset d1c93f700b8c (bug 1595964)
8a2f3dae304dbf22bf8305dfaaf7db75a8a5aba9: Backed out 4 changesets (bug 1588839) for causing JSWindowActor.cpp failures CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Sat, 07 Dec 2019 19:41:36 +0200 - rev 568101
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Backed out 4 changesets (bug 1588839) for causing JSWindowActor.cpp failures CLOSED TREE Backed out changeset 7cfcd0f5da4f (bug 1588839) Backed out changeset cde41501372a (bug 1588839) Backed out changeset 65cc1910918c (bug 1588839) Backed out changeset 2f8b5b48c896 (bug 1588839)
7cfcd0f5da4f6b01c93697f5d212fe3db679df89: Bug 1588839 - Part 3: Preserve cross-process async stacks in sendQuery/sendAsyncMessage calls. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Mon, 02 Dec 2019 18:28:28 +0000 - rev 568100
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1588839 - Part 3: Preserve cross-process async stacks in sendQuery/sendAsyncMessage calls. r=bzbarsky This makes it much simpler to track down the source of message handler errors by linking the cross-process caller chains which sent the problematic message. Differential Revision: https://phabricator.services.mozilla.com/D50883
cde41501372a607c0b357ab844f87ce512bf8e51: Bug 1588839 - Part 2: Return the actual rejection value when a sendQuery handler rejects. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Sat, 07 Dec 2019 05:32:51 +0000 - rev 568099
Push 12493 by ffxbld-merge at Mon, 06 Jan 2020 15:38:57 +0000
Bug 1588839 - Part 2: Return the actual rejection value when a sendQuery handler rejects. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D50882
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip