0909753f32af7f9e38c7b66789e37546761dace8: Bug 1447889 part 10. Remove nsIDOMRange::DeleteContents. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:21 -0400 - rev 463672
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 10. Remove nsIDOMRange::DeleteContents. r=mystor MozReview-Commit-ID: IoXz0pS6zAa
5e13b554508bdd65da38da389e915877b95b87e0: Bug 1447889 part 9. Remove nsIDOMRange::CompareBoundaryPoints. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:21 -0400 - rev 463671
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 9. Remove nsIDOMRange::CompareBoundaryPoints. r=mystor MozReview-Commit-ID: 29swD9AoqoF
f9403cedcdb7fc23ba3a51678514f7aae8000e8f: Bug 1447889 part 8. Remove nsIDOMRange::SelectNode/SelectNodeContents. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:21 -0400 - rev 463670
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 8. Remove nsIDOMRange::SelectNode/SelectNodeContents. r=mystor MozReview-Commit-ID: 2hbF6pT31Xd
37568a081a19a8bd293d2c7a5554c094a40d9564: Bug 1447889 part 7. Remove nsIDOMRange::Collapse. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:21 -0400 - rev 463669
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 7. Remove nsIDOMRange::Collapse. r=mystor MozReview-Commit-ID: LLiXK8IpUdY
a55c7ad25f9a81d0451d7c9f191f976c617ab1d3: Bug 1447889 part 6. Remove nsIDOMRange::SetStart/End. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:21 -0400 - rev 463668
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 6. Remove nsIDOMRange::SetStart/End. r=mystor MozReview-Commit-ID: 8yOZMWBexsN
063c747e3f312941362a5f29ec2feed00c24f8f0: Bug 1447889 part 5. Remove nsIDOMRange::GetCommonAncestorContainer. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:21 -0400 - rev 463667
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 5. Remove nsIDOMRange::GetCommonAncestorContainer. r=mystor MozReview-Commit-ID: 18bnPYjRld5
a4caa4937a31727493981a6c130f704bea96b4c8: Bug 1447889 part 4. Remove nsIDOMRange::GetStart/EndContainer/Offset. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:21 -0400 - rev 463666
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 4. Remove nsIDOMRange::GetStart/EndContainer/Offset. r=mystor I got a bit carried away with fixing up consumers to use nsINode... But as a result removing these methods all together made sense. MozReview-Commit-ID: 2z9Q6D7GY92
85a5cd611076a9fbfd2659b286c6fa49f2f063a7: Bug 1447889 part 3. Use Selection and nsRange more in nsDocumentEncoder. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:20 -0400 - rev 463665
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 3. Use Selection and nsRange more in nsDocumentEncoder. r=mystor MozReview-Commit-ID: 2PYuoa1PFKL
2ca7872fa5b6ef0a99c334979229926f1084002b: Bug 1447889 part 2. Remove the XPCOM goop for creating Selection. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:20 -0400 - rev 463664
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 2. Remove the XPCOM goop for creating Selection. r=mystor It's unused; we never create these things by contract or classid. MozReview-Commit-ID: 3Jsyb6QHlJt
6c4b0fd365f2b2228546dd037e4f995168a497b7: Bug 1447889 part 1. Change nsCopySupport to work with Selection a bit more. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 00:35:20 -0400 - rev 463663
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447889 part 1. Change nsCopySupport to work with Selection a bit more. r=mystor MozReview-Commit-ID: B8HePBcalWU
898598ebe01890668a5a1d9288e5d64d54c29337: Bug 1449019. Actually propagate out exceptions from the innerHTML getter. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 26 Mar 2018 16:41:43 -0400 - rev 463662
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1449019. Actually propagate out exceptions from the innerHTML getter. r=smaug I moved the IgnoreErrors decl so it would come after the OOMReporter decl and I could add the new conversion operator. MozReview-Commit-ID: B1S6DXmZfvE
3dd5ec97e04873675c948ea790736c2a6639c3cb: Bug 1446686: Follow-up: Fix more Windows-only xpcshell failures. r=bustage
Kris Maglione <maglione.k@gmail.com> - Mon, 26 Mar 2018 21:22:19 -0700 - rev 463661
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1446686: Follow-up: Fix more Windows-only xpcshell failures. r=bustage MozReview-Commit-ID: 6IfIggPRCHq
aa72b81f6c65abe594eb94e9061329750f6edf08: Bug 1389585. Stop giving XPCJSID DOM_OBJECT classinfo. r=kmag
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 22 Mar 2018 17:08:44 -0400 - rev 463660
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1389585. Stop giving XPCJSID DOM_OBJECT classinfo. r=kmag These are not supposed to be exposed to content. MozReview-Commit-ID: 3odHUn4ZlG
47d8b357ce43b618d29fa3dc72928b67fcf21e1f: Bug 1445980 - TexStorage should validate both highest and lowest levels. - r=kvark
Jeff Gilbert <jgilbert@mozilla.com> - Mon, 26 Mar 2018 18:39:46 -0700 - rev 463659
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445980 - TexStorage should validate both highest and lowest levels. - r=kvark MozReview-Commit-ID: 3MtNEAtuadY
c1099e46e3e4488fba4e78bf8a843e0fee4cfe03: Bug 1446686: Follow-up: Fix Windows-only xpcshell failures. r=bustage
Kris Maglione <maglione.k@gmail.com> - Mon, 26 Mar 2018 19:50:10 -0700 - rev 463658
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1446686: Follow-up: Fix Windows-only xpcshell failures. r=bustage MozReview-Commit-ID: AIicV2wWcHB
16ac5bd4e50c50a62316828b586c5e7a60b28e99: Bug 1436655 - Introduce a mechanism for VarCache prefs to be defined entirely in the binary. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 26 Mar 2018 09:39:40 +1100 - rev 463657
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1436655 - Introduce a mechanism for VarCache prefs to be defined entirely in the binary. r=glandium Currently VarCache prefs are setup in two parts: - The vanilla pref part, installed via a data file such as all.js, or via an API call. - The VarCache variable part, setup by an Add*VarCache() call. Both parts are needed for the pref to actually operate as a proper VarCache pref. (There are various prefs for which we do one but not the other unless a certain condition is met.) This patch introduces a new way of doing things. There is a new file, modules/libpref/init/StaticPrefList.h, which defines prefs like this: > VARCACHE_PREF( > "layout.accessiblecaret.width", > layout_accessiblecaret_width, > float, 34.0 > ) This replaces both the existing parts. The preprocessor is used to generate multiple things from this single definition: - A global variable (the VarCache itself). - A getter for that global variable. - A call to an init function that unconditionally installs the pref in the prefs hash table at startup. C++ files can include the new StaticPrefs.h file to access the getter. Rust code cannot use the getter, but can access the global variable directly via structs.rs. This is similar to how things currently work for Rust code. Non-VarCache prefs can also be declared in StaticPrefList.h, using PREF instead of the VARCACHE_PREF. The new approach has the following advantages. + It eliminates the duplication (in all.js and the Add*VarCache() call) of the pref name and default value, preventing potential mismatches. (This is a real problem in practice!) + There is now a single initialization point for these VarCache prefs. + This avoids need to find a place to insert the Add*VarCache() calls, which are currently spread all over the place. + It also eliminates the common pattern whereby these calls are wrapped in a execute-once block protected by a static boolean (see bug 1346224). + It's no longer possible to have a VarCache pref for which only one of the pieces has been setup. + It encapsulates the VarCache global variable, so there is no need to declare it separately. + VarCache reads are done via a getter (e.g. StaticPrefs::foo_bar_baz()) instead of a raw global variable read. + This makes it clearer that you're reading a pref value, and easier to search for uses. + This prevents accidental writes to the global variable. + This prevents accidental mistyping of the pref name. + This provides a single chokepoint in the code for such accesses, which make adding checking and instrumentation feasible. + It subsumes MediaPrefs, and will allow that class to be removed. (gfxPrefs is a harder lift, unfortunately.) + Once all VarCache prefs are migrated to the new approach, the VarCache mechanism will be better encapsulated, with fewer details publicly visible. + (Future work) This will allow the pref names to be stored statically, saving memory in every process. The main downside of the new approach is that all of these prefs are in a single header that is included in quite a few places, so any changes to this header will cause a fair amount of recompilation. Another minor downside is that all VarCache prefs are defined and visible from start-up. For test-only prefs like network.predictor.doing-tests, having them show in about:config isn't particularly useful. The patch also moves three network VarCache prefs to the new mechanism as a basic demonstration. (And note the inconsistencies in the multiple initial values that were provided for network.auth.subresource-img-cross-origin-http-auth-allow!) There will be numerous follow-up bugs to convert the remaining VarCache prefs. MozReview-Commit-ID: 9ABNpOR16uW * * * [mq]: fixup MozReview-Commit-ID: 6ToT9dQjIAq
08af6778dd6a669e896d61ef7599a75d7024d5fd: Bug 1436655 - Tweak assertions in Add*VarCache() functions. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 23 Mar 2018 15:15:20 +1100 - rev 463656
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1436655 - Tweak assertions in Add*VarCache() functions. r=glandium This avoids some repetition. MozReview-Commit-ID: I7aD8JUCCK4
8509ebf8fbb3af7e580c85aa73d5bb4a9b78c61a: Bug 1436655 - Tweak the comment at the top of init/all.js. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 15 Mar 2018 14:59:29 +1100 - rev 463655
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1436655 - Tweak the comment at the top of init/all.js. r=glandium - The first two SYNTAX HINTS are wrong, and citing the syntax is more useful than specifying a single example of what isn't allowed. - The sentence about #ifdefs is wrong. (#ifdefs appear all throughout, and prefs are only specified once.) - I chose a better example file. MozReview-Commit-ID: JyYFyutqrFD
c34cc8156a71b1feab6cf4351b80ac60cd12cc78: Bug 1436655 - Rename pref_SetPref()'s aFromFile argument as aFromInit. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 14 Feb 2018 18:50:53 +1100 - rev 463654
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1436655 - Rename pref_SetPref()'s aFromFile argument as aFromInit. r=glandium Currently all pref initialization is done from file, but soon we will also be initializing prefs from code compiled into the binary. The new name encompasses both cases. MozReview-Commit-ID: 5g0jfjHTvnE
7e5efe49f034c364260d5f1e0964060693c50d7e: Bug 1446686: Follow-up: Fix pending permission prompts when prompt is dismissed. r=bustage
Kris Maglione <maglione.k@gmail.com> - Mon, 26 Mar 2018 19:06:00 -0700 - rev 463653
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1446686: Follow-up: Fix pending permission prompts when prompt is dismissed. r=bustage MozReview-Commit-ID: 35tW39omECd
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip