0524b54f7f9dc0568a55b5d70fef4180d4cb1838: Backed out changeset 6d539e4a02bd (bug 1403519) for lint failures on a CLOSED TREE
Margareta Eliza Balazs <ebalazs@mozilla.com> - Thu, 11 Jan 2018 22:32:27 +0200 - rev 450675
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Backed out changeset 6d539e4a02bd (bug 1403519) for lint failures on a CLOSED TREE
8339907be1cd8fecad418fcb53b1a79a80f3852d: Bug 1422934 - Remove unused toolbarbutton-image binding. r=Gijs
Ian Moody <moz-ian@perix.co.uk> - Tue, 12 Dec 2017 15:38:51 +0000 - rev 450674
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1422934 - Remove unused toolbarbutton-image binding. r=Gijs MozReview-Commit-ID: 2BkLRnYXtMm
a6346aa459b3f7cc7895f8e7a45609519448a603: Bug 1422934 - Make the tab close button an image, and remove the extends from its binding. r=dao,Gijs
Ian Moody <moz-ian@perix.co.uk> - Thu, 11 Jan 2018 16:12:07 +0000 - rev 450673
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1422934 - Make the tab close button an image, and remove the extends from its binding. r=dao,Gijs MozReview-Commit-ID: HF0Rqeq8fh8
4bf890d844160b066ab43007f798e6d49029a5a4: Bug 1429819: Allow using tooltool macOS SDK on all automation builds, not just cross-builds; r=dminor
Tom Prince <mozilla@hocat.ca> - Thu, 11 Jan 2018 09:23:16 -0700 - rev 450672
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1429819: Allow using tooltool macOS SDK on all automation builds, not just cross-builds; r=dminor MozReview-Commit-ID: IFIS8vZLgd4
6d539e4a02bd5a819c798c16ffc2fdbe9fb5fab2: Bug 1403519 - only build docs when necessary r=gps
Dustin J. Mitchell <dustin@mozilla.com> - Mon, 02 Oct 2017 18:22:56 +0000 - rev 450671
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1403519 - only build docs when necessary r=gps This marks **/docs/** as exclusively docs, and code that is autodoc'd as inclusively docs. That means that a change that purely modifies documentation files will *only* run `docs` tasks, while a change that modifies autodoc'd source code will *additionaly* run `docs` tasks. The tasks do not run by default. MozReview-Commit-ID: G9tOK0AwtrI
ea45022c163ec2fd9a2ce9c5444d1593b9c8aa9d: Bug 1429529 - Use the same cache for lazy pseudos and anonymous boxes. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Jan 2018 11:04:23 -0800 - rev 450670
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1429529 - Use the same cache for lazy pseudos and anonymous boxes. r=emilio MozReview-Commit-ID: FaSK8RAlrW2
85f9b85ae324a57ed28c1c268d96bd80eefd17da: Bug 1429529 - Rename CachedAnonBoxStyles to CachedInheritingStyles. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Jan 2018 10:57:12 -0800 - rev 450669
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1429529 - Rename CachedAnonBoxStyles to CachedInheritingStyles. r=emilio MozReview-Commit-ID: xgZbalAJ5x
a8e7f7f28f7e1010039927ac6b87c1647338f89c: servo: Merge #19748 - Adjust size of gecko ComputedValues struct for removal of separate lazy pseudo cache (from bholley:remove_lazy_pseudo_cache); r=emilio
Bobby Holley <bobbyholley@gmail.com> - Thu, 11 Jan 2018 12:16:01 -0600 - rev 450668
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
servo: Merge #19748 - Adjust size of gecko ComputedValues struct for removal of separate lazy pseudo cache (from bholley:remove_lazy_pseudo_cache); r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1429529 Source-Repo: https://github.com/servo/servo Source-Revision: 005dc85a888b1c73a849bb7b4e2f7d9d22321909
1250522ac71228c83d1f7f16eb34819056e26b72: Bug 1429580 - Remove now-unnecessary inherited_status argument. r=dbaron
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 11 Jan 2018 09:53:10 -0500 - rev 450667
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1429580 - Remove now-unnecessary inherited_status argument. r=dbaron Because of the previous patch, the inherited_status is now always EXPECTED_PASS so we don't need to actually pass it around. MozReview-Commit-ID: pgMkLgNCOE
c177a92b17cced94752f8343073a4d24a9e168dc: Bug 1429580 - Change the semantics of skipping reftest includes. r=dbaron
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 11 Jan 2018 09:53:10 -0500 - rev 450666
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1429580 - Change the semantics of skipping reftest includes. r=dbaron Without this patch, putting something like skip-if(Android) include foo/reftest.list behaves unexpectedly. Instead of skipping the foo/reftest.list file on Android, it instead "inherits" the skip-if condition down into each reftest inside foo/reftest.list. If any of those reftests then have a fuzzy or fuzzy-if(Android,...) annotation, that will override the skip-if annotation, and the test will still run. Based on the occurrences of this pattern in the codebase, I believe the more intuitive semantics of "skip the foo/reftest.list file completely, on Android" is more desirable. This patch implements the change in semantics. It also disallows inheriting other statuses down into included reftest.list files, such as from a fails or fuzzy annotation on the include statement. These cases don't currently exist in the tree, but any attempt to do so will now throw an error. MozReview-Commit-ID: HLJuSYNHvU5
6e926521ce37cadc4fcbd3451542a7975446311e: Bug 1416879 - Part 0d: Move browser_multie10s_update.js into its own directory. r=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Thu, 11 Jan 2018 10:31:17 -0500 - rev 450665
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 0d: Move browser_multie10s_update.js into its own directory. r=bkelly This test is unfortunately a victim of a multi-e10s unregister() race from browser_force_refresh and given the imminent multi-e10s cleanup that's going to happen, the more complicated alternatives aren't worth the effort versus just moving this test to its own directory. ..and now it's disabled too. Bug 1429794 tracks re-enabling.
7d66c4b6ab0d7dbea4ae2ebd7b843e0e7f95d057: Bug 1416879 - Part 0c: browser_multie10s_update.js should not use setTimeout. r=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Tue, 09 Jan 2018 17:31:01 -0500 - rev 450664
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 0c: browser_multie10s_update.js should not use setTimeout. r=bkelly This test used a fixed setTimeout of 3secs for serving the SW. This lower-bounded the test runtime at 6 seconds, plus it was not safe in the event of a slow test runner. This set of changes, although a little ugly, improves the logic so that the SW's transmission is driven by a separate "release" fetch that is only triggered when both updates have been issued and the first update failure has been reported. This ensures we are observing the desired situation. There's also a sanity check on the number of times the SW script is fetched.
c3bc48075e7447581a4ffd4a4bd8ed60b3d9945f: Bug 1416879 - Part 0b: browser_multie10s_update.js needs to protect its invariants, clean-up after itself. r=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Tue, 09 Jan 2018 16:16:24 -0500 - rev 450663
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 0b: browser_multie10s_update.js needs to protect its invariants, clean-up after itself. r=bkelly
db45cca5049e0869d0561c009b6e0496e339f8d0: Bug 1416879 - Part 0a: Make browser_force_refresh.js clean up after itself. r=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Wed, 10 Jan 2018 12:38:25 -0500 - rev 450662
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 0a: Make browser_force_refresh.js clean up after itself. r=bkelly
1cc9cf654ea3bad4ce3a0e4e41d616da0c997625: Bug 1416879 - Part 6: Test cancellation of diverted client-intercepted streams. r=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:38:43 -0500 - rev 450661
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 6: Test cancellation of diverted client-intercepted streams. r=bkelly This adds a test where we have a ServiceWorker return 2 different types of streams that Firefox recognizes as downloads which are handled by diversion of the channel to the parent. The diverted downloads are then cancelled and we verify that cancellation actually results in the underlying connections being closed and/or the ServiceWorker notified. Our 2 types of streams are: 1. A pass-through stream that is incrementally delivered through use of an .sjs file that delivers data using setInterval. 2. A SW-authored ReadableStream (which is not enabled by default, so we set a pref.) Determining when the .sjs's stream is canceled is accomplished by opening a second "monitor" connection that only completes when the streaming connection is closed. In all cases we differentiate between cancelation and timeouts firing.
0cd43f3de5fb904e27d0dfefdfc10d1c58fea9da: Bug 1416879 - Part 5: FetchStreamReader needs to cancel its reader when it encounters write errors. r=baku, f=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:09:32 -0500 - rev 450660
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 5: FetchStreamReader needs to cancel its reader when it encounters write errors. r=baku, f=bkelly Currently, FetchStreamReader never signals to the JS stream code that the reader has been closed. This means that when a ServiceWorker passes a ReadableStream to respondWith and the HTTP Channel gets canceled, the JS code will keep generating the stream without ever realizing the data's not going anywhere. It's necessary to cancel the reader. Or do something like that, this seems to work!
58c617de48f4b47ffc4cd0f3f03537ff9baa0576: Bug 1416879 - Part 4: FetchDriver needs to propagate write failures. r=baku
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:04:55 -0500 - rev 450659
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 4: FetchDriver needs to propagate write failures. r=baku In the scenario where a ServiceWorker returns a pass-through fetch via `evt.respondWith(fetch("underlying"))`, in order for the "underlying" HTTP channel to be canceled when the outer HTTP channel is canceled, FetchDriver's OnDataAvailable method needs to return an error when the output pipe experiences an error. Unfortunately, the contract for ReadSegments is effectively that it returns NS_OK regardless of what the rv of the write handler returned, so relying on the returned rv is insufficient. And because various Write*() methods will all fast-path to returning NS_OK if a count of 0 is passed, it's necessary to infer a closed/broken pipe by noticing that we tried to write more than 0 bytes of data but 0 bytes were written. (This is safe because the pipe we write into was created by FetchDriver::OnStartRequest which explicitly creates an infinite pipe, so it's not possible for the write to fail due to lack of space in the pipe.)
f4ebb9ec34523bfd24d86b3769e5f4185db25d25: Bug 1416879 - Part 3: (Also Bug 1418795) SyntheticDiversionListener should handle !mIPCOpen. r=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 13:59:13 -0500 - rev 450658
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 3: (Also Bug 1418795) SyntheticDiversionListener should handle !mIPCOpen. r=bkelly The SyntheticDiversionListener needs to handle the case where the IPC connection is gone. This patch avoids calling Send* methods which will crash the content process if the actor has already been destroyed. Additionally, OnDataAvailable will return an error in such a case so that the caller can properly handle the error rather than continuing to attempt to send data to a listener that doesn't care. This latter change is an artifact of a previous hack attempt to fix a related diversion issue that is probably not required for this stack, but makes sense as a fix, so I've left it in.
7052da34a62d03ad510ad273f8cad970157fd5ba: Bug 1416879 - Part 2: Allow for diversion cancellation and trigger for intercepted channels. r=bkelly, r=mayhemer
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:38:07 -0500 - rev 450657
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 2: Allow for diversion cancellation and trigger for intercepted channels. r=bkelly, r=mayhemer The diversion mechanism never expected to be dealing with data sourced from the content process, but that's exactly what happens with ServiceWorker-intercepted channels with the current child-intercept situation (which is being fixed). In order to allow timely cancellation of diverted intercepted channels, there needs to be a way to relay to the HttpChannelChild that it needs to be canceled so that the synthesized pump can be canceled and diversion can be marked as complete. This patch adds such a mechanism to ADivertableParentChannel and PHttpChannel for the exclusive use of InterceptedHttpChannel and then uses it.
e3b4b0f2a73c7a6fdcf1389e08ed5f59487a0f3e: Bug 1416879 - Part 1: DivertComplete should only be sent at OnStopRequest for synthesized responses. r=bkelly
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:56:46 -0500 - rev 450656
Push 8531 by ryanvm@gmail.com at Fri, 12 Jan 2018 16:47:01 +0000
Bug 1416879 - Part 1: DivertComplete should only be sent at OnStopRequest for synthesized responses. r=bkelly Diversion for intercepted channels with a synthesized response is a special case. It is not appropriate to send DivertComplete when mEventQ has been drained, because we are not dealing with the usual mEventQ-enqueued OnDataAvailable payloads that had been received over the network and sent down to the child. In this case, all the data originates in the child and does not go through mEventQ. As such, the correct place to send DivertComplete is at OnStopComplete for the synthesized response.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip