034009ae72f7b070da0471d1101607cc8b70eed3: Bug 1402170 - Update some test descriptions; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:54:50 +0900 - rev 434835
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402170 - Update some test descriptions; r=hiro * We should refer to reading or accessing properties, as opposed to "considering" them. * We should use "property-indexed" consistently. MozReview-Commit-ID: ItCE4g8LmOC
204dc1bf9d016d134868fdb718092151c1a53fa7: Bug 1402170 - Drop invalid test for offsets; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:43:11 +0900 - rev 434834
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402170 - Drop invalid test for offsets; r=hiro There is a test that assumes that an offset specified on a property-indexed keyframe is applied to all generated keyframes but that behavior is not (yet) specified. This behavior will be specified in [1] but until that happens it seems invalid to test for it. Furthermore, when that is specified we will need much more thorough tests than this one. [1] https://github.com/w3c/web-animations/issues/148 MozReview-Commit-ID: HUUw88dg2P7
94a49bab02b04dba65c49f9f7877b2842d59d69a: Bug 1402170 - Use template strings in processing-a-keyframes-argument.html; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:38:58 +0900 - rev 434833
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402170 - Use template strings in processing-a-keyframes-argument.html; r=hiro But only in a couple of places where it makes the test more readable. MozReview-Commit-ID: 6zVJ6h7Zb3k
5951672afb9de5259431f7ee033e7f8ec7aff0a3: Bug 1402170 - Use for...of instead of forEach for several tests in processing-a-keyframes-argument.html; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:36:42 +0900 - rev 434832
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402170 - Use for...of instead of forEach for several tests in processing-a-keyframes-argument.html; r=hiro for...of is generally preferred over forEach since it is a little easier to read and allows using 'break' and 'continue'. Furthermore it is supported in all major browsers. (It also makes wrapping one of the long lines in this file easier.) MozReview-Commit-ID: 1BuoW0QSxaG
98fdad40074629c703ab3d0ad74a6bc86082c3e0: Bug 1402170 - Use ES6 let/const in processing-a-keyframes-argument.html; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:09:04 +0900 - rev 434831
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402170 - Use ES6 let/const in processing-a-keyframes-argument.html; r=hiro Gradually we plan to move all these tests to ES6 (or at least the subset supported by all UAs that are likely to implement this spec) so while we are touching this file we update a few uses of 'var' to let/const. MozReview-Commit-ID: 45OJyXmUzKu
bf76291acd21aa8f347ff6ab051414d97ef99246: Bug 1402170 - Consistently use KeyframeEffect constructor for testing in processing-a-keyframes-argument.html; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:03:35 +0900 - rev 434830
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402170 - Consistently use KeyframeEffect constructor for testing in processing-a-keyframes-argument.html; r=hiro KeyframeEffectReadOnly may disappear (see [1]) and is only needed for CSS Animations and CSS Transitions so in that sense KeyframeEffect is more basic (despite being a subclass of KeyframeEffectReadOnly) so we should prefer it to KeyframeEffectReadOnly. Furthermore, as the comment at the start of the file suggests, we should consistently use the same method for testing these procedures. We currently use the KeyframeEffect constructor because it is more direct and basic. [1] https://github.com/w3c/web-animations/issues/185 MozReview-Commit-ID: LBrlfzyn2Ch
1fef0a3277d121232832e913565b7728aaa6a934: Bug 1402170 - Fix title in processing-a-keyframes-argument.html test; r=hiro
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 10:18:25 +0900 - rev 434829
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402170 - Fix title in processing-a-keyframes-argument.html test; r=hiro And also drop the slightly misleading and redundant comment about the procedure that this test covers (it covers *both* the "process a keyframes argument" procedure and the "process a keyframe-like object" subprocedure). MozReview-Commit-ID: 9lzx4rCj20o
f68820e4cee93585ca35d86124987efb7652166a: No bug - Revendor rust dependencies
Servo VCS Sync <servo-vcs-sync@mozilla.com> - Mon, 02 Oct 2017 23:33:01 +0000 - rev 434828
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
No bug - Revendor rust dependencies
557a4ad274edd02d4e9a9b09c427c1da44d4adfd: Bug 1405004 - Remove unused imports from testing/marionette/element.js. r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 02 Oct 2017 17:20:57 +0100 - rev 434827
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405004 - Remove unused imports from testing/marionette/element.js. r=whimboo MozReview-Commit-ID: 7EoehdeV8tf
91b6b53a5a72a273bd8c4bd64aa753b199716bb0: Bug 1402499 - Simplify HTMLAnchorElement CC macros; r=bz
Kyle Machulis <kyle@nonpolynomial.com> - Fri, 29 Sep 2017 12:04:09 -0700 - rev 434826
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402499 - Simplify HTMLAnchorElement CC macros; r=bz The HTMLAnchorElement macros were basically a verbose version of the CYCLE_COLLECTION_INHERITED helper macros. MozReview-Commit-ID: 1bxuKdWUMlG
5b86711934302fe448e18838fdd64fe843e244d8: Bug 1402499 - Add NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0 r=bz
Kyle Machulis <kyle@nonpolynomial.com> - Thu, 28 Sep 2017 23:21:09 -0700 - rev 434825
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1402499 - Add NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0 r=bz Add macro for nsISupports inheriting classes that need cycle collection and only inherit from one parent, with no interface table needed. Takes care of map and addref/release calls. MozReview-Commit-ID: LtTwYH0DeEz
cdfdf17a19eb426ebeae35b32e6e45d1027e0fb5: Merge m-c to autoland, a=merge CLOSED TREE
Wes Kocher <wkocher@mozilla.com> - Mon, 02 Oct 2017 16:26:42 -0700 - rev 434824
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Merge m-c to autoland, a=merge CLOSED TREE MozReview-Commit-ID: HeJwJwwTzhQ
610baed314d5ec561a692cdab3460b36cc1163ff: Bug 1403997 - Still run `mach artifact toolchain` when no tooltool manifest is set but MOZ_TOOLCHAINS is. r=mshal
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Sep 2017 10:17:03 +0900 - rev 434823
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1403997 - Still run `mach artifact toolchain` when no tooltool manifest is set but MOZ_TOOLCHAINS is. r=mshal Bug 1382564 made the `mach artifact toolchain` invocations from mozharness use the MOZ_TOOLCHAINS environment variable when it's set by taskcluster through the decision task, so that toolchain dependencies from the task graph are used, but the mozharness code is still skipping mach artifact toolchain when MOZ_TOOLCHAINS is set but there is no tooltool manifest set. Most jobs today still have a tooltool manifest set, but jobs shouldn't need a dummy tooltool manifest to use toolchain dependencies automatically.
a2a7b3161ac39f0a051cf53135fc477c9cee2afd: Backed out 2 changesets (bug 1305237) for bc failures in browser_WebRequest_ancestors.js a=backout
Wes Kocher <wkocher@mozilla.com> - Mon, 02 Oct 2017 13:35:03 -0700 - rev 434822
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Backed out 2 changesets (bug 1305237) for bc failures in browser_WebRequest_ancestors.js a=backout Backed out changeset 163a2b0bb0a0 (bug 1305237) Backed out changeset e05bab140564 (bug 1305237) MozReview-Commit-ID: GLlbWYZqyVS
cab06f0f811af8048994fdcc876584e59b3c788a: Bug 1403961, part 2 - Fix and enable eslint for ipc/. r=billm
Andrew McCreight <continuation@gmail.com> - Fri, 29 Sep 2017 09:46:32 -0700 - rev 434821
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1403961, part 2 - Fix and enable eslint for ipc/. r=billm After the previous patch, all that is needed to pass eslint is some whitespace fixes I generated using: ./mach eslint --fix ipc The .eslintrc.js file makes eslint expect XPCShell global variables. With those two changes, eslint can be enabled for the ipc/ directory. MozReview-Commit-ID: BqSICp2iV6O
6201576b6471c092a32f637abb7225410f9b9eef: Bug 1403961, part 1 - Don't load test_ipcshell_child.js from test_ipcshell.js. r=billm
Andrew McCreight <continuation@gmail.com> - Fri, 29 Sep 2017 09:52:23 -0700 - rev 434820
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1403961, part 1 - Don't load test_ipcshell_child.js from test_ipcshell.js. r=billm I don't fully understand what this test is trying to do, but as far as I can see, test_ipcshell_child.js does nothing when loaded from test_ipcshell.js besides define a few variables, so just define them directly in test_ipcshell.js. I am doing this because eslint does not like the way the test is currently written: the definition of runtime in another file confuses it, and it does not like the assignment to run_test. MozReview-Commit-ID: Ek0HY9n49eZ
07e7579a07bea02815132822c018ffc3699e0312: Bug 1385398 - Change the appearance of CSS shapes highlighter markers. r=pbro
Mike Park <mikeparkms@gmail.com> - Fri, 28 Jul 2017 15:28:08 -0400 - rev 434819
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1385398 - Change the appearance of CSS shapes highlighter markers. r=pbro MozReview-Commit-ID: JO4TZ1Gsr6m
3d80498e2f75e1365a84fd9aaa8194229e411c89: Bug 1394005 Fix overloaded-virtual warnings in FilterNodeD2D1 r=froydnj
Tom Ritter <tom@mozilla.com> - Fri, 29 Sep 2017 11:12:38 -0500 - rev 434818
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1394005 Fix overloaded-virtual warnings in FilterNodeD2D1 r=froydnj This warning is telling us that we have declared a function in a derived class with the same name as a virtual function in a base class. The base class functions can never be called. In FilterNodeD2D1 we intend to do this (the base class methods are all MOZ_CRASH). We silence the warning by importing those functions as private so they cannot be called. MozReview-Commit-ID: 6ENLKFMMBRy
42e5371334d998003e6059035c17a2852f7417b4: Bug 1399334 - Workaround buggy pki.js cert verifier implementation r=keeler
J.C. Jones <jjones@mozilla.com> - Mon, 02 Oct 2017 11:06:31 -0700 - rev 434817
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1399334 - Workaround buggy pki.js cert verifier implementation r=keeler There's an intermittent on the call attestationCert.verify() to test the self- signed cert from our not-shipped software U2F implementation. Collection of the intermittents shows these certs are fine, and should verify correctly, but they don't. The bug must be in pki.js, which is out-of-scope as we only use it for mochitests. This patch removes the offending call to xxxx.verify(), because it doesn't really matter whether the self-signed-cert looks OK to pki.js; we just need the public key from inside it to proceed with the rest of the tests. As an example of a so-called "invalid" self-signed cert that failed, we have: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=134282931&lineNumber=2673 -----BEGIN CERTIFICATE----- MIIBMTCB2aADAgECAgUA55x6LTAKBggqhkjOPQQDAjAhMR8wHQYDVQQDExZGaXJl Zm94IFUyRiBTb2Z0IFRva2VuMB4XDTE3MDkzMDE5MjIzMloXDTE3MTAwMjE5MjIz MlowITEfMB0GA1UEAxMWRmlyZWZveCBVMkYgU29mdCBUb2tlbjBZMBMGByqGSM49 AgEGCCqGSM49AwEHA0IABIWu4L8ky7s8I7qVv+JwMRHpippH4b6h7rN0jlKpFbHK hnEwaCPLrTx04Eh9xT4GK9JWuuP759hnAxsWD5wk0H0wCgYIKoZIzj0EAwIDRwAw RAIgRIeRcn6LkwU8VOmX+mdQ3jUQrUOp5f2xH/qBECGi5EcCIADBjsm/EDKkAwLZ pGdX7+N+kgf9No4uuLV4dsNVJ1pa -----END CERTIFICATE----- There's nothing wrong with this cert, actually. Checking it with OpenSSL shows all OK: openssl verify -purpose any -CAfile /tmp/cert2.pem /tmp/cert2.pem /tmp/cert2.pem: OK So this intermittent is a bug outside of our U2F and U2F test soft token code. MozReview-Commit-ID: K142toVWtcv
c13f5102b030016333714932043cce744963973d: Bug 1400457 - Isolate VR Rendering from Compositor r=daoshengmu,jgilbert
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Fri, 21 Jul 2017 17:30:34 -0700 - rev 434816
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1400457 - Isolate VR Rendering from Compositor r=daoshengmu,jgilbert - WebVR is no longer dependent on PTexture, TextureParent, TextureHost, and TextureChild. It continues to use TextureClient for pooling and coordinating locks with other Gecko code. - PreserveDrawingBuffer now behaving correctly for 2d display mirroring - Preparation for separating to VR process MozReview-Commit-ID: 2RGOulCInSu
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip