007f59cfee3b8ab36730b7ee50d658fa714b663c: Backed out 2 changesets (bug 1516325) for xpcshell failures in netwerk/test/unit/test_udpsocket.js. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Wed, 06 Mar 2019 20:51:39 +0200 - rev 520550
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Backed out 2 changesets (bug 1516325) for xpcshell failures in netwerk/test/unit/test_udpsocket.js. CLOSED TREE Backed out changeset 7f9508dc59e1 (bug 1516325) Backed out changeset 28eb88277ffc (bug 1516325)
19d2e4ea75cfc67ad9a43fb704d91a7a485ea3bb: Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Wed, 06 Mar 2019 01:06:46 +0000 - rev 520549
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb I don't understand how the test ever worked. I think the idea was that each operation would result in changes to the prefs, because those prefs are the source of truth for the recent-files list. However, I don't understand why some tests would not trigger multiple observer callbacks, which should have been a huge mess. The new code doesn't observe the prefs at all. Where possible, it waits for an appropriate promise; in other places it uses `setTimeout()` to wait for the next tick, relying on the Scratchpad implementation to be done reacting by then. Since the original code was event-driven, most tests were split across two functions. Each test function had the bottom half of one test and the top half of the next test. The new code uses async/await and can therefore at least group related functionality into single cohesive test functions. But those test functions aren't as independent as they look -- most of them still depend on previous tests to set up the expected starting state. Differential Revision: https://phabricator.services.mozilla.com/D20759
af3e74a36fecd705da30496a44865a3a25d4ef6b: Bug 1525395 - Part 1: Make Scratchpad.openFile return a promise. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Wed, 06 Mar 2019 01:06:31 +0000 - rev 520548
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525395 - Part 1: Make Scratchpad.openFile return a promise. r=jimb Tests can use the promise to avoid racing on the text being available and the UI ready for interaction. Differential Revision: https://phabricator.services.mozilla.com/D20758
e9364ffb92a61f92c6c0989f546ac899b08fb3cf: Bug 1531350 - Add column breakpoints (w/ fix for sourcemaps-reload). r=loganfsmyth
Jason Laster <jlaster@mozilla.com> - Wed, 06 Mar 2019 17:00:37 +0000 - rev 520547
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531350 - Add column breakpoints (w/ fix for sourcemaps-reload). r=loganfsmyth Differential Revision: https://phabricator.services.mozilla.com/D22329
7b44e98a5576d5805fb642c47efa2ba28a999347: Bug 1529863 - Remove remnants of unused browser.firstrun and browser.snippets prefs. r=geckoview-reviewers,whimboo,esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 06 Mar 2019 14:59:46 +0000 - rev 520546
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1529863 - Remove remnants of unused browser.firstrun and browser.snippets prefs. r=geckoview-reviewers,whimboo,esawin "browser.firstrun.*" seems to have been unused since the end of XUL-based Fennec, whereas the code referencing the "browser.snippets.*" prefs was removed in bug 1482836. Differential Revision: https://phabricator.services.mozilla.com/D20862
1bc91e8030f2b143fc23431e56b49faed564adcc: Bug 1528252: about:profiles should restart into the same profile rather than allowing profile selection to re-run. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 06 Mar 2019 17:56:56 +0000 - rev 520545
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528252: about:profiles should restart into the same profile rather than allowing profile selection to re-run. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D22340
351c542d6e4576a5e9e9b0035dc4780783054e58: Bug 1533070 - Get rid of static initializers in GC.cpp by marking some functions/statics constexpr. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Mar 2019 17:38:11 +0000 - rev 520544
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1533070 - Get rid of static initializers in GC.cpp by marking some functions/statics constexpr. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D22335
608ca009efdfd35fc49127b47bb13a57df6f7273: Bug 1523996 - part 5 - bulk-read/write adjacent POD fields in IPDL-defined structs; r=Alex_Gaynor
Nathan Froyd <froydnj@gmail.com> - Wed, 06 Mar 2019 13:59:57 +0000 - rev 520543
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523996 - part 5 - bulk-read/write adjacent POD fields in IPDL-defined structs; r=Alex_Gaynor Now that fields are packed nicely, we can take advantage of the contiguous layout of POD fields and read/write all the POD fields of a given size in a single read/write call. For many structs, this should have little or no effect, but for large structs such as LoadInfoArgs, this reduces the number of function calls by ~50%. Differential Revision: https://phabricator.services.mozilla.com/D22001
90d17458ca5425d50a0d58ad59ec227a3458890e: Bug 1523996 - part 4 - add static assertions for member layout; r=Alex_Gaynor
Nathan Froyd <froydnj@gmail.com> - Wed, 06 Mar 2019 13:59:48 +0000 - rev 520542
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523996 - part 4 - add static assertions for member layout; r=Alex_Gaynor We're about to start depending on how the fields are packed in a future patch, so we should add some compile-time checking that our assertions are correct. Differential Revision: https://phabricator.services.mozilla.com/D22000
1746c87bdd261f2254909bb25d0c15091ec1e545: Bug 1523996 - part 3 - factor out reading/writing sentinels; r=Alex_Gaynor
Nathan Froyd <froydnj@gmail.com> - Wed, 06 Mar 2019 13:59:43 +0000 - rev 520541
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523996 - part 3 - factor out reading/writing sentinels; r=Alex_Gaynor We're going to read and write sentinels slightly differently for bulk-writing adjacent fields, so let's factor out some reusable code for doing so. Differential Revision: https://phabricator.services.mozilla.com/D21999
5a1bb4076f8fd77e616fa54dbd85812285ef303f: Bug 1523996 - part 2 - pack IPDL-defined struct members better; r=Alex_Gaynor
Nathan Froyd <froydnj@gmail.com> - Wed, 06 Mar 2019 13:59:39 +0000 - rev 520540
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523996 - part 2 - pack IPDL-defined struct members better; r=Alex_Gaynor This patch changes the layout of IPDL-defined structs to order the POD members by decreasing size, which ensures everything is packed well. This optimization is only applied to the internal representation; the external interface (e.g. constructors) is entirely unchaged. Differential Revision: https://phabricator.services.mozilla.com/D21998
318d0fe526a048c5340bf6095b1d567d1d60bdc4: Bug 1523996 - part 1 - compute a packed ordering for structure fields; r=Alex_Gaynor
Nathan Froyd <froydnj@gmail.com> - Wed, 06 Mar 2019 13:59:35 +0000 - rev 520539
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523996 - part 1 - compute a packed ordering for structure fields; r=Alex_Gaynor This patch computes an ordering for the fields of an IPDL structure decl such that they are packed well in memory. We'll take advantage of this ordering in future patches. Differential Revision: https://phabricator.services.mozilla.com/D21997
632248682d293fdc5f47aa5dc78ea4718bd0239b: Bug 1532098 - Update login instead delete then add. r=nalexander
Edouard Oger <eoger@fastmail.com> - Wed, 06 Mar 2019 17:52:30 +0000 - rev 520538
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532098 - Update login instead delete then add. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D22346
783538d74b6ab0dbffd89ac71eda0d8952394037: Backed out changeset 39c2628de53e (bug 1522919) for browser chrome failures at content/test/trackingUI/browser_trackingUI_cryptominers.js on a CLOSED TREE
Coroiu Cristina <ccoroiu@mozilla.com> - Wed, 06 Mar 2019 20:08:47 +0200 - rev 520537
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Backed out changeset 39c2628de53e (bug 1522919) for browser chrome failures at content/test/trackingUI/browser_trackingUI_cryptominers.js on a CLOSED TREE
d3a4d053ea82a628f822d15bc20162236a25f69d: Bug 1533040 - Remove invalid NS_WARNING_ASSERTION. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Mar 2019 17:13:14 +0000 - rev 520536
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1533040 - Remove invalid NS_WARNING_ASSERTION. r=dholbert We can totally get there with a negative percentage basis, see comment 0 for an example. We could keep the warning like: NS_WARNING_ASSERTION(clamping_mode == StyleAllowedNumericType::All || basis >= 0, "nscoord overflow?"); Which will catch cases where the style system would refuse to parse a negative <length-percentage>, but we got a negative percent basis, which would be weird. But that's a bit misleading since right now at least we rely on the caller to do the appropriate clamping. I also think that NS_WARNING_ASSERTION is not very useful, since we're not very likely to catch stuff with it. But anyhow, your call. Differential Revision: https://phabricator.services.mozilla.com/D22328
b0eb4c7230e4ea766b6997c95c1a84592cfc4d3a: Bug 1528955 - Tab successfully pinned notification r=dao
Ricky Rosario <rickyrosario@gmail.com> - Wed, 06 Mar 2019 15:34:34 +0000 - rev 520535
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528955 - Tab successfully pinned notification r=dao MozReview-Commit-ID: IUKhiRvDsqZ Differential Revision: https://phabricator.services.mozilla.com/D21393
af9d2cb592c57c93a00af43061cb1b1d4e30ac40: Bug 1515210 - Build openh264 plugin for win64-aarch64; r=Callek
Dan Minor <dminor@mozilla.com> - Wed, 06 Mar 2019 17:12:40 +0000 - rev 520534
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1515210 - Build openh264 plugin for win64-aarch64; r=Callek Differential Revision: https://phabricator.services.mozilla.com/D21782
9f8a1b41032052121d45540b57db45710011820e: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 16 - Always grant storage permission for storage-access door hanger, r=johannh
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 06 Mar 2019 17:05:35 +0000 - rev 520533
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 16 - Always grant storage permission for storage-access door hanger, r=johannh Differential Revision: https://phabricator.services.mozilla.com/D22273
0ef284a9a1d5ae82ec404a6935fc7272eb3484df: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 15 - Comments, r=asuth
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 06 Mar 2019 17:05:17 +0000 - rev 520532
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 15 - Comments, r=asuth Differential Revision: https://phabricator.services.mozilla.com/D21906
835e5f642a03df66f2240dd174a42fe203e4d372: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 06 Mar 2019 17:04:55 +0000 - rev 520531
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D21697
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip