author Ted Mielczarek <>
Tue, 11 Sep 2018 13:31:20 -0400
changeset 491555 e186d8665b004ef0c016b861a56c4de1103bd1cf
parent 485348 997fd8419a4b28cdaaf3263e88dcad585ccfb101
child 492540 a1c1e2f201a73f1e82701d08b42dc9ae3da24ee0
permissions -rw-r--r--
Bug 1399877 - globally define MOZ_DLL_PREFIX/MOZ_DLL_SUFFIX; r=gps Several source files use DLL_PREFIX/DLL_SUFFIX defines, and they all set them in using `DEFINES`. This is problematic for the WSL build because the quoting gets lost somewhere between bash and cl.exe. We cannot simply set them globally in moz.configure because their stringified definitions would conflict with the `set_config` of DLL_PREFIX/DLL_SUFFIX. Therefore, we globally define MOZ_DLL_PREFIX/MOZ_DLL_SUFFIX and change all define-related uses of DLL_PREFIX/DLL_SUFFIX to use their MOZ-equivalents instead.

# -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
# vim: set filetype=python:
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at

with Files("**"):
    BUG_COMPONENT = ("Core", "Security: PSM")





DIRS += [


if CONFIG['CC_TYPE'] == 'clang-cl':
    # -Wall on clang-cl maps to -Weverything, which turns on way too
    # much, so we're using -W4 instead, which is mapped to clang's
    # -Wall -Wextra.
    CXXFLAGS += ['-W4']
    CXXFLAGS += ['-Wall']

if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl'):
    # -Wall with Visual C++ enables too many problematic warnings
    CXXFLAGS += [
        '-wd4324', # structure was padded due to __declspec(align())
        '-wd4355', # 'this' used in base member initializer list
        '-wd4464', # relative include path contains '..'
        '-wd4480', # nonstandard extension used: specifying underlying type for
                   # enum 'enum'
        '-wd4481', # nonstandard extension used: override specifier 'keyword'
        '-wd4510', # default constructor could not be generated
        '-wd4512', # assignment operator could not be generated
        '-wd4514', # 'function': unreferenced inline function has been removed
        '-wd4610', # struct 'symbol' can never be instantiated - user defined
                   # constructor required
        '-wd4619', # pragma warning: there is no warning 'warning'
        '-wd4623', # default constructor could not be generated because a base
                   # class default constructor is inaccessible or deleted
        '-wd4625', # copy constructor could not be generated because a base
                   # class copy constructor is inaccessible or deleted
        '-wd4626', # assignment operator could not be generated because a base
                   # class assignment operator is inaccessible or deleted
        '-wd4628', # digraphs not supported with -Ze (nsThreadUtils.h includes
                   # what would be the digraph "<:" in the expression
                   # "mozilla::EnableIf<::detail::...". Since we don't want it
                   # interpreted as a digraph anyway, we can disable the
                   # warning.)
        '-wd4640', # construction of local static object is not thread-safe
        '-wd4710', # 'function': function not inlined
        '-wd4711', # function 'function' selected for inline expansion
        '-wd4820', # 'bytes' bytes padding added after construct 'member_name'

    # MSVC 2010's headers trigger these
    CXXFLAGS += [
        '-wd4548', # expression before comma has no effect; ...
        '-wd4668', # 'symbol' is not defined as a preprocessor macro...
        '-wd4987', # nonstandard extension used

    # MSVC 2015 triggers these
    CXXFLAGS += [
        '-wd4456', # declaration of 'rv' hides previous local declaration
        '-wd4458', # declaration of 'input' hides class member

    # The following warnings are disabled because MSVC 2017 headers aren't
    # warning free at the -Wall level.
    CXXFLAGS += [
        '-wd4061', # enumerator 'identifier' in switch of enum 'enumeration' is
                   # not explicitly handled by a case label
        '-wd4365', # 'action' : conversion from 'type_1' to 'type_2',
                   # signed/unsigned mismatch
        '-wd4774', # '<function>' : format string expected in argument
                   # <position> is not a string literal

    # Gecko headers aren't warning-free enough for us to enable these warnings
    CXXFLAGS += [
        '-wd4100', # 'symbol' : unreferenced formal parameter
        '-wd4127', # conditional expression is constant
        '-wd4946', # reinterpret_cast used between related types

if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
    CXXFLAGS += [

    # Gecko headers aren't warning-free enough for us to enable these warnings.
    CXXFLAGS += [


if CONFIG['CC_TYPE'] == 'clang-cl':
    AllowCompilerWarnings()  # workaround for bug 1090497