author Nika Layzell <>
Tue, 25 Sep 2018 17:34:53 +0200
changeset 504874 e0f95dd96d5458f60980f1e8b3f846beed6e5817
parent 504105 b6c97b4db60a1d8169a3e798a248144ab2973506
permissions -rw-r--r--
Bug 1448426 - Wrap windows.h to avoid problematic define statements, r=froydnj,glandium By default, windows.h exposes a large number of problematic define statements which are UpperCamelCase, such as a define from `CreateWindow` to `CreateWindow{A,W}`. As many of these names are generic (e.g. CreateFile, CreateWindow), they can mess up Gecko code that may legitimately have its own methods with the same names. The header also defines some traditional SCREAMING_SNAKE_CASE defines which can mess up our code by conflicting with local values. This patch adds a simple code generator which generates wrappers for these defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers` mechanism, allowing us to use windows.h in more places. Differential Revision:

/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at */

#ifndef mozilla_windows_h
#define mozilla_windows_h

// Include the "real" windows.h header. On clang/gcc, this can be done with the
// `include_next` feature, however MSVC requires a direct include path.
// Also turn off deprecation warnings, as we may be wrapping deprecated fns.

#if defined(__GNUC__) || defined(__clang__)
#  pragma GCC system_header
#  include_next <windows.h>

#  pragma GCC diagnostic push
#  pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#  include <${header_path}>

#  pragma warning(push)
#  pragma warning(disable: 4996 4995)
#endif // defined(__GNUC__) || defined(__clang__)

// Check if the header should be disabled
#define MOZ_WINDOWS_WRAPPER_DISABLED_REASON "explicitly disabled"

#elif !defined(__cplusplus)
#define MOZ_WINDOWS_WRAPPER_DISABLED_REASON "non-C++ source file"

#elif !defined(__GNUC__) && !defined(__clang__) && !defined(_DLL)

// We're allowed to wrap in the current context. Define `MOZ_WRAPPED_WINDOWS_H`
// to note that fact, and perform the wrapping.
extern "C++" {


} // extern "C++"
#endif // enabled

#if defined(__GNUC__) || defined(__clang__)
#  pragma GCC diagnostic pop
#  pragma warning(pop)
#endif // defined(__GNUC__) || defined(__clang__)

#endif // !defined(mozilla_windows_h)