author Nicholas Nethercote <>
Thu, 22 Jun 2017 17:08:53 +1000
changeset 414698 aa1693a26a15eb5cba24102222687dc81eeddd7b
parent 412434 e155fa765af299f0e8cfb42e0a1709e5b04928b9
child 422972 fdf9ccb0b9abace19f58a41f7ef209fefaf784db
permissions -rw-r--r--
Bug 1375392 - Tweak the PROFILER_LABEL* macros. r=mstange. This patch makes the following changes to the macros. - Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was mostly misused. - Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is universally available now anyway. - Combines the first two string literal arguments of PROFILER_LABEL and PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for them to be separate, and it forced a '::' in the label, which isn't always appropriate. Also, the meaning of the "name_space" argument was interpreted in an interesting variety of ways. - Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make it clearer they construct RAII objects rather than just being function calls. (I myself have screwed up the scoping because of this in the past.) - Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so the caller doesn't need to. This makes a *lot* more of the uses fit onto a single line. The patch also makes the following changes to the macro uses (beyond those required by the changes described above). - Fixes a bunch of labels that had gotten out of sync with the name of the class and/or function that encloses them. - Removes a useless PROFILER_LABEL use within a trivial scope in EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving any useful purpose. It also serves as extra evidence that the AUTO_ prefix is a good idea. - Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is done within them, instead of at their callsites, because that's a more standard way of doing things.

# -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
# vim: set filetype=python:
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at


DIRS += [

DIRS += [

EXPORTS.mozilla += [


with Files("**"):
    BUG_COMPONENT = ("Core", "Internationalization")

with Files("icu/**"):
    BUG_COMPONENT = ("Core", "JavaScript: Internationalization API")

with Files("icu-patches/**"):
    BUG_COMPONENT = ("Core", "JavaScript: Internationalization API")

with Files("tzdata/**"):
    BUG_COMPONENT = ("Core", "JavaScript: Internationalization API")

with Files("update*"):
    BUG_COMPONENT = ("Core", "JavaScript: Internationalization API")

with Files(""):
    BUG_COMPONENT = ("Core", "Build Config")