author Ricky Stewart <>
Mon, 26 Oct 2020 18:34:53 +0000
changeset 620830 994ae8e4833c90447d91f0e26a718573cff5a514
parent 620590 9006d6f3cb29754037aa0b5ef4c9b2ae67006459
permissions -rw-r--r--
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly. To produce this patch I did all of the following: 1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions. 2. Run ./mach lint --linter black --fix 3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/ -- it has some hard-coded line numbers that the reformat breaks. 4. Make some ad-hoc manual updates to `testing/marionette/client/`, `testing/marionette/harness/`, and `testing/firefox-ui/harness/`, which have hard-coded regexes that break after the reformat. 5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023). # ignore-this-changeset Differential Revision:

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at

from __future__ import absolute_import, print_function

from contextlib import contextmanager
import os
import subprocess
import sys

from mozbuild.util import (
import mozpack.path as mozpath

def gradle_lock(topobjdir, max_wait_seconds=600):
    # Building the same Gradle root project with multiple concurrent processes
    # is not well supported, so we use a simple lock file to serialize build
    # steps.
    lock_path = "{}/gradle/mach_android.lockfile".format(topobjdir)
    lock_instance = lock_file(lock_path, max_wait=max_wait_seconds)

        del lock_instance

def android(verb, *args):
    import buildconfig

    with gradle_lock(buildconfig.topobjdir):
        cmd = [
            mozpath.join(buildconfig.topsrcdir, "mach"),
        env = dict(os.environ)
        # Confusingly, `MACH` is set only within `mach build`.
        if env.get("MACH"):
            env["GRADLE_INVOKED_WITHIN_MACH_BUILD"] = "1"
        if env.get("LD_LIBRARY_PATH"):
            del env["LD_LIBRARY_PATH"]
        subprocess.check_call(cmd, env=env)

        return 0

def assemble_app(dummy_output_file, *inputs):
    return android("assemble-app")

def generate_sdk_bindings(dummy_output_file, *args):
    return android("generate-sdk-bindings", *args)

def generate_generated_jni_wrappers(dummy_output_file, *args):
    return android("generate-generated-jni-wrappers", *args)