xpcom/tests/SizeTest05.cpp
author Doug Thayer <dothayer@mozilla.com>
Fri, 01 Mar 2019 18:29:09 +0000
changeset 520116 8b3fe0426ffc1b3a2ad044ef6cdde6c4f736f8e2
parent 507657 09c71a7cf75aeaf2963050e315276fb9a866fd62
permissions -rw-r--r--
Bug 1442694 - Fix failures due to removing selected tab r=Gijs This adds test which reproduce the failure as well as the fix. Essentially, if we hit the edited case in SessionStore with `tab` equal to `tabbrowser.tabs[t]`, we remove the tab and then try to pin it, which obviously blows up. Note: the additional method in SessionStore.jsm was largely to get around complexity requirements inside restoreWindow. Cleaner solutions welcome. Differential Revision: https://phabricator.services.mozilla.com/D21383

// Test05.cpp

#include "nsINode.h"
#include "nsCOMPtr.h"

NS_DEF_PTR(nsINode);

/*
        Windows:
                raw, nsCOMPtr           21 bytes

        Macintosh:
                Raw, nsCOMPtr           64 bytes
*/

class Test05_Raw {
 public:
  Test05_Raw();
  ~Test05_Raw();

  void /*nsresult*/ GetNode(nsINode** aNode);

 private:
  nsINode* mNode;
};

Test05_Raw::Test05_Raw() : mNode(0) {
  // nothing else to do here
}

Test05_Raw::~Test05_Raw() { NS_IF_RELEASE(mNode); }

void  // nsresult
Test05_Raw::GetNode(nsINode** aNode)
// m64, w21
{
  //		if ( !aNode )
  //			return NS_ERROR_NULL_POINTER;

  *aNode = mNode;
  NS_IF_ADDREF(*aNode);

  //		return NS_OK;
}

class Test05_nsCOMPtr {
 public:
  void /*nsresult*/ GetNode(nsINode** aNode);

 private:
  nsCOMPtr<nsINode> mNode;
};

void  // nsresult
Test05_nsCOMPtr::GetNode(nsINode** aNode)
// m64, w21
{
  //		if ( !aNode )
  //			return NS_ERROR_NULL_POINTER;

  *aNode = mNode;
  NS_IF_ADDREF(*aNode);

  //		return NS_OK;
}