widget/xremoteclient/DBusRemoteClient.h
author Doug Thayer <dothayer@mozilla.com>
Fri, 01 Mar 2019 18:29:09 +0000
changeset 520116 8b3fe0426ffc1b3a2ad044ef6cdde6c4f736f8e2
parent 505383 6f3709b3878117466168c40affa7bca0b60cf75b
child 520621 35287afd3acea1602bed159dc879aa666e64b9c8
permissions -rw-r--r--
Bug 1442694 - Fix failures due to removing selected tab r=Gijs This adds test which reproduce the failure as well as the fix. Essentially, if we hit the edited case in SessionStore with `tab` equal to `tabbrowser.tabs[t]`, we remove the tab and then try to pin it, which obviously blows up. Note: the additional method in SessionStore.jsm was largely to get around complexity requirements inside restoreWindow. Cleaner solutions welcome. Differential Revision: https://phabricator.services.mozilla.com/D21383

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#ifndef DBusRemoteClient_h__
#define DBusRemoteClient_h__

#include "nsRemoteClient.h"
#include "mozilla/StaticPtr.h"
#include "mozilla/DBusHelpers.h"
#include "nsString.h"

class DBusRemoteClient : public nsRemoteClient {
 public:
  DBusRemoteClient();
  ~DBusRemoteClient();

  virtual nsresult Init() override;
  virtual nsresult SendCommandLine(const char *aProgram, const char *aUsername,
                                   const char *aProfile, int32_t argc,
                                   char **argv, const char *aDesktopStartupID,
                                   char **aResponse, bool *aSucceeded) override;
  void Shutdown();

 private:
  bool GetRemoteDestinationName(const char *aProgram, const char *aProfile,
                                nsCString &aDestinationName);
  nsresult DoSendDBusCommandLine(const char *aProgram, const char *aProfile,
                                 const char *aBuffer, int aLength);
  RefPtr<DBusConnection> mConnection;
};

#endif  // DBusRemoteClient_h__