build/clang-plugin/ExplicitOperatorBoolChecker.cpp
author Sylvestre Ledru <sledru@mozilla.com>
Fri, 20 Oct 2017 19:11:50 +0200
changeset 438229 88c9b8587db69f36601f45e6584ac2d1c5e459b5
parent 372503 20134b5c4194fc6ed826e1f22dc2e4afd3b68cdc
child 492757 e3118f787e336e908dd7a8f42d71211cb8738bfe
permissions -rw-r--r--
Bug 1410472 - clang-plugin follows the LLVM coding style for real r=mystor MozReview-Commit-ID: AXrQEjWzxvg

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "ExplicitOperatorBoolChecker.h"
#include "CustomMatchers.h"

void ExplicitOperatorBoolChecker::registerMatchers(MatchFinder *AstMatcher) {
  // Older clang versions such as the ones used on the infra recognize these
  // conversions as 'operator _Bool', but newer clang versions recognize these
  // as 'operator bool'.
  AstMatcher->addMatcher(
      cxxMethodDecl(anyOf(hasName("operator bool"), hasName("operator _Bool")))
          .bind("node"),
      this);
}

void ExplicitOperatorBoolChecker::check(
    const MatchFinder::MatchResult &Result) {
  const CXXConversionDecl *Method =
      Result.Nodes.getNodeAs<CXXConversionDecl>("node");
  const CXXRecordDecl *Clazz = Method->getParent();

  if (!Method->isExplicitSpecified() &&
      !hasCustomAnnotation(Method, "moz_implicit") &&
      !ASTIsInSystemHeader(Method->getASTContext(), *Method) &&
      isInterestingDeclForImplicitConversion(Method)) {
    diag(Method->getLocStart(), "bad implicit conversion operator for %0",
         DiagnosticIDs::Error)
        << Clazz;
    diag(Method->getLocStart(), "consider adding the explicit keyword to %0",
         DiagnosticIDs::Note)
        << "'operator bool'";
  }
}