build/clang-plugin/RefCountedCopyConstructorChecker.cpp
author tbirdbld
Fri, 29 Sep 2017 14:28:53 -0400
branchTHUNDERBIRD560b4_2017092914_RELBRANCH
changeset 431997 71be2f51b22facc814d651770be0be6c1137404b
parent 372499 8222951c9369ca13c6358bc32c9d5da6c6c2289b
child 438229 88c9b8587db69f36601f45e6584ac2d1c5e459b5
permissions -rw-r--r--
Added THUNDERBIRD_56_0b4_RELEASE THUNDERBIRD_56_0b4_BUILD9 tag(s) for changeset 12ee272c0d2e. DONTBUILD CLOSED TREE a=release

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "RefCountedCopyConstructorChecker.h"
#include "CustomMatchers.h"

void RefCountedCopyConstructorChecker::registerMatchers(MatchFinder* AstMatcher) {
  AstMatcher->addMatcher(
      cxxConstructExpr(
          hasDeclaration(cxxConstructorDecl(isCompilerProvidedCopyConstructor(),
                                            ofClass(hasRefCntMember()))))
          .bind("node"),
      this);
}

void RefCountedCopyConstructorChecker::check(
    const MatchFinder::MatchResult &Result) {
  const char* Error =
      "Invalid use of compiler-provided copy constructor on refcounted type";
  const char* Note =
      "The default copy constructor also copies the "
      "default mRefCnt property, leading to reference "
      "count imbalance issues. Please provide your own "
      "copy constructor which only copies the fields which "
      "need to be copied";

  // Everything we needed to know was checked in the matcher - we just report
  // the error here
  const CXXConstructExpr *E = Result.Nodes.getNodeAs<CXXConstructExpr>("node");

  diag(E->getLocation(), Error, DiagnosticIDs::Error);
  diag(E->getLocation(), Note, DiagnosticIDs::Note);
}