build/clang-plugin/ExplicitImplicitChecker.cpp
author tbirdbld
Fri, 29 Sep 2017 14:28:53 -0400
branchTHUNDERBIRD560b4_2017092914_RELBRANCH
changeset 431997 71be2f51b22facc814d651770be0be6c1137404b
parent 372499 8222951c9369ca13c6358bc32c9d5da6c6c2289b
child 438229 88c9b8587db69f36601f45e6584ac2d1c5e459b5
permissions -rw-r--r--
Added THUNDERBIRD_56_0b4_RELEASE THUNDERBIRD_56_0b4_BUILD9 tag(s) for changeset 12ee272c0d2e. DONTBUILD CLOSED TREE a=release

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "ExplicitImplicitChecker.h"
#include "CustomMatchers.h"

void ExplicitImplicitChecker::registerMatchers(MatchFinder* AstMatcher) {
  AstMatcher->addMatcher(cxxConstructorDecl(isInterestingImplicitCtor(),
                                            ofClass(allOf(isConcreteClass(),
                                                          decl().bind("class"))),
                                            unless(isMarkedImplicit()))
                            .bind("ctor"),
                        this);
}

void ExplicitImplicitChecker::check(
    const MatchFinder::MatchResult &Result) {
  // We've already checked everything in the matcher, so we just have to report
  // the error.

  const CXXConstructorDecl *Ctor =
      Result.Nodes.getNodeAs<CXXConstructorDecl>("ctor");
  const CXXRecordDecl *Declaration =
      Result.Nodes.getNodeAs<CXXRecordDecl>("class");

  diag(Ctor->getLocation(), "bad implicit conversion constructor for %0",
       DiagnosticIDs::Error) << Declaration->getDeclName();
  diag(Ctor->getLocation(), "consider adding the explicit keyword to the constructor",
       DiagnosticIDs::Note);
}