author Chris Peterson <cpeterson@mozilla.com>
Thu, 22 Feb 2018 21:03:45 -0800
changeset 459227 6650c3db53ec00d4e8e8cee800755607fe7f08f5
parent 459104 edecd8ff53bbba54fa02542be98d03f4305698df
child 482908 5649e60770c84c40a5234df4adfc3daf3e6ea6e8
permissions -rw-r--r--
Bug 1443402 - Fix some -Wmissing-prototypes warnings in layout. r=dholbert -Wmissing-prototypes is a new optional warning available in clang ToT. It warns about global functions that have no previous function declaration (e.g. from an #included header file). These functions can probably be made static (allowing the compiler to better optimize them) or they may be unused. Confusingly, clang's -Wmissing-prototypes is equivalent to gcc's -Wmissing-declarations, not gcc's -Wmissing-prototypes. A function prototype is a function declaration that specifies the function's argument types. C++ requires that all function declarations specify their argument types, but C does not. As such, gcc's -Wmissing-prototypes is a C-only warning about C functions that have no previous function *prototypes* (with argument types), even if a previous function *declaration* (without argument types) was seen. MozReview-Commit-ID: FGKVLzeQ2oK