author Matt Howell <mhowell@mozilla.com>
Wed, 22 Aug 2018 20:38:12 +0000
changeset 488033 202f0986f4599698554946394d878597b7263484
parent 471851 b7832a2c2c296390c57c1261d805759530020b26
permissions -rw-r--r--
Bug 1485484 - Always fill in the optional third parameter to ApplicationID::Set. r=agashlin In theory, the third parameter (dualMode) to the NSIS ApplicationID plugin's Set function is optional, but the plugin assumes that either it's there or there's nothing else on the NSIS stack, so it pops three items from the stack unconditionally. This means that supplying only two parameters results in one item silently being dropped from the NSIS stack. Fortunately this one function is the only place where we were doing that, so it only became a problem if there were an awful lot of shortcuts (around 7) to the same installation. Differential Revision: https://phabricator.services.mozilla.com/D4009

  "phabricator.uri" : "https://phabricator.services.mozilla.com/",
  "repository.callsign": "MOZILLACENTRAL",
  "history.immutable": false