author Johnny Stenback <>
Tue, 30 Jul 2013 17:46:46 -0700
changeset 152958 018ef921c94581b572db7a8644674c1cc9421853
parent 150129 571787c979259c1af862ea8d8dc595e6950c8aa2
child 155699 eba687b0842e08891dc1a07716ea77d81ed45dbc
permissions -rw-r--r--
Bug 898906. Fix this bug by making nsMimeType objects hold their active plugin alive, and rely on the cycle collector to break the explicit reference cycle. r=mccr8 --- dom/base/crashtests/898906.html | 14 ++++++++++++++ dom/base/crashtests/crashtests.list | 3 ++- dom/base/nsMimeTypeArray.cpp | 2 +- dom/base/nsMimeTypeArray.h | 14 ++++++-------- dom/base/nsPluginArray.cpp | 24 +----------------------- dom/base/nsPluginArray.h | 2 -- 6 files changed, 24 insertions(+), 35 deletions(-) create mode 100644 dom/base/crashtests/898906.html

/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=2 sw=2 et tw=79: */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at */

#ifndef nsMimeTypeArray_h___
#define nsMimeTypeArray_h___

#include "nsString.h"
#include "nsCOMPtr.h"
#include "nsTArray.h"
#include "nsWeakReference.h"
#include "nsWrapperCache.h"
#include "nsPluginArray.h"

class nsPIDOMWindow;
class nsMimeType;

class nsMimeTypeArray MOZ_FINAL : public nsISupports,
                                  public nsWrapperCache
  nsMimeTypeArray(nsWeakPtr aWindow);
  virtual ~nsMimeTypeArray();


  nsPIDOMWindow* GetParentObject() const;
  virtual JSObject* WrapObject(JSContext* aCx,
                               JS::Handle<JSObject*> aScope) MOZ_OVERRIDE;

  void Refresh();

  // MimeTypeArray WebIDL methods
  nsMimeType* Item(uint32_t index);
  nsMimeType* NamedItem(const nsAString& name);
  nsMimeType* IndexedGetter(uint32_t index, bool &found);
  nsMimeType* NamedGetter(const nsAString& name, bool &found);
  uint32_t Length();
  void GetSupportedNames(nsTArray< nsString >& retval);

  void EnsureMimeTypes();
  void Clear();

  nsWeakPtr mWindow;

  // mMimeTypes contains all mime types handled by plugins followed by
  // any other mime types that we handle internally and have been
  // looked up before.
  nsTArray<nsRefPtr<nsMimeType> > mMimeTypes;

  // mPluginMimeTypeCount is the number of plugin mime types that we
  // have in mMimeTypes. The plugin mime types are always at the
  // beginning of the list.
  uint32_t mPluginMimeTypeCount;

class nsMimeType MOZ_FINAL : public nsWrapperCache

  nsMimeType(nsWeakPtr aWindow, nsPluginElement* aPluginElement,
             uint32_t aPluginTagMimeIndex, const nsAString& aMimeType);
  nsMimeType(nsWeakPtr aWindow, const nsAString& aMimeType);
  virtual ~nsMimeType();

  nsPIDOMWindow* GetParentObject() const;
  virtual JSObject* WrapObject(JSContext* aCx,
                               JS::Handle<JSObject*> aScope) MOZ_OVERRIDE;

  const nsString& Type() const
    return mType;

  // MimeType WebIDL methods
  void GetDescription(nsString& retval) const;
  nsPluginElement *GetEnabledPlugin() const;
  void GetSuffixes(nsString& retval) const;
  void GetType(nsString& retval) const;

  nsWeakPtr mWindow;

  // Strong reference to the active plugin, if any. Note that this
  // creates an explicit reference cycle through the plugin element's
  // mimetype array. We rely on the cycle collector to break this
  // cycle.
  nsRefPtr<nsPluginElement> mPluginElement;
  uint32_t mPluginTagMimeIndex;
  nsString mType;

#endif /* nsMimeTypeArray_h___ */