bug 446535 - Main->Downloads->"Save to" file field misses accessible label, r=mano
authorMarco Zehe <marco.zehe@googlemail.com>
Thu, 24 Jul 2008 17:08:05 +0200
changeset 16171 68efb0fb1af14fd684736bee846ae110a7275f89
parent 16170 b0d13430bc76fa72370f5ae874d70990273b3c80
child 16172 74ac047d8174c27c239c850c54fed2c34ca49794
push idunknown
push userunknown
push dateunknown
reviewersmano
bugs446535
milestone1.9.1a2pre
bug 446535 - Main->Downloads->"Save to" file field misses accessible label, r=mano
browser/components/preferences/main.xul
toolkit/mozapps/preferences/preferences.xml
--- a/browser/components/preferences/main.xul
+++ b/browser/components/preferences/main.xul
@@ -158,16 +158,17 @@
         <hbox id="saveToRow">
           <radio id="saveTo" value="true"
                  label="&saveTo.label;"
                  accesskey="&saveTo.accesskey;"
                  aria-labelledby="saveTo downloadFolder"/>
           <filefield id="downloadFolder" flex="1"
                      preference="browser.download.folderList"
                      preference-editable="true"
+                     aria-labelledby="saveTo"
                      onsyncfrompreference="return gMainPane.displayDownloadDirPref();"
                      onsynctopreference="return gMainPane.getFolderListPref()"/>
           <button id="chooseFolder" oncommand="gMainPane.chooseFolder();"
 #ifdef XP_MACOSX
                   accesskey="&chooseFolderMac.accesskey;"
                   label="&chooseFolderMac.label;"
 #else
                   accesskey="&chooseFolderWin.accesskey;"
--- a/toolkit/mozapps/preferences/preferences.xml
+++ b/toolkit/mozapps/preferences/preferences.xml
@@ -5,17 +5,17 @@
           xmlns:xbl="http://www.mozilla.org/xbl"
           xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
 
   <binding id="fileField" extends="chrome://global/content/bindings/general.xml#control-item">
     <content>
       <xul:stringbundle anonid="bundle" src="chrome://mozapps/locale/preferences/preferences.properties"/>
       <xul:hbox class="fileFieldContentBox" align="center" flex="1" xbl:inherits="disabled">
         <xul:image class="fileFieldIcon" xbl:inherits="src=image,disabled"/>
-        <xul:textbox class="fileFieldLabel" xbl:inherits="value=label,disabled,accesskey,tabindex" flex="1" readonly="true"/>
+        <xul:textbox class="fileFieldLabel" xbl:inherits="value=label,disabled,accesskey,tabindex,aria-labelledby" flex="1" readonly="true"/>
       </xul:hbox>
     </content>
     <implementation implements="nsIDOMXULLabeledControlElement">
       <property name="label" onget="return this.getAttribute('label');">
         <setter>
           this.setAttribute('label', val); 
           var elt = document.getAnonymousElementByAttribute(this, "class", "fileFieldLabel");
           return (elt.value = val);