webapprt/jar.mn
author Nicholas Nethercote <nnethercote@mozilla.com>
Thu, 22 Oct 2015 22:48:40 -0700
changeset 269446 588e410c0ddb76ce261c9c0bd344b1ad634fcb32
parent 268712 fc96642eae7f8848414990f4ed1e7e9c0bc4720c
child 270441 1d3d17144c072d9def39480e4ad4254c6e05b375
permissions -rw-r--r--
Bug 1187784 (part 8) - Replace nsBaseHashtable::EnumerateRead() calls in layout/ with iterators. r=heycam. This fixes a type bug in CSSVariableDeclarations::MapRuleInfoInto(). The existing code passes aRuleData->mVariables.get(), which has type |CSSVariableDeclarations*|, into the |void*| parameter to EnumerateRead(). It then extracts that in EnumerateVariableForMapRuleInfoInto() via a cast to a different type, |nsDataHashtable<nsStringHashKey, nsString>*|. It's missing an intermediate access of CSSVariableDeclarations::mVariables. It's likely that this hasn't (seemingly) caused problems prior to now because mVariables is the only field in CSSVariableDeclarations, so mVariables->mVariables is at the same address as mVariables.

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

webapprt.jar:
% content webapprt %content/
* content/webapp.js                     (content/webapp.js)
* content/webapp.xul                    (content/webapp.xul)
  content/getUserMediaDialog.xul        (content/getUserMediaDialog.xul)
  content/getUserMediaDialog.js         (content/getUserMediaDialog.js)
  content/mochitest-shared.js           (content/mochitest-shared.js)
  content/mochitest.js                  (content/mochitest.js)
  content/mochitest.xul                 (content/mochitest.xul)
* content/downloads/downloads.xul       (content/downloads/downloads.xul)
  content/downloads/downloads.js        (content/downloads/downloads.js)
  content/downloads/downloads.css       (content/downloads/downloads.css)
  content/downloads/download.xml        (content/downloads/download.xml)