layout/inspector/inSearchLoop.h
author Nicholas Nethercote <nnethercote@mozilla.com>
Thu, 22 Oct 2015 22:48:40 -0700
changeset 269446 588e410c0ddb76ce261c9c0bd344b1ad634fcb32
parent 202858 9d4e083655b993f73ba3eca84e0f14cdd270bcda
permissions -rw-r--r--
Bug 1187784 (part 8) - Replace nsBaseHashtable::EnumerateRead() calls in layout/ with iterators. r=heycam. This fixes a type bug in CSSVariableDeclarations::MapRuleInfoInto(). The existing code passes aRuleData->mVariables.get(), which has type |CSSVariableDeclarations*|, into the |void*| parameter to EnumerateRead(). It then extracts that in EnumerateVariableForMapRuleInfoInto() via a cast to a different type, |nsDataHashtable<nsStringHashKey, nsString>*|. It's missing an intermediate access of CSSVariableDeclarations::mVariables. It's likely that this hasn't (seemingly) caused problems prior to now because mVariables is the only field in CSSVariableDeclarations, so mVariables->mVariables is at the same address as mVariables.

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#ifndef __inSearchLoop_h__
#define __inSearchLoop_h__

#include "nsCOMPtr.h"
#include "nsITimer.h"
#include "inISearchProcess.h"

class inSearchLoop
{
public:
  explicit inSearchLoop(inISearchProcess* aSearchProcess);
  virtual ~inSearchLoop();

  nsresult Start();
  nsresult Step();
  nsresult Stop();
  static void TimerCallback(nsITimer *aTimer, void *aClosure);

protected:
  nsCOMPtr<nsITimer> mTimer;
  nsCOMPtr<inISearchProcess> mSearchProcess;
};

#endif