Bug 540369. Fix unit test hang detection on Windows. r=ted
authorJonathan Griffin <jgriffin@mozilla.com>
Mon, 25 Jan 2010 12:37:58 -0800
changeset 37492 d08b6ddf04b68870657270809e57c42c6c605608
parent 37491 569db7addb37a9080cee004954c46cdc0bd0925e
child 37493 8b68dd282dd256246e614d8501c63786acff2166
push idunknown
push userunknown
push dateunknown
reviewersted
bugs540369
milestone1.9.3a1pre
Bug 540369. Fix unit test hang detection on Windows. r=ted
build/automation.py.in
--- a/build/automation.py.in
+++ b/build/automation.py.in
@@ -490,17 +490,17 @@ user_pref("camino.use_system_proxy_setti
       done = self.time.time() + timeout
       while self.time.time() < done:
         if self.PeekNamedPipe(x, None, 0, None, self.ctypes.byref(l), None) == 0:
           err = self.GetLastError()
           if err == 38 or err == 109: # ERROR_HANDLE_EOF || ERROR_BROKEN_PIPE
             return ('', False)
           else:
             log.error("readWithTimeout got error: %d", err)
-        if l > 0:
+        if l.value > 0:
           # we're assuming that the output is line-buffered,
           # which is not unreasonable
           return (f.readline(), False)
         self.time.sleep(0.01)
       return ('', True)
 
     def isPidAlive(self, pid):
       STILL_ACTIVE = 259