Bug 1124542 - WebrtcGmpVideoDecoder shouldn't crash when GMP completion callbacks are received. r=rjesup, a=lmandel
authorMatthew Gregan <kinetik@flim.org>
Wed, 21 Jan 2015 20:26:00 +1300
changeset 237769 c54687cb708601b10e43335942f7230f2da3b979
parent 237768 caf324dbb13f456189b7570ee0cbcdf4da83e479
child 237770 5598a289b44244d378a843409c0fda4cf9054363
push id349
push userryanvm@gmail.com
push dateThu, 19 Mar 2015 12:36:55 +0000
treeherdermozilla-b2g37_v2_2@7b579e85a8da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrjesup, lmandel
bugs1124542
milestone37.0
Bug 1124542 - WebrtcGmpVideoDecoder shouldn't crash when GMP completion callbacks are received. r=rjesup, a=lmandel
media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h
--- a/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h
+++ b/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h
@@ -133,25 +133,22 @@ public:
     MOZ_CRASH();
   }
 
   virtual void ReceivedDecodedFrame(const uint64_t aPictureId) MOZ_OVERRIDE {
     MOZ_CRASH();
   }
 
   virtual void InputDataExhausted() MOZ_OVERRIDE {
-    MOZ_CRASH();
   }
 
   virtual void DrainComplete() MOZ_OVERRIDE {
-    MOZ_CRASH();
   }
 
   virtual void ResetComplete() MOZ_OVERRIDE {
-    MOZ_CRASH();
   }
 
   virtual void Error(GMPErr aError) MOZ_OVERRIDE {
   }
 
 private:
   virtual int32_t InitDecode_g(const webrtc::VideoCodec* aCodecSettings,
                                int32_t aNumberOfCores);