Bug 1028680 - Give TextTrackList an out-of-line destructor so that we can forward declare TextTrackManager in the header; r=bzbarsky
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 24 Jun 2014 07:20:54 -0700
changeset 190547 b53f3f98de0292beb379776c368e3d9cb0b202b9
parent 190546 5ab82e6a9bc40c2baf2b933e1c72f89b35f3579b
child 190548 07212e931822de1e71c17c5f87d6b28af6e43570
push idunknown
push userunknown
push dateunknown
reviewersbzbarsky
bugs1028680
milestone33.0a1
Bug 1028680 - Give TextTrackList an out-of-line destructor so that we can forward declare TextTrackManager in the header; r=bzbarsky
content/media/TextTrackList.cpp
content/media/TextTrackList.h
--- a/content/media/TextTrackList.cpp
+++ b/content/media/TextTrackList.cpp
@@ -30,16 +30,20 @@ TextTrackList::TextTrackList(nsPIDOMWind
 
 TextTrackList::TextTrackList(nsPIDOMWindow* aOwnerWindow,
                              TextTrackManager* aTextTrackManager)
  : DOMEventTargetHelper(aOwnerWindow)
  , mTextTrackManager(aTextTrackManager)
 {
 }
 
+TextTrackList::~TextTrackList()
+{
+}
+
 void
 TextTrackList::UpdateAndGetShowingCues(nsTArray<nsRefPtr<TextTrackCue> >& aCues)
 {
   nsTArray< nsRefPtr<TextTrackCue> > cues;
   for (uint32_t i = 0; i < Length(); i++) {
     TextTrackMode mode = mTextTracks[i]->Mode();
     // If the mode is hidden then we just need to update the active cue list,
     // we don't need to show it on the video.
--- a/content/media/TextTrackList.h
+++ b/content/media/TextTrackList.h
@@ -23,16 +23,17 @@ class TrackEventRunner;
 class TextTrackList MOZ_FINAL : public DOMEventTargetHelper
 {
 public:
   NS_DECL_ISUPPORTS_INHERITED
   NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(TextTrackList, DOMEventTargetHelper)
 
   TextTrackList(nsPIDOMWindow* aOwnerWindow);
   TextTrackList(nsPIDOMWindow* aOwnerWindow, TextTrackManager* aTextTrackManager);
+  ~TextTrackList();
 
   virtual JSObject* WrapObject(JSContext* aCx) MOZ_OVERRIDE;
 
   uint32_t Length() const
   {
     return mTextTracks.Length();
   }