Bug 888908 - When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway, r=jaws
authorBenjamin Smedberg <benjamin@smedbergs.us>
Fri, 19 Jul 2013 10:02:47 -0400
changeset 139256 62429a874f06cc824474be1869f74afe7a44b72c
parent 139255 d04578401deb8c2c31ee675f911bff3d898ba44a
child 139257 678e1cb9f5879777f96aab5c4d46467c8180fc7c
push idunknown
push userunknown
push dateunknown
reviewersjaws
bugs888908
milestone25.0a1
Bug 888908 - When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway, r=jaws
browser/base/content/browser-plugins.js
--- a/browser/base/content/browser-plugins.js
+++ b/browser/base/content/browser-plugins.js
@@ -761,18 +761,17 @@ var gPluginHandler = {
 
     let haveVulnerablePlugin = plugins.some(function(plugin) {
       let fallbackType = plugin.pluginFallbackType;
       return fallbackType == plugin.PLUGIN_VULNERABLE_UPDATABLE ||
         fallbackType == plugin.PLUGIN_VULNERABLE_NO_UPDATE ||
         fallbackType == plugin.PLUGIN_BLOCKLISTED;
     });
     let dismissed = notification ? notification.dismissed : true;
-    // Always show the doorhanger if the anchor is not available.
-    if (!isElementVisible(gURLBar) || aPrimaryPlugin)
+    if (aPrimaryPlugin)
       dismissed = false;
 
     let primaryPluginPermission = null;
     if (aPrimaryPlugin) {
       primaryPluginPermission = this._getPluginInfo(aPrimaryPlugin).permissionString;
     }
 
     let options = {