Bug 918032 - Top Sites query should include display, bookmarkId, historyId (r=wesj, a=lsblakk)
authorLucas Rocha <lucasr@mozilla.com>
Thu, 19 Sep 2013 17:18:06 -0400
changeset 223619 3671241aeed4203325c8d58666838fe6c336c5f6
parent 223618 d7e3b0bb444834ae0541193c6f71832865e31796
child 223620 74ae5aed92b3f6ff5d6aa1014fe161c267cb5feb
push id6
push userryanvm@gmail.com
push dateMon, 12 Jan 2015 22:04:06 +0000
treeherdermozilla-b2g37_v2_2@895c8fc7b734 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswesj, lsblakk
bugs918032
milestone26.0a2
Bug 918032 - Top Sites query should include display, bookmarkId, historyId (r=wesj, a=lsblakk)
mobile/android/base/db/LocalBrowserDB.java
--- a/mobile/android/base/db/LocalBrowserDB.java
+++ b/mobile/android/base/db/LocalBrowserDB.java
@@ -236,17 +236,20 @@ public class LocalBrowserDB implements B
         String selection = DBUtils.concatenateWhere("", Combined.URL + " NOT IN (SELECT " +
                                              Bookmarks.URL + " FROM bookmarks WHERE " +
                                              DBUtils.qualifyColumn("bookmarks", Bookmarks.PARENT) + " == ? AND " +
                                              DBUtils.qualifyColumn("bookmarks", Bookmarks.IS_DELETED) + " == 0)");
         String[] selectionArgs = DBUtils.appendSelectionArgs(new String[0], new String[] { String.valueOf(Bookmarks.FIXED_PINNED_LIST_ID) });
         return filterAllSites(cr,
                               new String[] { Combined._ID,
                                              Combined.URL,
-                                             Combined.TITLE },
+                                             Combined.TITLE,
+                                             Combined.DISPLAY,
+                                             Combined.BOOKMARK_ID,
+                                             Combined.HISTORY_ID },
                               "",
                               limit,
                               BrowserDB.ABOUT_PAGES_URL_FILTER,
                               selection,
                               selectionArgs);
     }
 
     @Override