Bug 390249 - "symbolstore.py has trouble launching dump_syms from a relative path". r=luser, a=dbaron.
authorbent.mozilla@gmail.com
Mon, 13 Aug 2007 13:35:36 -0700
changeset 4574 13fe21f354eae59fe348f503b568f9484a39d279
parent 4573 a5312b6766843f7f3f1281a7ca0e2519bcbf0262
child 4575 6b326374ea3947b28c7c92c95c6809effe85d77e
push idunknown
push userunknown
push dateunknown
reviewersluser, dbaron
bugs390249
milestone1.9a8pre
Bug 390249 - "symbolstore.py has trouble launching dump_syms from a relative path". r=luser, a=dbaron.
toolkit/crashreporter/tools/symbolstore.py
--- a/toolkit/crashreporter/tools/symbolstore.py
+++ b/toolkit/crashreporter/tools/symbolstore.py
@@ -145,17 +145,18 @@ class Dumper:
     symbol files--|copy_debug|, mostly useful for creating a
     Microsoft Symbol Server from the resulting output.
 
     You don't want to use this directly if you intend to call
     ProcessDir.  Instead, call GetPlatformSpecificDumper to
     get an instance of a subclass."""
     def __init__(self, dump_syms, symbol_path,
                  archs=None, srcdir=None, copy_debug=False, vcsinfo=False):
-        self.dump_syms = dump_syms
+        # popen likes absolute paths, at least on windows
+        self.dump_syms = os.path.abspath(dump_syms)
         self.symbol_path = symbol_path
         if archs is None:
             # makes the loop logic simpler
             self.archs = ['']
         else:
             self.archs = ['-a %s' % a for a in archs.split()]
         if srcdir is not None:
             self.srcdir = os.path.normpath(srcdir)