searching for reviewer(benjamin)
4d55c412cacdb3e233bd1615cc8bb8904a87496d: Bug 918140 - mis-interprets disk "hard quota" (blocks vs bytes confusion). r=benjamin
Paul Szabo <psz@maths.usyd.edu.au> - Sun, 23 Nov 2014 22:20:38 +0200 - rev 217022
Bug 918140 - mis-interprets disk "hard quota" (blocks vs bytes confusion). r=benjamin
775c66270625c26dc182c2e969f041ed0e4ec6ab: Bug 973371 - Clarify a label for a checkbox in the Profile Manager. r=benjamin
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 21 Feb 2014 20:10:59 +0900 - rev 169868
Bug 973371 - Clarify a label for a checkbox in the Profile Manager. r=benjamin
27777c768b68498c8ec4635f6041f588a9e715a1: Bug 972657 - Move the "is this script too small to compress?" check to a better place. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 13 Feb 2014 19:04:05 -0800 - rev 168744
Bug 972657 - Move the "is this script too small to compress?" check to a better place. r=benjamin.
92081c50e18c7a24f16db25485a459a0b0df98a5: Bug 961883 (part 1) - Measure and report the SourceDataCache. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 20 Jan 2014 19:52:57 -0800 - rev 165053
Bug 961883 (part 1) - Measure and report the SourceDataCache. r=benjamin.
63e0b6e8f84c86f6e159c33e1f8bfeee866f1727: Bug 938615 - Simplify usage of ScriptSource::chars (r=benjamin)
Luke Wagner <luke@mozilla.com> - Thu, 14 Nov 2013 14:57:11 -0600 - rev 156590
Bug 938615 - Simplify usage of ScriptSource::chars (r=benjamin)
6d579cd22053f20087ab92f6bc325026e6c53d3e: Bug 938390 - don't create a string to hold chars in ScriptSource::chars (r=benjamin)
Luke Wagner <luke@mozilla.com> - Thu, 14 Nov 2013 09:55:13 -0600 - rev 156589
Bug 938390 - don't create a string to hold chars in ScriptSource::chars (r=benjamin)
1fb5370a0a1ec12d756c8223ffaadb493ebb5658: Bug 928736 - Remove forward declarations of classes subsequently defined with attributes, because clang doesn't like it when you do this, and add JS:: to the few places that now need it. r=benjamin
Jeff Walden <jwalden@mit.edu> - Thu, 24 Oct 2013 17:35:36 +0100 - rev 152003
Bug 928736 - Remove forward declarations of classes subsequently defined with attributes, because clang doesn't like it when you do this, and add JS:: to the few places that now need it. r=benjamin
6d91b99de1cb97a2fd1ab9173692f05c0468bc89: Bug 919712 - Add labels in IPC message wait. r=benjamin
Benoit Girard <b56girard@gmail.com> - Tue, 24 Sep 2013 11:40:01 -0400 - rev 148454
Bug 919712 - Add labels in IPC message wait. r=benjamin
ca06d27f049f6c797695de1e2a0c60eae3f1def1: Bug 908301 - Remove dedicated source compression thread, use JS worker threads instead, allow saving source when parsing off thread, r=benjamin.
Brian Hackett <bhackett1024@gmail.com> - Tue, 27 Aug 2013 11:48:55 -0600 - rev 144521
Bug 908301 - Remove dedicated source compression thread, use JS worker threads instead, allow saving source when parsing off thread, r=benjamin.
64e83ea4fbadf65a1152b0fd2344631314ceb0c5: Bug 898274 (part 2) - Check ordering of #include statements in check_spidermonkey_style.py. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 14 Aug 2013 21:59:57 -0700 - rev 142713
Bug 898274 (part 2) - Check ordering of #include statements in check_spidermonkey_style.py. r=benjamin.
200fae26b2717a4c5a8aa9a399ee7a675cb9be1b: Bug 898274 (part 1) - Fix ordering of various #include statements. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 13 Aug 2013 15:34:12 -0700 - rev 142712
Bug 898274 (part 1) - Fix ordering of various #include statements. r=benjamin.
581ed22255f0a280988b78274ee113ddc0fdd88c: Bug 899858 - Cache pymake len() computation to speed up parsing. r=benjamin
Benoit Girard <b56girard@gmail.com> - Tue, 06 Aug 2013 15:25:57 -0400 - rev 141581
Bug 899858 - Cache pymake len() computation to speed up parsing. r=benjamin
bb4f5079e0096f7824dc0b34228e35fb03146b83: Bug 885804: IPDL unit test changes r=benjamin
David Zbarsky <dzbarsky@gmail.com> - Mon, 08 Jul 2013 11:48:40 -0400 - rev 137652
Bug 885804: IPDL unit test changes r=benjamin
efbe3b2ea841ee0fd2c18b70f7deb4e4432e49b7: Bug 881579 - Use the canonical #ifndef wrapper form in SpiderMonkey headers so that GCC and clang can avoid including them more than once per compilation unit. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 16 Jun 2013 16:11:24 -0700 - rev 135225
Bug 881579 - Use the canonical #ifndef wrapper form in SpiderMonkey headers so that GCC and clang can avoid including them more than once per compilation unit. r=benjamin.
7a56133fe3829886d594c8e1ac1768061f0eeaf9: Bug 880565 (part 2) - Remove unnecessary #includes in jsobjinlines.h. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 06 Jun 2013 17:48:12 -0700 - rev 135132
Bug 880565 (part 2) - Remove unnecessary #includes in jsobjinlines.h. r=benjamin.
b86a5ad596b74bcffb1615fc332e7b7e2a726408: Bug 880565 (part 1) - Move isFunction() et al from jsobjinlines.h to jsobj.h and minimize the number of files that #include jsobjinlines.h. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 05 Jun 2013 19:07:43 -0700 - rev 135131
Bug 880565 (part 1) - Move isFunction() et al from jsobjinlines.h to jsobj.h and minimize the number of files that #include jsobjinlines.h. r=benjamin.
9953a7663df4e2a230ff0d6be6c268bc3883f044: Bug 871942 - Don't synchronously stop plugins in DestroyContent. r=benjamin
John Schoenick <jschoenick@mozilla.com> - Wed, 15 May 2013 14:17:18 -0700 - rev 132811
Bug 871942 - Don't synchronously stop plugins in DestroyContent. r=benjamin
83be5398e9074a9ba446ab882f22b38237cf8b07: Bug 836869 - Make QueryPerformanceCounter bad leap detection heuristic smarter, r=tellrob, sr=benjamin
Honza Bambas <honzab.moz@firemni.cz> - Wed, 01 May 2013 18:57:58 +0200 - rev 130490
Bug 836869 - Make QueryPerformanceCounter bad leap detection heuristic smarter, r=tellrob, sr=benjamin
50725df22b056deaa8242ae90c5774e74e6dae44: Bug 844996 - DeallocShmem failures will abort in debug builds. r=cjones,benjamin
Benoit Girard <b56girard@gmail.com> - Wed, 27 Mar 2013 15:28:57 -0400 - rev 127859
Bug 844996 - DeallocShmem failures will abort in debug builds. r=cjones,benjamin
429e15d02de3ac6933b20456a855b79ccbeabf14: Bug 846906 - Implement nsAppShellService::CreateWindowlessBrowser; r=bz; sr=benjamin
Eddy Bruel <ejpbruel@mozilla.com> - Thu, 04 Apr 2013 15:24:32 +0200 - rev 127713
Bug 846906 - Implement nsAppShellService::CreateWindowlessBrowser; r=bz; sr=benjamin
d5d98779e4011050ebb5171f06aa0da9f2709c29: Bug 846906 - Implement nsAppShellService::CreateWindowlessBrowser; r=bz; sr=benjamin
Eddy Bruel <ejpbruel@mozilla.com> - Thu, 04 Apr 2013 15:24:32 +0200 - rev 127663
Bug 846906 - Implement nsAppShellService::CreateWindowlessBrowser; r=bz; sr=benjamin
061b9318815bcdaaded4cb49a63e8f2adf313d9a: Bug 846906 - Implement nsAppShellService::CreateWindowlessBrowser; r=bz; sr=benjamin
Eddy Bruel <ejpbruel@mozilla.com> - Thu, 04 Apr 2013 15:24:32 +0200 - rev 127656
Bug 846906 - Implement nsAppShellService::CreateWindowlessBrowser; r=bz; sr=benjamin
9980f5c81587047f03eaa815f8e7c5965f327d6b: Bug 853363 - Add profiler labels for IPDL IPC. r=benjamin
Chris Jones <jones.chris.g@gmail.com> - Fri, 22 Mar 2013 14:57:59 +0100 - rev 126153
Bug 853363 - Add profiler labels for IPDL IPC. r=benjamin
22835e17f50a5381b7091deba9bf7d1f998d973b: Bug 842438 (part 1) - Remove @line support from SpiderMonkey. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 11 Mar 2013 14:27:34 -0700 - rev 124460
Bug 842438 (part 1) - Remove @line support from SpiderMonkey. r=benjamin.
a9a1a85cc920136693f513d3dd15082f2db1da00: Bug 847088 - Fix gstreamer backend, which was broken by TimeRange changes. r=benjamin
Andrea Marchesini <amarchesini@mozilla.com> - Sun, 03 Mar 2013 12:01:05 -0500 - rev 123626
Bug 847088 - Fix gstreamer backend, which was broken by TimeRange changes. r=benjamin
2a33d38e3a1add83322d0b29dd2a0b148c5232e7: Bug 841477 - Enable FAIL_ON_WARNINGS on MSVC in dom/plugins. r=benjamin
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Thu, 28 Feb 2013 07:44:52 +0900 - rev 123283
Bug 841477 - Enable FAIL_ON_WARNINGS on MSVC in dom/plugins. r=benjamin
11ca90723b3ab2e08a5cb68acbd75a4ea3f304a2: Bug 837561 ReadInt16 and WriteInt16 should be paired r=benjamin
Ginn Chen <Ginn.Chen@Oracle.COM> - Mon, 18 Feb 2013 15:19:03 +0800 - rev 122212
Bug 837561 ReadInt16 and WriteInt16 should be paired r=benjamin
c8135b361176680c2e883e6aee69c37958bdae5b: Bug 839731 - Kill try-safe stuff. r=benjamin
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 12 Feb 2013 01:28:08 +0900 - rev 121553
Bug 839731 - Kill try-safe stuff. r=benjamin
eb8f60c782dafe08047aacbb78044f6ac3ce7be4: Bug 837715. Reduce compression rate for js source. r=benjamin
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 06 Feb 2013 12:53:52 -0500 - rev 121190
Bug 837715. Reduce compression rate for js source. r=benjamin This cuts the time to compress gaia-email-opt.js from 0.63 seconds to 0.33 seconds. The result should still be smaller (391K from 321K before) than the compressing with snappy or lz4 (528K), but decompression time will be worse. Fortunately, this will only penalize Function.toSource() which I think is an ok trade off.
091c55c7215c9b1034594fa2c6b383479f9673d4: Bug 836985 follow-up: Make ScriptSourceHolder constructor explicit. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 03 Feb 2013 20:03:06 -0800 - rev 120716
Bug 836985 follow-up: Make ScriptSourceHolder constructor explicit. r=benjamin.
f24b93663ea95a4252e38be6e4f0cdf7ebe5c211: Bug 836985 - Remove ScriptSourceHolder::rt. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 03 Feb 2013 19:55:09 -0800 - rev 120714
Bug 836985 - Remove ScriptSourceHolder::rt. r=benjamin.
62e53c789ae8915d394fe59f9fae61e27da43bec: Bug 833151 - Avoid unnecessary copy of CompileOptions. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 23 Jan 2013 18:14:38 -0800 - rev 119718
Bug 833151 - Avoid unnecessary copy of CompileOptions. r=benjamin.
6a48352004a29a96bc6705b5ab0d25784ebfe03c: Bug 568953 - Fix for module object; r=benjamin
Eddy Bruel <ejpbruel@mozilla.com> - Wed, 23 Jan 2013 16:58:50 +0100 - rev 119648
Bug 568953 - Fix for module object; r=benjamin
03fd5f43435d96f0b6dce09e2cec620ad3db633a: Bug 761135 - Remove XPCOMGlueShutdown. r=benjamin
Benoit Girard <b56girard@gmail.com> - Mon, 07 Jan 2013 16:19:39 -0500 - rev 118434
Bug 761135 - Remove XPCOMGlueShutdown. r=benjamin
89bc8559149f355b564c2acc2efb65e98eb9ec21: Bug 826126 - Just use an assert to check for aliasing; r=benjamin
Terrence Cole <terrence@mozilla.com> - Wed, 02 Jan 2013 17:13:16 -0800 - rev 117654
Bug 826126 - Just use an assert to check for aliasing; r=benjamin This appears to be debug code that crept in for bug 767013.
a28cfd7299e51fc50012d3038f97f61d33e5eb83: Bug 821470 - Avoid calling TokenStream::strictMode() from the BytecodeEmitter. r=benjamin
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 16 Dec 2012 21:08:11 -0800 - rev 116292
Bug 821470 - Avoid calling TokenStream::strictMode() from the BytecodeEmitter. r=benjamin
3098b9949017274321ae45edad078075b66397db: Bug 804664 - remove typedef nsAutoCString nsCAutoString. r=benjamin
Magnus Melin <mkmelin+mozilla@iki.fi> - Tue, 23 Oct 2012 20:53:15 +0300 - rev 111241
Bug 804664 - remove typedef nsAutoCString nsCAutoString. r=benjamin
dd69215593f6e345f0ea0f842204d235161759fd: Bug 803707 - Don't assume pointers are 64 bits. r=benjamin.
Rafael Ávila de Espíndola <respindola@mozilla.com> - Mon, 22 Oct 2012 09:07:04 -0400 - rev 111023
Bug 803707 - Don't assume pointers are 64 bits. r=benjamin.
28f11e31359b1f2492f76f38c836bfce9cdd2bd2: Bug 800407 - Remove incorrect assertion that Function constructor defined functions cannot have inherited strict mode. r=benjamin code=Nikhil Marathe
Benjamin Peterson <benjamin@python.org> - Mon, 15 Oct 2012 16:12:41 -0400 - rev 110324
Bug 800407 - Remove incorrect assertion that Function constructor defined functions cannot have inherited strict mode. r=benjamin code=Nikhil Marathe
31b3592edb37a1d234302dc95689101d3c32731e: Bug 791465 - Fix processDirectives' ASI emulation. code=André Bargull r=benjamin
Benjamin Peterson <benjamin@python.org> - Sat, 13 Oct 2012 09:23:53 -0400 - rev 110143
Bug 791465 - Fix processDirectives' ASI emulation. code=André Bargull r=benjamin
51644b3ee33365d9464c1ca058d3773f2e7f6889: Bug 727370 - Fix typo that crept in while rebasing. r=benjamin
Gian-Carlo Pascutto <gpascutto@mozilla.com> - Fri, 28 Sep 2012 19:00:20 +0200 - rev 108515
Bug 727370 - Fix typo that crept in while rebasing. r=benjamin
8522498a85a368dc0a152cef5681aa094bed0812: Bug 789941 - Remove stdc++compat.cpp support on OS X. r=benjamin.
Rafael Ávila de Espíndola <respindola@mozilla.com> - Thu, 13 Sep 2012 19:17:08 -0400 - rev 107068
Bug 789941 - Remove stdc++compat.cpp support on OS X. r=benjamin.
d6d70984c0f6dfecb76bce51b6e9f45bc3ac526d: Bug 788957 (part 5) - Remove unused arguments from NoteLValue(). r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 10 Sep 2012 20:44:05 -0700 - rev 106883
Bug 788957 (part 5) - Remove unused arguments from NoteLValue(). r=benjamin.
96fc70c99ed1642b43cfbc1ba6c170ce912b08b0: Bug 788957 (part 4) - Add GlobalSharedContext, a sub-class of SharedContext, and also make FunctionBox a sub-class of SharedContext. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 10 Sep 2012 20:43:14 -0700 - rev 106882
Bug 788957 (part 4) - Add GlobalSharedContext, a sub-class of SharedContext, and also make FunctionBox a sub-class of SharedContext. r=benjamin.
b7faae8e1d2bdf1170f6908b4668f0e5e169991d: Bug 788957 (part 3) - Change SharedContext::inFunction() to SharedContext::isFunction. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 10 Sep 2012 20:42:18 -0700 - rev 106881
Bug 788957 (part 3) - Change SharedContext::inFunction() to SharedContext::isFunction. r=benjamin.
85be098d321d94f1dc56048e6853689ab2bf6562: Bug 788957 (part 2) - Split ContextFlags into AnyContextFlags and FunctionContextFlags. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 10 Sep 2012 20:40:11 -0700 - rev 106880
Bug 788957 (part 2) - Split ContextFlags into AnyContextFlags and FunctionContextFlags. r=benjamin.
50c9565a5f3dd08956f92908745e0e8e4cbdb062: Bug 788957 (part 1) - Change FunctionBox so it has an ObjectBox rather than is an ObjectBox. r=benjamin.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 10 Sep 2012 17:58:32 -0700 - rev 106879
Bug 788957 (part 1) - Change FunctionBox so it has an ObjectBox rather than is an ObjectBox. r=benjamin.
604554b4a1df5fae1b4c71923cad2705b703fe47: Bug 781445 - Remove a python 2.7 only function from tasks_unix.py; r=benjamin
Terrence Cole <terrence@mozilla.com> - Thu, 09 Aug 2012 10:52:40 -0700 - rev 101991
Bug 781445 - Remove a python 2.7 only function from tasks_unix.py; r=benjamin
6bed0413c96e5053d855f5af0cf58a28056f31f4: Bug 781040 - Fault in methods and accessors with JSJitinfos on ResolveProperty. (r=bz,benjamin)
Eric Faust <efaust@mozilla.com> - Tue, 07 Aug 2012 22:26:19 -0700 - rev 101798
Bug 781040 - Fault in methods and accessors with JSJitinfos on ResolveProperty. (r=bz,benjamin)
7ab3af6a212dd8e8e9f1802d573cde5f479f3cb0: Bug 774243 - [Linux] Process name changes to RunProcess, r=benjamin
Honza Bambas <honzab.moz@firemni.cz> - Tue, 31 Jul 2012 20:59:18 +0200 - rev 101030
Bug 774243 - [Linux] Process name changes to RunProcess, r=benjamin