8e0213fd66986ee7635dc759277645797e7a1096: Test for bug 682463.
Jesse Ruderman <jruderman@gmail.com> - Sat, 24 Sep 2011 02:56:38 +0200 - rev 77484
Test for bug 682463.
21c337884f31bb89c1ec37790160839d1678a1a2: Bug 682463 - "ASSERTION: unexpected disconnected nodes" with DOM range, splitText. r=smaug
Mats Palmgren <matspal@gmail.com> - Sat, 24 Sep 2011 02:56:38 +0200 - rev 77483
Bug 682463 - "ASSERTION: unexpected disconnected nodes" with DOM range, splitText. r=smaug
737c2fdb9148d53789a2d0c389113fbdf1d34f6e: Bug 683802 - remove trailing ; to fix Maemo bustage. r=bholley
Andrew McCreight <amccreight@mozilla.com> - Fri, 23 Sep 2011 17:26:19 -0700 - rev 77482
Bug 683802 - remove trailing ; to fix Maemo bustage. r=bholley
9de2292c7a8d33cabf4505f164187df926e3b757: Bug 688168 - Make the sync dialog pretty on Honeycomb [r=wesj]
Matt Brubeck <mbrubeck@mozilla.com> - Fri, 23 Sep 2011 16:37:26 -0700 - rev 77481
Bug 688168 - Make the sync dialog pretty on Honeycomb [r=wesj]
c1baac3439cd7ea88e5c60bdb47d989347edea5c: Bug 688693 - Tweak the portrait tabs menu. r=mfinkle
Wes Johnston <wjohnston@mozilla.com> - Fri, 23 Sep 2011 16:02:27 -0700 - rev 77480
Bug 688693 - Tweak the portrait tabs menu. r=mfinkle
96214726a7696258663b08516c1d1454ce048ad9: Bug 688819 - Add strings for Fennec actionbar in preferences. r=mfinkle
Wes Johnston <wjohnston@mozilla.com> - Fri, 23 Sep 2011 16:02:25 -0700 - rev 77479
Bug 688819 - Add strings for Fennec actionbar in preferences. r=mfinkle
f3df57832f29826617c076338ccf1e7e43227489: Bug 688840 - Switching from portrait to landscape breaks tab sidebar toggling [r=wesj]
Matt Brubeck <mbrubeck@mozilla.com> - Fri, 23 Sep 2011 15:18:40 -0700 - rev 77478
Bug 688840 - Switching from portrait to landscape breaks tab sidebar toggling [r=wesj]
96b970e6291b30a3a036fe11580505e34e835151: Bug 688689 (2/2) - New throbber animation for Fennec [r=mfinkle]
Matt Brubeck <mbrubeck@mozilla.com> - Fri, 23 Sep 2011 15:18:40 -0700 - rev 77477
Bug 688689 (2/2) - New throbber animation for Fennec [r=mfinkle]
6e370a64b8d12176576645c9e39988e66e838b16: Bug 688689 (1/2) - New colors for SSL endcaps in Fennec URL bar [r=mfinkle]
Matt Brubeck <mbrubeck@mozilla.com> - Fri, 23 Sep 2011 15:18:39 -0700 - rev 77476
Bug 688689 (1/2) - New colors for SSL endcaps in Fennec URL bar [r=mfinkle]
3bfef7f630dc04b2c642d13d177c9b73bc8d962d: Bug 683802 - Pass useAllocator=false only for wrappedjs dipper params. Everything else can allocate. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:29 -0700 - rev 77475
Bug 683802 - Pass useAllocator=false only for wrappedjs dipper params. Everything else can allocate. r=mrbkap We only have one good reason for the useAllocator distinction: when C++ calls JS with a dipper parameter (ie, a string), the caller has already created the relevant nsAString or nsCString, so we shouldn't allocate another one. All other uses are superfluous or irrelevant, so we can get rid of them.
30472afa1c400403b0dc8cc44a09d882fc1fb240: Bug 683802 - Force allocation for sized PWSTRINGs in XPCWrappedNative argument conversion. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:29 -0700 - rev 77474
Bug 683802 - Force allocation for sized PWSTRINGs in XPCWrappedNative argument conversion. r=mrbkap This is the last remaining place where we might pass a non-dipper with useAllocator==false to XPCConvert *and, as a consequence*, do something different within XPCConvert. This paves the way for the elimination of useAllocator for non-dipper types.
3f69487fa2382164a4749cbd820816d3c250e84d: Bug 683802 - Remove XPC_JSArgumentFormatter and friends. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77473
Bug 683802 - Remove XPC_JSArgumentFormatter and friends. r=mrbkap XPC_JSArgumentFormatter adds 3 special format string tokens to spidermonkey: %ip, %iv, and %is. These were unused outside of testing according to a free-text MXR search, and don't appear to be well-documented anywhere either. They also happen to be quite dangerous and easy to use improperly: we pass untyped variadic parameters to XPCConvert::JSData2Native with useAllocator==false. This causes JSData2Native to blindly cast the values to concrete class pointers (like nsAString*) and call methods on them.
020fe6ba85534fadad0c92beec9377da502b5ee8: Bug 683802 - Eliminate questionable support for [shared] parameters. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77472
Bug 683802 - Eliminate questionable support for [shared] parameters. r=mrbkap AFAICT we'd crash if we hit these cases anyway. bsmedberg and khuey requested that I assert against this case within XPConnect, and file a bug to make XPIDL enforce that [shared] parameters exist only in [noscript] methods. Filed bug 685281 for this.
90de2e5fd0ac760d70e9cb1f95bdc93c7b467e8b: Bug 683802 - Coalesce type-specific cleanup indicators. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77471
Bug 683802 - Coalesce type-specific cleanup indicators. r=mrbkap
5ab48d3bf0bd4ca4927916adfb73f11f5edc2f14: Bug 683802 - Add jsval to the XPTCMiniVariant union for type safety. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77470
Bug 683802 - Add jsval to the XPTCMiniVariant union for type safety. r=mrbkap
36aa31a60a664fdb3e4ce0b25c7f8e80937c68da: Bug 683802 - Use an explicit indicator for direct vs indirect calling semantics. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77469
Bug 683802 - Use an explicit indicator for direct vs indirect calling semantics. r=mrbkap
6e1f386c4065c1c0b4175cddd0674d8aa21b6a05: Bug 683802 - Define and restrict the semantics of PTR_IS_DATA. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77468
Bug 683802 - Define and restrict the semantics of PTR_IS_DATA. r=mrbkap
8f37c643e8a064cbfd42d6d120896c0e4b43f484: Bug 683802 - Always store jsvals directly within the val union (fixes bug 655878). r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77467
Bug 683802 - Always store jsvals directly within the val union (fixes bug 655878). r=mrbkap
af2a149c4f4fcb0c9e67a4ed44ec09372a652007: Bug 683802 - Factor dipper handling out into a helper method. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:28 -0700 - rev 77466
Bug 683802 - Factor dipper handling out into a helper method. r=mrbkap
a6875b0b2ebb044793a250d15876fd1ba92afb00: Bug 683802 - Separate reindentation from previous patch for easier review. No other changes. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 23 Sep 2011 14:50:27 -0700 - rev 77465
Bug 683802 - Separate reindentation from previous patch for easier review. No other changes. r=mrbkap
(0) -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip