searching for reviewer(Waldo)
bc93d4b84bb2ff19f3172a1088d9e4bd37271458: Bug 1111248. r=Waldo, a=2.1+
Tom Schuster <evilpies@gmail.com> - Mon, 26 Jan 2015 10:57:14 -0500 - rev 221665
Push 344 by ryanvm@gmail.com at Tue, 27 Jan 2015 03:07:58 +0000
Bug 1111248. r=Waldo, a=2.1+
ecaedd858fd0f6fac7aed76892df0c185f17bb88: Bug 1065604 - Assert that JSPROP_SHARED is set on all properties defined with JSPROP_GETTER or JSPROP_SETTER. r=Waldo, a=lmandel
Jason Orendorff <jorendorff@mozilla.com> - Wed, 10 Sep 2014 15:17:52 -0500 - rev 220942
Push 103 by ryanvm@gmail.com at Wed, 29 Oct 2014 22:34:27 +0000
Bug 1065604 - Assert that JSPROP_SHARED is set on all properties defined with JSPROP_GETTER or JSPROP_SETTER. r=Waldo, a=lmandel
eee93220473c96cdacb225f7170dd18317f74da1: Bug 1041631, part 2 - Make ES6 Symbols Nightly-only for now. r=Waldo, a=sledru.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 20 Aug 2014 12:37:37 -0500 - rev 220379
Push 4 by ryanvm@gmail.com at Mon, 13 Oct 2014 16:45:01 +0000
Bug 1041631, part 2 - Make ES6 Symbols Nightly-only for now. r=Waldo, a=sledru.
aa2a7bcabf52ca296c9fd45714f3195fa7cef52c: Bug 1027157 - Make warnings reported with JSEXN_NONE so that they don't appear as errors in the console. r=Waldo, a=sledru
Nick Fitzgerald <fitzgen@mozilla.com> - Thu, 19 Jun 2014 15:44:00 -0400 - rev 220014
Push 4 by ryanvm@gmail.com at Mon, 13 Oct 2014 16:45:01 +0000
Bug 1027157 - Make warnings reported with JSEXN_NONE so that they don't appear as errors in the console. r=Waldo, a=sledru
5ceaa65c46ebfcef8c02845ecb6fd171eb2a6ea2: Bug 1023109 - Update nsIXPCScriptable.idl UUID. (Interface changed in rev a470806c3553.) r=Waldo, ba=sylvestre. DONTBUILD.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 10 Jun 2014 12:20:11 -0500 - rev 219888
Push 4 by ryanvm@gmail.com at Mon, 13 Oct 2014 16:45:01 +0000
Bug 1023109 - Update nsIXPCScriptable.idl UUID. (Interface changed in rev a470806c3553.) r=Waldo, ba=sylvestre. DONTBUILD. "[...] nothing can go wrong with this" --Jeff Walden.
8260d1fb1c34a489223e18de42cdab6b3fa19e28: Bug 1007223 - Follow-up: Fix the media decoding test, and also ensure that we're freeing the right buffer. r=Waldo, a=bustage
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 May 2014 15:42:49 -0400 - rev 219869
Push 4 by ryanvm@gmail.com at Mon, 13 Oct 2014 16:45:01 +0000
Bug 1007223 - Follow-up: Fix the media decoding test, and also ensure that we're freeing the right buffer. r=Waldo, a=bustage Note that I am not fixing the SyncDecodeMedia case to not leak, because that code is disabled, and has been removed from later versions.
ca275900f7b7980f4b30871ef1a6378bbeeda60f: Bug 999755 - Add neuter() variants to vary data pointer. Also fold in the followup patch in bug 1002864, to ignore disposition when buffer contents can't be changed. r=Waldo, r=sfink, a=lsblakk
Steve Fink <sfink@mozilla.com> - Thu, 24 Apr 2014 14:40:57 -0700 - rev 219832
Push 4 by ryanvm@gmail.com at Mon, 13 Oct 2014 16:45:01 +0000
Bug 999755 - Add neuter() variants to vary data pointer. Also fold in the followup patch in bug 1002864, to ignore disposition when buffer contents can't be changed. r=Waldo, r=sfink, a=lsblakk
d5d12f7343d6dd55924ee8ce6f453c0cb9606706: Bug 859892 - Rename JS_CANONICALIZE_NAN to JS::CanonicalizeNaN. r=Waldo, a=akeybl
Jan de Mooij <jdemooij@mozilla.com> - Thu, 17 Oct 2013 10:16:17 +0200 - rev 218534
Push 4 by ryanvm@gmail.com at Mon, 13 Oct 2014 16:45:01 +0000
Bug 859892 - Rename JS_CANONICALIZE_NAN to JS::CanonicalizeNaN. r=Waldo, a=akeybl
62b491425fa2f7beb0071b5d18eb843bc7a52c92: Bug 1059179 - Add BinarySearchIf(). r=waldo
Georg Fritzsche <georg.fritzsche@googlemail.com> - Mon, 01 Sep 2014 19:26:16 +0200 - rev 217217
Bug 1059179 - Add BinarySearchIf(). r=waldo
4122a2e5ec865f3453076e7d88c49ea311d48f93: Bug 1055842 - Communicate ownership of stolen ArrayBuffer contents, r=Waldo
Steve Fink <sfink@mozilla.com> - Fri, 29 Aug 2014 14:52:36 -0700 - rev 216867
Bug 1055842 - Communicate ownership of stolen ArrayBuffer contents, r=Waldo
15687eac5aa262888992fc6927a4991122233c9e: Bug 1041631, part 2 - Make ES6 Symbols Nightly-only for now. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 21 Aug 2014 16:34:00 -0500 - rev 216575
Bug 1041631, part 2 - Make ES6 Symbols Nightly-only for now. r=Waldo.
9cfdbe321c17621e5f64e470600f9b45beb27f4c: Bug 1041631, part 1 - Change Symbol tests to pass if Symbol is not defined. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 20 Aug 2014 13:30:04 -0500 - rev 216574
Bug 1041631, part 1 - Change Symbol tests to pass if Symbol is not defined. r=Waldo.
df3b50b23153732e91dbf24bf85f152937106ea4: Bug 1053944 - Change RegExp.$N getters to return '' instead of `undefined` for non-matched groups. r=waldo
Till Schneidereit <till@tillschneidereit.net> - Wed, 27 Aug 2014 15:19:30 +0200 - rev 216305
Bug 1053944 - Change RegExp.$N getters to return '' instead of `undefined` for non-matched groups. r=waldo
20bd30f0fb5c581ec2dcb3f7f37ee77e63964c5f: Bug 1057840 (Part 2) - Expand MSVC version bounds for decltype scope operator workaround. r=waldo
Seth Fowler <seth@mozilla.com> - Tue, 26 Aug 2014 13:57:45 -0700 - rev 216077
Bug 1057840 (Part 2) - Expand MSVC version bounds for decltype scope operator workaround. r=waldo
d5cc69b88c4cd2b7ba45b097992ef6dd03e6b412: Bug 1057840 (Part 1) - Expand GCC version bounds for decltype scope operator workaround. r=waldo
Seth Fowler <seth@mozilla.com> - Tue, 26 Aug 2014 13:57:43 -0700 - rev 216076
Bug 1057840 (Part 1) - Expand GCC version bounds for decltype scope operator workaround. r=waldo
cb0080422f7bddc2dc52d9d730884605fff8318e: Bug 1053544 - OdinMonkey: issue link-time validation error when given value with under-defined coercion (r=Waldo)
Luke Wagner <luke@mozilla.com> - Thu, 14 Aug 2014 10:00:37 -0500 - rev 216004
Bug 1053544 - OdinMonkey: issue link-time validation error when given value with under-defined coercion (r=Waldo)
e8e520884505d30ba184c162bb30f15b5210645a: Bug 1045801 - Rename SafeCast to AssertedCast. r=Waldo
Birunthan Mohanathas <birunthan@mohanathas.com> - Mon, 25 Aug 2014 12:17:32 -0700 - rev 215797
Bug 1045801 - Rename SafeCast to AssertedCast. r=Waldo
7283263a197491db6507f37ece921d4aaef13e14: Bug 913586 (Part 9) - Add more useful features to the Maybe<T> API. r=waldo
Seth Fowler <seth@mozilla.com> - Fri, 22 Aug 2014 00:43:02 -0700 - rev 215476
Bug 913586 (Part 9) - Add more useful features to the Maybe<T> API. r=waldo * * * Bug 913586 (Part 10) - Add a test for Maybe<T>. r=waldo
e5474fa8f59368e6841e7b1e42f5a66ddf315720: Bug 1057066: Fix fprintf format string warning. (r=Waldo over IRC)
Eric Faust <efaustbmo@gmail.com> - Thu, 21 Aug 2014 14:27:25 -0700 - rev 215406
Bug 1057066: Fix fprintf format string warning. (r=Waldo over IRC)
6e84c39a1420d3d2b9569df9d41ab4df947e69b6: Bug 1055152 - Remove calls to verifyReturnAddressUsingNativeToBytecodeMap() in JitFrameIterator. r=Waldo
Kannan Vijayan <kvijayan@mozilla.com> - Tue, 19 Aug 2014 18:51:13 -0400 - rev 214795
Bug 1055152 - Remove calls to verifyReturnAddressUsingNativeToBytecodeMap() in JitFrameIterator. r=Waldo
965f780a7aa4d1f53bbd8d0b8e3d0dfbd730042c: Bug 1049957 - Increase MakeUnique max params to 8. - r=waldo
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 15 Aug 2014 17:38:06 -0700 - rev 214254
Bug 1049957 - Increase MakeUnique max params to 8. - r=waldo
6bde3aa7e3171813bcd042c11af9d9d480bac348: Bug 1046964 - Remove some dead code (r=Waldo)
Bill McCloskey <wmccloskey@mozilla.com> - Fri, 15 Aug 2014 16:14:50 -0700 - rev 214252
Bug 1046964 - Remove some dead code (r=Waldo)
c1ea647e6a70de3a80b0d8980c6194e75f02d3c1: Bug 1037358 - Pass the flag in setDataPointer() to indicate whether data is memory-mapped., r=Waldo
Shian-Yow Wu <swu@mozilla.com> - Tue, 15 Jul 2014 03:02:00 -0700 - rev 214129
Bug 1037358 - Pass the flag in setDataPointer() to indicate whether data is memory-mapped., r=Waldo
834c6dadc1b237408291c22c8b47ef1f8fab53c0: Bug 913586 (Part 1) - Revamp Maybe<T> to be usable in many more situations. r=waldo
Seth Fowler <seth@mozilla.com> - Wed, 13 Aug 2014 15:39:40 -0700 - rev 213716
Bug 913586 (Part 1) - Revamp Maybe<T> to be usable in many more situations. r=waldo
d400055c9999e5c228a99a78e8efa5be18861000: Bug 1046964 - Delete the "missing return statement" warning (r=Waldo)
Bill McCloskey <wmccloskey@mozilla.com> - Fri, 08 Aug 2014 21:01:48 -0700 - rev 213096
Bug 1046964 - Delete the "missing return statement" warning (r=Waldo)
a470d0cbe3fab1dc14b122db2de67d3171234cea: Bug 1046964 - Delete the "missing return statement" warning (r=Waldo)
Bill McCloskey <wmccloskey@mozilla.com> - Fri, 08 Aug 2014 17:52:19 -0700 - rev 213045
Bug 1046964 - Delete the "missing return statement" warning (r=Waldo)
9ceccb99d3f1bfcdf58860dfe4f2179a2014135e: Bug 1041631, part 1 - Change Symbol tests to pass if Symbol is not present. r=Waldo, a=testonly.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 19 Aug 2014 18:56:05 -0500 - rev 209583
Bug 1041631, part 1 - Change Symbol tests to pass if Symbol is not present. r=Waldo, a=testonly.
c760537e6dd8e0f9f050f3751c8d78f29e6e20bf: Bug 1053944 - Change RegExp.$N getters to return '' instead of `undefined` for non-matched groups. r=waldo, a=sledru
Till Schneidereit <till@tillschneidereit.net> - Wed, 27 Aug 2014 15:19:30 +0200 - rev 209581
Bug 1053944 - Change RegExp.$N getters to return '' instead of `undefined` for non-matched groups. r=waldo, a=sledru
a2f5fa870c8aaabf3ca79e925988baece89391e1: Bug 966452 part 1. Refactor the js_ReportUncaughtException to produce a (message, JSErrorReport*) pair before reporting. r=waldo and including the fix for bug 1034616 to fix JS tests to deal with this, r=jorendorff. r=terrence on the AutoStableStringChars bits
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 04 Jul 2014 01:24:54 -0400 - rev 208908
Bug 966452 part 1. Refactor the js_ReportUncaughtException to produce a (message, JSErrorReport*) pair before reporting. r=waldo and including the fix for bug 1034616 to fix JS tests to deal with this, r=jorendorff. r=terrence on the AutoStableStringChars bits
8b9e1310637c46d865b3f180efb36e0ba6ea72d5: Bug 1034689 part 1 - Make AndroidBridge JSON parsing work with Latin1 strings. r=Waldo
Jan de Mooij <jdemooij@mozilla.com> - Mon, 14 Jul 2014 15:01:32 +0200 - rev 207605
Bug 1034689 part 1 - Make AndroidBridge JSON parsing work with Latin1 strings. r=Waldo
0197c59b8802b9871379efa94de8791cac7df4a1: Bug 1031550 - Update js_DumpObject for symbol-keyed properties. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Fri, 27 Jun 2014 16:36:56 -0500 - rev 206302
Bug 1031550 - Update js_DumpObject for symbol-keyed properties. r=Waldo.
7750f3e24883a7f3ac3a3988122829b50e28026d: Bug 1029933 - Make Error use a ClassSpec. r=Waldo
Bobby Holley <bobbyholley@gmail.com> - Fri, 04 Jul 2014 12:41:29 -0700 - rev 206256
Bug 1029933 - Make Error use a ClassSpec. r=Waldo
a7b254ac4fc4faaff076d9adadd74c21aa794768: Bug 1029933 - Tweak GenericCreateConstructor to make it usable with Error. r=Waldo
Bobby Holley <bobbyholley@gmail.com> - Fri, 04 Jul 2014 12:41:28 -0700 - rev 206255
Bug 1029933 - Tweak GenericCreateConstructor to make it usable with Error. r=Waldo
30c45b56a2ef3e4a3ceac6d9328922606bc1cfd5: Bug 1029933 - Introduce and use ParentKeyForStandardClass. r=Waldo
Bobby Holley <bobbyholley@gmail.com> - Fri, 04 Jul 2014 12:41:28 -0700 - rev 206254
Bug 1029933 - Introduce and use ParentKeyForStandardClass. r=Waldo
3ff6b5e30818ab1ecaf861d850d50d74cab88692: Bug 1029933 - Introduce the concept of "dependent" standard classes and handle them in the ClassSpec infrastructure. r=Waldo
Bobby Holley <bobbyholley@gmail.com> - Fri, 04 Jul 2014 12:41:28 -0700 - rev 206253
Bug 1029933 - Introduce the concept of "dependent" standard classes and handle them in the ClassSpec infrastructure. r=Waldo
650197ade3b341e9f5f2a61d4684a500c9f17ee6: Bug 1029933 - Tag JSStdName entries by JSProtoKey rather than a js::Class pointer. r=Waldo
Bobby Holley <bobbyholley@gmail.com> - Fri, 04 Jul 2014 12:41:28 -0700 - rev 206252
Bug 1029933 - Tag JSStdName entries by JSProtoKey rather than a js::Class pointer. r=Waldo The former is strictly more information, which matters in the case of Error objects where multiple JSProtoKeys share a js::Class.
4ec31a870cb0b33cc247dc50c5b8cffe8b474d5b: Bug 1029933 - Give BackstagePass an Enumerate hook to match its NewResolve hook. r=Waldo
Bobby Holley <bobbyholley@gmail.com> - Fri, 04 Jul 2014 12:41:27 -0700 - rev 206251
Bug 1029933 - Give BackstagePass an Enumerate hook to match its NewResolve hook. r=Waldo This is required in order to avoid exposing resolve hook effects when Object.freeze() is invoked on the global. The freeze() call first enumerates the object, after which point any lazy properties need to be resolve so that we can safely mark the object as non-extensible.
207ccc9f5c2ccdd88bc7b8cc1f9ab9c683f6da08: Bug 966452 part 1. Refactor the js_ReportUncaughtException to produce a (message, JSErrorReport*) pair before reporting. r=waldo
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 04 Jul 2014 01:24:54 -0400 - rev 206127
Bug 966452 part 1. Refactor the js_ReportUncaughtException to produce a (message, JSErrorReport*) pair before reporting. r=waldo
df60afd3e3a7198698402cbfe885adf7f5dbeae9: Bug 1029215 - remove 'using namespace mozilla' from js/src (r=waldo)
Luke Wagner <luke@mozilla.com> - Wed, 25 Jun 2014 11:24:10 -0500 - rev 204825
Bug 1029215 - remove 'using namespace mozilla' from js/src (r=waldo)
7834122e3262f03f62d33c561e657f09e6676be1: Bug 920484 - Use empty objects when initialising Intl prototypes. r=waldo
André Bargull <andrebargull@googlemail.com> - Tue, 24 Jun 2014 04:45:00 -0400 - rev 204566
Bug 920484 - Use empty objects when initialising Intl prototypes. r=waldo
a2f87c54b7c87497738317bdc4ac1cda5f9bb5b5: Bug 1028945 - Allow building ICU with clang-cl; r=Waldo
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 24 Jun 2014 07:19:45 -0700 - rev 204337
Bug 1028945 - Allow building ICU with clang-cl; r=Waldo
43a7ce129020b6c34182b6750f521fe5b7f43077: Bug 836073 - Add MOZ_MSVC_VERSION_AT_LEAST() macro to mfbt/Compiler.h. r=Waldo
Birunthan Mohanathas <birunthan@mohanathas.com> - Fri, 20 Jun 2014 09:19:35 -0700 - rev 204145
Bug 836073 - Add MOZ_MSVC_VERSION_AT_LEAST() macro to mfbt/Compiler.h. r=Waldo
adc814d90d4d16b83d65034b0f3487f173816452: Bug 645416, part 28 - Update Object.prototype.toSource for symbol-keyed properties. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 23 Jun 2014 10:57:03 -0500 - rev 204087
Bug 645416, part 28 - Update Object.prototype.toSource for symbol-keyed properties. r=Waldo. The new output uses syntax with square brackets: {[Symbol.for("key")]: "value"} This syntax is not yet supported in SpiderMonkey, but it is part of ES6 (see bug 924688 or search the ES6 drafts for ComputedPropertyName).
dfefe211d083191c0ca99f865958d0839cbdc31e: Bug 645416, part 27 - Implement Object.getOwnPropertySymbols(). r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 23 Jun 2014 10:57:03 -0500 - rev 204086
Bug 645416, part 27 - Implement Object.getOwnPropertySymbols(). r=Waldo.
c763de6a2fde3ef9741a4960574ebe72f4af1b81: Bug 645416, part 25 - Add support for enumerating symbol-keyed properties. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 23 Jun 2014 10:57:03 -0500 - rev 204084
Bug 645416, part 25 - Add support for enumerating symbol-keyed properties. r=Waldo. Object.keys, Object.getOwnPropertyNames, and for-in loops skip symbol-keyed properties per spec, but Object.defineProperties sees them, and a future Reflect.ownKeys API will need to be able to see them. This patch changes the comments on JSITER_FOREACH and JSITER_KEYVALUE, but not the behavior. The comments were just wrong.
57d65c06db19df44514f5b848f9cb557b325a0c1: Bug 1027157 - Make warnings reported with JSEXN_NONE so that they don't appear as errors in the console. r=Waldo
Nick Fitzgerald <fitzgen@mozilla.com> - Thu, 19 Jun 2014 15:44:00 -0400 - rev 204050
Bug 1027157 - Make warnings reported with JSEXN_NONE so that they don't appear as errors in the console. r=Waldo
17cf9036f67f2df4b1bc0e4b0123bcd487d97b0f: Bug 1027528 part 7 - Make Range mStart/mEnd const, fix operator[]. r=Waldo
Jan de Mooij <jdemooij@mozilla.com> - Fri, 20 Jun 2014 17:39:42 +0200 - rev 203649
Bug 1027528 part 7 - Make Range mStart/mEnd const, fix operator[]. r=Waldo
a03ae2d574c27be6f136219760f13136b01cbb98: Bug 1027528 part 4 - Make JSON Quote function handle Latin1 strings. r=Waldo
Jan de Mooij <jdemooij@mozilla.com> - Fri, 20 Jun 2014 12:39:46 +0200 - rev 203553
Bug 1027528 part 4 - Make JSON Quote function handle Latin1 strings. r=Waldo
21035d61ea2462e6e4e1cadd2419bcf93ec60e57: Bug 1027528 part 3 - Make JS_EncodeString and friends handle Latin1 strings. r=Waldo
Jan de Mooij <jdemooij@mozilla.com> - Fri, 20 Jun 2014 12:39:44 +0200 - rev 203552
Bug 1027528 part 3 - Make JS_EncodeString and friends handle Latin1 strings. r=Waldo
8eeb287c59fd0b7a8b3a0b66161b52c5833ac523: Bug 1026718 - Expand MOZ_DECLARE_REFCOUNTED_TYPENAME unconditioanlly in order to make it available outside of libxul as well; r=Waldo
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 18 Jun 2014 20:11:21 -0400 - rev 203280
Bug 1026718 - Expand MOZ_DECLARE_REFCOUNTED_TYPENAME unconditioanlly in order to make it available outside of libxul as well; r=Waldo